From 527426ddbb8df2eabf0a2f4d5eb2cd39a03516cc Mon Sep 17 00:00:00 2001 From: andz-bb Date: Tue, 1 Aug 2023 16:29:04 +0100 Subject: [PATCH 1/3] fix for saving external data connector query param values --- .../automation/SetupPanel/AutomationBlockSetup.svelte | 2 +- .../components/automation/SetupPanel/QueryParamSelector.svelte | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte b/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte index cece075860..0ba909d56b 100644 --- a/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte +++ b/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte @@ -108,7 +108,7 @@ /****************************************************/ const getInputData = (testData, blockInputs) => { - let newInputData = testData || blockInputs + let newInputData = cloneDeep(testData || blockInputs) if (block.event === "app:trigger" && !newInputData?.fields) { newInputData = cloneDeep(blockInputs) } diff --git a/packages/builder/src/components/automation/SetupPanel/QueryParamSelector.svelte b/packages/builder/src/components/automation/SetupPanel/QueryParamSelector.svelte index 9c47178b0e..52310001ff 100644 --- a/packages/builder/src/components/automation/SetupPanel/QueryParamSelector.svelte +++ b/packages/builder/src/components/automation/SetupPanel/QueryParamSelector.svelte @@ -4,7 +4,6 @@ import { Select } from "@budibase/bbui" import DrawerBindableInput from "../../common/bindings/DrawerBindableInput.svelte" import AutomationBindingPanel from "../../common/bindings/ServerBindingPanel.svelte" - const dispatch = createEventDispatcher() export let value @@ -50,6 +49,7 @@ type="string" {bindings} fillWidth={true} + updateOnChange={false} /> {/each} From 5f084699d2b43b33ac8f6e9c6d033cfbaaf4553f Mon Sep 17 00:00:00 2001 From: Andrew Thompson <110921612+andz-bb@users.noreply.github.com> Date: Tue, 1 Aug 2023 17:09:52 +0100 Subject: [PATCH 2/3] didn't mean to remove a line --- .../components/automation/SetupPanel/QueryParamSelector.svelte | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/builder/src/components/automation/SetupPanel/QueryParamSelector.svelte b/packages/builder/src/components/automation/SetupPanel/QueryParamSelector.svelte index 52310001ff..250d235266 100644 --- a/packages/builder/src/components/automation/SetupPanel/QueryParamSelector.svelte +++ b/packages/builder/src/components/automation/SetupPanel/QueryParamSelector.svelte @@ -4,6 +4,7 @@ import { Select } from "@budibase/bbui" import DrawerBindableInput from "../../common/bindings/DrawerBindableInput.svelte" import AutomationBindingPanel from "../../common/bindings/ServerBindingPanel.svelte" + const dispatch = createEventDispatcher() export let value From c372bb9a1882a3df79485484b9ca21f388937989 Mon Sep 17 00:00:00 2001 From: andz-bb Date: Wed, 2 Aug 2023 09:35:42 +0100 Subject: [PATCH 3/3] remove redundant cloneDeep --- .../automation/SetupPanel/AutomationBlockSetup.svelte | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte b/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte index 0ba909d56b..0ab933d925 100644 --- a/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte +++ b/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte @@ -109,9 +109,6 @@ const getInputData = (testData, blockInputs) => { let newInputData = cloneDeep(testData || blockInputs) - if (block.event === "app:trigger" && !newInputData?.fields) { - newInputData = cloneDeep(blockInputs) - } /** * TODO - Remove after November 2023