From 74eb0357a4b7a926b5be996b742c1eff3c33dbb8 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Tue, 3 Sep 2024 10:15:26 +0200
Subject: [PATCH] Rename link relationship fields

---
 .../server/src/api/controllers/table/index.ts |  3 ++
 .../src/api/routes/tests/viewV2.spec.ts       | 18 +++----
 packages/server/src/sdk/app/views/index.ts    | 48 +++++++++++++++++++
 3 files changed, 60 insertions(+), 9 deletions(-)

diff --git a/packages/server/src/api/controllers/table/index.ts b/packages/server/src/api/controllers/table/index.ts
index bb97a89f6d..0e16077092 100644
--- a/packages/server/src/api/controllers/table/index.ts
+++ b/packages/server/src/api/controllers/table/index.ts
@@ -116,6 +116,9 @@ export async function save(ctx: UserCtx<SaveTableRequest, SaveTableResponse>) {
   } else {
     await events.table.updated(savedTable)
   }
+  if (renaming) {
+    await sdk.views.renameLinkedViews(savedTable, renaming)
+  }
   if (isImport) {
     await events.table.imported(savedTable)
   }
diff --git a/packages/server/src/api/routes/tests/viewV2.spec.ts b/packages/server/src/api/routes/tests/viewV2.spec.ts
index 699d388a6d..9d14a52815 100644
--- a/packages/server/src/api/routes/tests/viewV2.spec.ts
+++ b/packages/server/src/api/routes/tests/viewV2.spec.ts
@@ -1204,18 +1204,18 @@ describe.each([
           )
           await config.api.table.save({
             ...table,
-              schema: {
+            schema: {
               ...table.schema,
-                aux: {
-                  name: "aux",
-                  relationshipType: RelationshipType.ONE_TO_MANY,
-                  type: FieldType.LINK,
-                  tableId: auxTable._id!,
-                  fieldName: "fk_aux",
+              aux: {
+                name: "aux",
+                relationshipType: RelationshipType.ONE_TO_MANY,
+                type: FieldType.LINK,
+                tableId: auxTable._id!,
+                fieldName: "fk_aux",
                 constraints: { type: "array" },
-                },
               },
-            })
+            },
+          })
           // Refetch auxTable
           auxTable = await config.api.table.get(auxTable._id!)
 
diff --git a/packages/server/src/sdk/app/views/index.ts b/packages/server/src/sdk/app/views/index.ts
index 9cd11712ed..120b56183c 100644
--- a/packages/server/src/sdk/app/views/index.ts
+++ b/packages/server/src/sdk/app/views/index.ts
@@ -1,6 +1,7 @@
 import {
   FieldType,
   RelationSchemaField,
+  RelationshipFieldMetadata,
   RenameColumn,
   Table,
   TableSchema,
@@ -252,3 +253,50 @@ export function syncSchema(
 
   return view
 }
+
+export async function renameLinkedViews(table: Table, renaming: RenameColumn) {
+  const relatedLinks: Record<string, RelationshipFieldMetadata[]> = {}
+
+  for (const field of Object.values(table.schema)) {
+    if (field.type !== FieldType.LINK) {
+      continue
+    }
+
+    relatedLinks[field.tableId] ??= []
+    relatedLinks[field.tableId].push(field)
+  }
+
+  const relatedTables = await sdk.tables.getTables(Object.keys(relatedLinks))
+  for (const relatedTable of relatedTables) {
+    let toSave = false
+    const viewsV2 = Object.values(relatedTable.views || {}).filter(
+      sdk.views.isV2
+    )
+    if (!viewsV2) {
+      continue
+    }
+
+    for (const view of viewsV2) {
+      for (const relField of Object.keys(view.schema || {}).filter(f => {
+        const tableField = relatedTable.schema[f]
+        if (tableField.type !== FieldType.LINK) {
+          return false
+        }
+
+        return tableField.tableId === table._id
+      })) {
+        const columns = view.schema && view.schema[relField]?.columns
+
+        if (columns && columns[renaming.old]) {
+          columns[renaming.updated] = columns[renaming.old]
+          delete columns[renaming.old]
+          toSave = true
+        }
+      }
+    }
+
+    if (toSave) {
+      await sdk.tables.saveTable(relatedTable)
+    }
+  }
+}