MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not rquire min length for all password fields

This commit is contained in:
Adria Navarro 2023-06-19 14:53:02 +01:00
parent 702f59a90e
commit 76ac28f550
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/builder/src/components/start/ExportAppModal.svelte
View File

@ -16,7 +16,7 @@
let password = null let password = null
const validation = createValidationStore() const validation = createValidationStore()
validation.addValidatorType("password", "password", true) validation.addValidatorType("password", "password", true, { minLength: 8 })
$: validation.observe("password", password) $: validation.observe("password", password)
const Step = { CONFIG: "config", SET_PASSWORD: "set_password" } const Step = { CONFIG: "config", SET_PASSWORD: "set_password" }

9
packages/builder/src/helpers/validation/yup/index.js
View File

@ -21,7 +21,7 @@ export const createValidationStore = () => {
validator[propertyName] = propertyValidator validator[propertyName] = propertyValidator
} }
const addValidatorType = (propertyName, type, required) => { const addValidatorType = (propertyName, type, required, options) => {
if (!type || !propertyName) { if (!type || !propertyName) {
return return
} }
@ -45,11 +45,8 @@ export const createValidationStore = () => {
propertyValidator = propertyValidator.required() propertyValidator = propertyValidator.required()
} }
// We want to do this after the possible required validation, to prioritise the required error if (options?.minLength) {
switch (type) { propertyValidator = propertyValidator.min(options.minLength)
case "password":
propertyValidator = propertyValidator.min(8)
break
} }
validator[propertyName] = propertyValidator validator[propertyName] = propertyValidator