From 78bd36304eb213921f1756a3600491ec79012d6f Mon Sep 17 00:00:00 2001 From: Martin McKeaveney Date: Tue, 6 Jul 2021 18:54:08 +0100 Subject: [PATCH] prevent editing public role in apps --- .../src/components/backend/DataTable/modals/EditRoles.svelte | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/builder/src/components/backend/DataTable/modals/EditRoles.svelte b/packages/builder/src/components/backend/DataTable/modals/EditRoles.svelte index f58b9f197f..0ee4553f37 100644 --- a/packages/builder/src/components/backend/DataTable/modals/EditRoles.svelte +++ b/packages/builder/src/components/backend/DataTable/modals/EditRoles.svelte @@ -10,6 +10,8 @@ let selectedRole = {} let errors = [] let builtInRoles = ["Admin", "Power", "Basic", "Public"] + // Don't allow editing of public role + $: allRoles = $roles.filter(role => role._id !== "PUBLIC") $: selectedRoleId = selectedRole._id $: otherRoles = $roles.filter(role => role._id !== selectedRoleId) $: isCreating = selectedRoleId == null || selectedRoleId === "" @@ -96,7 +98,7 @@ label="Role" value={selectedRoleId} on:change={changeRole} - options={$roles} + options={allRoles} placeholder="Create new role" getOptionValue={role => role._id} getOptionLabel={role => role.name}