MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes discovered by MS-SQL validator tests in QA-core, fixing custom ports being used (not default) and allowing the use of self signed certificates. Also updating an error message in line with Peters changes.

This commit is contained in:
mike12345567 2023-06-29 15:08:14 +01:00 committed by Adria Navarro
parent 3e62953947
commit 7b6246ee59
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/server/src/integrations/microsoftSqlServer.ts
View File

@ -186,10 +186,11 @@ class SqlServerIntegration extends Sql implements DatasourcePlus {
try { try {
const clientCfg: MSSQLConfig & sqlServer.config = { const clientCfg: MSSQLConfig & sqlServer.config = {
...this.config, ...this.config,
port: +this.config, port: +this.config.port,
options: { options: {
encrypt: this.config.encrypt, encrypt: this.config.encrypt,
enableArithAbort: true, enableArithAbort: true,
trustServerCertificate: true,
}, },
} }
delete clientCfg.encrypt delete clientCfg.encrypt

2
qa-core/src/integrations/validators/mssql.integration.spec.ts
View File

@ -58,7 +58,7 @@ describe("datasource validators", () => {
const result = await integration.testConnection() const result = await integration.testConnection()
expect(result).toEqual({ expect(result).toEqual({
connected: false, connected: false,
error: "ConnectionError: Login failed for user 'sa'.", error: "Login failed for user 'sa'.",
}) })
}) })
}) })