MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix crashing when determining roles when no apps exist

This commit is contained in:
Andrew Kingston 2022-08-02 16:01:38 +01:00
parent 1bcb7a05b5
commit 7c4bf7aedd
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
packages/backend-core/src/security/roles.js
View File

@ -203,15 +203,24 @@ exports.getAllRoles = async appId => {
if (appId) { if (appId) {
return doWithDB(appId, internal) return doWithDB(appId, internal)
} else { } else {
return internal(getAppDB()) let appDB
try {
appDB = getAppDB()
} catch (error) {
// We don't have any apps, so we'll just use the built-in roles
}
return internal(appDB)
} }
async function internal(db) { async function internal(db) {
const body = await db.allDocs( let roles = []
getRoleParams(null, { if (db) {
include_docs: true, const body = await db.allDocs(
}) getRoleParams(null, {
) include_docs: true,
let roles = body.rows.map(row => row.doc) })
)
roles = body.rows.map(row => row.doc)
}
const builtinRoles = exports.getBuiltinRoles() const builtinRoles = exports.getBuiltinRoles()
// need to combine builtin with any DB record of them (for sake of permissions) // need to combine builtin with any DB record of them (for sake of permissions)