MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify determineFeatureFlags

This commit is contained in:
Adria Navarro 2025-01-08 12:49:17 +01:00
parent d465f7e057
commit 7d7c27fa92
6 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/frontend-core/src/fetch/DataFetch.ts
View File

@ -216,7 +216,7 @@ export default abstract class DataFetch<
const definition = await this.getDefinition(datasource) const definition = await this.getDefinition(datasource)
// Determine feature flags // Determine feature flags
const features = this.determineFeatureFlags(definition) const features = await this.determineFeatureFlags()
this.features = { this.features = {
supportsSearch: !!features?.supportsSearch, supportsSearch: !!features?.supportsSearch,
supportsSort: !!features?.supportsSort, supportsSort: !!features?.supportsSort,
@ -421,14 +421,13 @@ export default abstract class DataFetch<
} }
/** /**
* Determine the feature flag for this datasource definition * Determine the feature flag for this datasource
* @param definition
*/ */
determineFeatureFlags(_definition: TDefinition | null): { async determineFeatureFlags(): Promise<{
supportsPagination: boolean supportsPagination: boolean
supportsSearch?: boolean supportsSearch?: boolean
supportsSort?: boolean supportsSort?: boolean
} { }> {
return { return {
supportsSearch: false, supportsSearch: false,
supportsSort: false, supportsSort: false,

2
packages/frontend-core/src/fetch/GroupUserFetch.ts
View File

@ -26,7 +26,7 @@ export default class GroupUserFetch extends DataFetch<
}) })
} }
determineFeatureFlags() { async determineFeatureFlags() {
return { return {
supportsSearch: true, supportsSearch: true,
supportsSort: false, supportsSort: false,

3
packages/frontend-core/src/fetch/QueryFetch.ts
View File

@ -11,7 +11,8 @@ interface QueryDatasource {
} }
export default class QueryFetch extends DataFetch<QueryDatasource, Query> { export default class QueryFetch extends DataFetch<QueryDatasource, Query> {
determineFeatureFlags(definition: Query) { async determineFeatureFlags() {
const definition = await this.getDefinition(this.options.datasource)
const supportsPagination = const supportsPagination =
!!definition?.fields?.pagination?.type && !!definition?.fields?.pagination?.type &&
!!definition?.fields?.pagination?.location && !!definition?.fields?.pagination?.location &&

2
packages/frontend-core/src/fetch/TableFetch.ts
View File

@ -3,7 +3,7 @@ import DataFetch from "./DataFetch"
import { SortOrder, Table, UITable } from "@budibase/types" import { SortOrder, Table, UITable } from "@budibase/types"
export default class TableFetch extends DataFetch<UITable, Table> { export default class TableFetch extends DataFetch<UITable, Table> {
determineFeatureFlags() { async determineFeatureFlags() {
return { return {
supportsSearch: true, supportsSearch: true,
supportsSort: true, supportsSort: true,

2
packages/frontend-core/src/fetch/UserFetch.ts
View File

@ -34,7 +34,7 @@ export default class UserFetch extends DataFetch<
}) })
} }
determineFeatureFlags() { async determineFeatureFlags() {
return { return {
supportsSearch: true, supportsSearch: true,
supportsSort: false, supportsSort: false,

2
packages/frontend-core/src/fetch/ViewV2Fetch.ts
View File

@ -4,7 +4,7 @@ import { get } from "svelte/store"
import { helpers } from "@budibase/shared-core" import { helpers } from "@budibase/shared-core"
export default class ViewV2Fetch extends DataFetch<UIView, ViewV2> { export default class ViewV2Fetch extends DataFetch<UIView, ViewV2> {
determineFeatureFlags() { async determineFeatureFlags() {
return { return {
supportsSearch: true, supportsSearch: true,
supportsSort: true, supportsSort: true,