Simplify determineFeatureFlags

packages/frontend-core/src/fetch/DataFetch.ts

@@ -216,7 +216,7 @@ export default abstract class DataFetch<
     const definition = await this.getDefinition(datasource)
 
     // Determine feature flags
-    const features = this.determineFeatureFlags(definition)
+    const features = await this.determineFeatureFlags()
     this.features = {
       supportsSearch: !!features?.supportsSearch,
       supportsSort: !!features?.supportsSort,
@@ -421,14 +421,13 @@ export default abstract class DataFetch<
   }
 
   /**
-   * Determine the feature flag for this datasource definition
-   * @param definition
+   * Determine the feature flag for this datasource
    */
-  determineFeatureFlags(_definition: TDefinition | null): {
+  async determineFeatureFlags(): Promise<{
     supportsPagination: boolean
     supportsSearch?: boolean
     supportsSort?: boolean
-  } {
+  }> {
     return {
       supportsSearch: false,
       supportsSort: false,

packages/frontend-core/src/fetch/GroupUserFetch.ts

@@ -26,7 +26,7 @@ export default class GroupUserFetch extends DataFetch<
     })
   }
 
-  determineFeatureFlags() {
+  async determineFeatureFlags() {
     return {
       supportsSearch: true,
       supportsSort: false,

packages/frontend-core/src/fetch/QueryFetch.ts

@@ -11,7 +11,8 @@ interface QueryDatasource {
 }
 
 export default class QueryFetch extends DataFetch<QueryDatasource, Query> {
-  determineFeatureFlags(definition: Query) {
+  async determineFeatureFlags() {
+    const definition = await this.getDefinition(this.options.datasource)
     const supportsPagination =
       !!definition?.fields?.pagination?.type &&
       !!definition?.fields?.pagination?.location &&

packages/frontend-core/src/fetch/TableFetch.ts

@@ -3,7 +3,7 @@ import DataFetch from "./DataFetch"
 import { SortOrder, Table, UITable } from "@budibase/types"
 
 export default class TableFetch extends DataFetch<UITable, Table> {
-  determineFeatureFlags() {
+  async determineFeatureFlags() {
     return {
       supportsSearch: true,
       supportsSort: true,

packages/frontend-core/src/fetch/UserFetch.ts

@@ -34,7 +34,7 @@ export default class UserFetch extends DataFetch<
     })
   }
 
-  determineFeatureFlags() {
+  async determineFeatureFlags() {
     return {
       supportsSearch: true,
       supportsSort: false,

packages/frontend-core/src/fetch/ViewV2Fetch.ts

@@ -4,7 +4,7 @@ import { get } from "svelte/store"
 import { helpers } from "@budibase/shared-core"
 
 export default class ViewV2Fetch extends DataFetch<UIView, ViewV2> {
-  determineFeatureFlags() {
+  async determineFeatureFlags() {
     return {
       supportsSearch: true,
       supportsSort: true,