From 8371c3f6442508dacae8fa94fcf5050b38d505ee Mon Sep 17 00:00:00 2001 From: Gerard Burns Date: Wed, 5 Jul 2023 12:56:04 +0100 Subject: [PATCH 1/3] Allow suppressing block row creation alerts --- packages/client/manifest.json | 20 +++++++++++++++++++ .../components/app/blocks/TableBlock.svelte | 3 +++ .../app/blocks/form/FormBlock.svelte | 2 ++ .../app/blocks/form/InnerFormBlock.svelte | 2 ++ 4 files changed, 27 insertions(+) diff --git a/packages/client/manifest.json b/packages/client/manifest.json index 212042d3c0..b28b62393d 100644 --- a/packages/client/manifest.json +++ b/packages/client/manifest.json @@ -4490,6 +4490,16 @@ "setting": "clickBehaviour", "value": "details" } + }, + { + "type": "boolean", + "label": "Do not display default save notification", + "key": "notificationOverride", + "defaultValue": false, + "dependsOn": { + "setting": "clickBehaviour", + "value": "details" + } } ] }, @@ -5127,6 +5137,16 @@ "value": "View", "invert": true } + }, + { + "type": "boolean", + "label": "Do not display default save notification", + "key": "notificationOverride", + "defaultValue": false, + "dependsOn": { + "setting": "showSaveButton", + "value": true + } } ] } diff --git a/packages/client/src/components/app/blocks/TableBlock.svelte b/packages/client/src/components/app/blocks/TableBlock.svelte index e45b53880d..492990ad01 100644 --- a/packages/client/src/components/app/blocks/TableBlock.svelte +++ b/packages/client/src/components/app/blocks/TableBlock.svelte @@ -30,6 +30,7 @@ export let sidePanelShowDelete export let sidePanelSaveLabel export let sidePanelDeleteLabel + export let notificationOverride const { fetchDatasourceSchema, API } = getContext("sdk") const stateKey = `ID_${generate()}` @@ -253,6 +254,7 @@ fields: sidePanelFields || normalFields, title: editTitle, labelPosition: "left", + notificationOverride, }} /> @@ -277,6 +279,7 @@ fields: sidePanelFields || normalFields, title: "Create Row", labelPosition: "left", + notificationOverride, }} /> diff --git a/packages/client/src/components/app/blocks/form/FormBlock.svelte b/packages/client/src/components/app/blocks/form/FormBlock.svelte index 6874c23cf4..20faee9013 100644 --- a/packages/client/src/components/app/blocks/form/FormBlock.svelte +++ b/packages/client/src/components/app/blocks/form/FormBlock.svelte @@ -19,6 +19,7 @@ export let rowId export let actionUrl export let noRowsMessage + export let notificationOverride const { fetchDatasourceSchema } = getContext("sdk") @@ -87,6 +88,7 @@ showDeleteButton, schema, repeaterId, + notificationOverride, } const fetchSchema = async () => { diff --git a/packages/client/src/components/app/blocks/form/InnerFormBlock.svelte b/packages/client/src/components/app/blocks/form/InnerFormBlock.svelte index b89ec4bcab..7a337921e0 100644 --- a/packages/client/src/components/app/blocks/form/InnerFormBlock.svelte +++ b/packages/client/src/components/app/blocks/form/InnerFormBlock.svelte @@ -17,6 +17,7 @@ export let showDeleteButton export let schema export let repeaterId + export let notificationOverride const FieldTypeToComponentMap = { string: "stringfield", @@ -46,6 +47,7 @@ parameters: { providerId: formId, tableId: dataSource?.tableId, + notificationOverride, }, }, { From e3be968b27e263609a25b3e616e7322dd2c62463 Mon Sep 17 00:00:00 2001 From: Gerard Burns Date: Thu, 6 Jul 2023 09:19:50 +0100 Subject: [PATCH 2/3] pr feedback --- packages/client/manifest.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/client/manifest.json b/packages/client/manifest.json index b28b62393d..d9a6e2f162 100644 --- a/packages/client/manifest.json +++ b/packages/client/manifest.json @@ -4493,7 +4493,7 @@ }, { "type": "boolean", - "label": "Do not display default save notification", + "label": "Hide save alert", "key": "notificationOverride", "defaultValue": false, "dependsOn": { @@ -5140,7 +5140,7 @@ }, { "type": "boolean", - "label": "Do not display default save notification", + "label": "Hide save alert", "key": "notificationOverride", "defaultValue": false, "dependsOn": { From 6734fe6be42dd90d8db37225fc0d97a46ed9ea36 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Tue, 11 Jul 2023 11:06:06 +0100 Subject: [PATCH 3/3] Update label --- packages/client/manifest.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/client/manifest.json b/packages/client/manifest.json index d9a6e2f162..970a8b3705 100644 --- a/packages/client/manifest.json +++ b/packages/client/manifest.json @@ -4493,7 +4493,7 @@ }, { "type": "boolean", - "label": "Hide save alert", + "label": "Hide notifications", "key": "notificationOverride", "defaultValue": false, "dependsOn": { @@ -5140,7 +5140,7 @@ }, { "type": "boolean", - "label": "Hide save alert", + "label": "Hide notifications", "key": "notificationOverride", "defaultValue": false, "dependsOn": {