From 871e9b123edfd60628949a1ae93336a9bf38bf99 Mon Sep 17 00:00:00 2001
From: Michael Drury <me@michaeldrury.co.uk>
Date: Mon, 2 Nov 2020 22:46:31 +0000
Subject: [PATCH] Some further work, logout and preview appear to be working
 much better now.

---
 packages/builder/cypress/support/cookies.js           |  2 +-
 .../builder/src/pages/[application]/_reset.svelte     |  3 ++-
 packages/client/tests/testAppDef.js                   |  2 +-
 .../server/src/api/routes/tests/couchTestUtils.js     |  4 ++--
 packages/server/src/utilities/index.js                |  4 ++--
 packages/standard-components/src/Navigation.svelte    | 11 ++++++++---
 6 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/packages/builder/cypress/support/cookies.js b/packages/builder/cypress/support/cookies.js
index 1c172f4d4c..1245f84960 100644
--- a/packages/builder/cypress/support/cookies.js
+++ b/packages/builder/cypress/support/cookies.js
@@ -1,3 +1,3 @@
 Cypress.Cookies.defaults({
-  preserve: "builder:token",
+  preserve: "budibase:builder:local",
 })
diff --git a/packages/builder/src/pages/[application]/_reset.svelte b/packages/builder/src/pages/[application]/_reset.svelte
index d1d682d0b9..06942e03c8 100644
--- a/packages/builder/src/pages/[application]/_reset.svelte
+++ b/packages/builder/src/pages/[application]/_reset.svelte
@@ -84,7 +84,8 @@
       <Button
         secondary
         on:click={() => {
-          document.cookie = 'budibase:token=; Path=/; Expires=Thu, 01 Jan 1970 00:00:01 GMT;'
+          // reset cookies for this app
+          document.cookie = `budibase:${application}:local=; Path=/; Expires=Thu, 01 Jan 1970 00:00:01 GMT;`
           window.open(`/${application}`)
         }}>
         Preview
diff --git a/packages/client/tests/testAppDef.js b/packages/client/tests/testAppDef.js
index 90dbd2717d..803a7f770b 100644
--- a/packages/client/tests/testAppDef.js
+++ b/packages/client/tests/testAppDef.js
@@ -9,7 +9,7 @@ export const load = async (page, screens, url, host = "test.com") => {
   const cookieJar = new jsdom.CookieJar()
   const cookie = `${btoa("{}")}.${btoa('{"appId":"TEST_APP_ID"}')}.signature`
   cookieJar.setCookie(
-    `budibase:local:TEST_APP_ID=${cookie};domain=${host};path=/`,
+    `budibase:TEST_APP_ID:local=${cookie};domain=${host};path=/`,
     fullUrl,
     {
       looseMode: false,
diff --git a/packages/server/src/api/routes/tests/couchTestUtils.js b/packages/server/src/api/routes/tests/couchTestUtils.js
index 6a4e67bfc7..07ff407e3d 100644
--- a/packages/server/src/api/routes/tests/couchTestUtils.js
+++ b/packages/server/src/api/routes/tests/couchTestUtils.js
@@ -34,7 +34,7 @@ exports.defaultHeaders = appId => {
 
   return {
     Accept: "application/json",
-    Cookie: [`builder:token=${builderToken}`],
+    Cookie: [`budibase:builder=${builderToken}:local`],
   }
 }
 
@@ -209,7 +209,7 @@ const createUserWithPermissions = async (
 
   const loginResult = await request
     .post(`/api/authenticate`)
-    .set({ Cookie: `budibase:${appId}=${anonToken}` })
+    .set({ Cookie: `budibase:${appId}:local=${anonToken}` })
     .send({ username, password })
 
   // returning necessary request headers
diff --git a/packages/server/src/utilities/index.js b/packages/server/src/utilities/index.js
index 4c324cbfdf..47db3f7ec1 100644
--- a/packages/server/src/utilities/index.js
+++ b/packages/server/src/utilities/index.js
@@ -37,6 +37,6 @@ exports.getAppId = ctx => {
  * @returns {string} The name of the token trying to find
  */
 exports.getCookieName = (appId = null) => {
-  let mid = env.CLOUD ? "cloud" : "local"
-  return `budibase:${mid}:${appId ? appId : "builder"}`
+  let environment = env.CLOUD ? "cloud" : "local"
+  return `budibase:${appId ? appId : "builder"}:${environment}`
 }
diff --git a/packages/standard-components/src/Navigation.svelte b/packages/standard-components/src/Navigation.svelte
index bb0863fe2c..0ee5fc7f23 100644
--- a/packages/standard-components/src/Navigation.svelte
+++ b/packages/standard-components/src/Navigation.svelte
@@ -18,9 +18,14 @@
   }
 
   const logOut = () => {
-    document.cookie =
-      "budibase:token=; Path=/; Expires=Thu, 01 Jan 1970 00:00:01 GMT;"
-    location.reload()
+    // TODO: not the best way to clear cookie, try to find better way
+    const appId = location.pathname.split("/")[1]
+    if (appId) {
+      for (let environment of ["local", "cloud"]) {
+        document.cookie = `budibase:${appId}:${environment}=; Path=/; Expires=Thu, 01 Jan 1970 00:00:01 GMT;`
+      }
+    }
+    location.href=`/${appId}`
   }
 </script>