From 87b081a06f3848547ebdaf558c9acb2d88e91abb Mon Sep 17 00:00:00 2001
From: Sam Rose <hello@samwho.dev>
Date: Mon, 27 Jan 2025 17:40:51 +0000
Subject: [PATCH] Fix lint.

---
 packages/bbui/src/Actions/position_dropdown.ts   | 12 +++++++-----
 packages/bbui/src/Form/Core/CheckboxGroup.svelte | 11 +++++++++--
 packages/bbui/src/Form/Core/Combobox.svelte      |  8 ++++++--
 packages/bbui/src/Popover/Popover.svelte         | 12 ++++--------
 4 files changed, 26 insertions(+), 17 deletions(-)

diff --git a/packages/bbui/src/Actions/position_dropdown.ts b/packages/bbui/src/Actions/position_dropdown.ts
index ba27ccc1d4..02cda87710 100644
--- a/packages/bbui/src/Actions/position_dropdown.ts
+++ b/packages/bbui/src/Actions/position_dropdown.ts
@@ -25,6 +25,12 @@ export interface Styles {
   top: number
 }
 
+export type UpdateHandler = (
+  anchorBounds: DOMRect,
+  elementBounds: DOMRect,
+  styles: Styles
+) => Styles
+
 interface Opts {
   anchor?: HTMLElement
   align: string
@@ -33,11 +39,7 @@ interface Opts {
   minWidth?: number
   useAnchorWidth: boolean
   offset: number
-  customUpdate?: (
-    anchorBounds: DOMRect,
-    elementBounds: DOMRect,
-    styles: Styles
-  ) => Styles
+  customUpdate?: UpdateHandler
   resizable: boolean
   wrap: boolean
 }
diff --git a/packages/bbui/src/Form/Core/CheckboxGroup.svelte b/packages/bbui/src/Form/Core/CheckboxGroup.svelte
index c318a3156b..5eac359d26 100644
--- a/packages/bbui/src/Form/Core/CheckboxGroup.svelte
+++ b/packages/bbui/src/Form/Core/CheckboxGroup.svelte
@@ -1,3 +1,8 @@
+<script lang="ts" context="module">
+  type O = any
+  type V = any
+</script>
+
 <script lang="ts" generics="O, V">
   import "@spectrum-css/fieldgroup/dist/index-vars.css"
   import "@spectrum-css/radio/dist/index-vars.css"
@@ -8,8 +13,8 @@
   export let options: O[] = []
   export let disabled = false
   export let readonly = false
-  export let getOptionLabel: (option: O) => string = (option: O) => `${option}`
-  export let getOptionValue: (option: O) => V = option => option as unknown as V
+  export let getOptionLabel = (option: O) => `${option}`
+  export let getOptionValue = (option: O) => option as unknown as V
 
   const dispatch = createEventDispatcher<{ change: V[] }>()
 
@@ -25,6 +30,8 @@
   }
 </script>
 
+import context from "src/context"
+
 <div class={`spectrum-FieldGroup spectrum-FieldGroup--${direction}`}>
   {#if options && Array.isArray(options)}
     {#each options as option}
diff --git a/packages/bbui/src/Form/Core/Combobox.svelte b/packages/bbui/src/Form/Core/Combobox.svelte
index 473c053896..e2e2792f54 100644
--- a/packages/bbui/src/Form/Core/Combobox.svelte
+++ b/packages/bbui/src/Form/Core/Combobox.svelte
@@ -1,3 +1,7 @@
+<script lang="ts" context="module">
+  type O = any
+</script>
+
 <script lang="ts" generics="O">
   import type { ChangeEventHandler } from "svelte/elements"
 
@@ -14,8 +18,8 @@
   export let disabled = false
   export let readonly = false
   export let options: O[] = []
-  export let getOptionLabel: (option: O) => string = option => `${option}`
-  export let getOptionValue: (option: O) => string = option => `${option}`
+  export let getOptionLabel = (option: O) => `${option}`
+  export let getOptionValue = (option: O) => `${option}`
 
   const dispatch = createEventDispatcher<{
     change: string
diff --git a/packages/bbui/src/Popover/Popover.svelte b/packages/bbui/src/Popover/Popover.svelte
index 96305e45d7..5b7c6ab854 100644
--- a/packages/bbui/src/Popover/Popover.svelte
+++ b/packages/bbui/src/Popover/Popover.svelte
@@ -3,7 +3,9 @@
   // @ts-expect-error no types for the version of svelte-portal we're on.
   import Portal from "svelte-portal"
   import { createEventDispatcher, getContext, onDestroy } from "svelte"
-  import positionDropdown, { Styles } from "../Actions/position_dropdown"
+  import positionDropdown, {
+    type UpdateHandler,
+  } from "../Actions/position_dropdown"
   import clickOutside from "../Actions/click_outside"
   import { fly } from "svelte/transition"
   import Context from "../context"
@@ -25,13 +27,7 @@
   export let customHeight: string | undefined = undefined
   export let animate = true
   export let customZindex: string | undefined = undefined
-  export let handlePostionUpdate:
-    | ((
-        anchorBounds: DOMRect,
-        elementBounds: DOMRect,
-        styles: Styles
-      ) => Styles)
-    | undefined = undefined
+  export let handlePostionUpdate: UpdateHandler | undefined = undefined
   export let showPopover = true
   export let clickOutsideOverride = false
   export let resizable = true