From 8882801315533dd3667c0e585ab8f80008995230 Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Mon, 26 Jun 2023 17:01:50 +0100 Subject: [PATCH] Fixing lookup of custom role by ID in test case. --- packages/worker/src/api/routes/global/tests/roles.spec.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/worker/src/api/routes/global/tests/roles.spec.ts b/packages/worker/src/api/routes/global/tests/roles.spec.ts index 477ccaf94c..3fae020aef 100644 --- a/packages/worker/src/api/routes/global/tests/roles.spec.ts +++ b/packages/worker/src/api/routes/global/tests/roles.spec.ts @@ -19,6 +19,7 @@ jest.mock("@budibase/backend-core", () => { let appId: string let appDb: Database +const ROLE_NAME = "newRole" async function addAppMetadata() { await appDb.put({ @@ -34,7 +35,7 @@ describe("/api/global/roles", () => { const config = new TestConfiguration() const role = new roles.Role( - db.generateRoleID("newRole"), + db.generateRoleID(ROLE_NAME), roles.BUILTIN_ROLE_IDS.BASIC, permissions.BuiltinPermissionID.READ_ONLY ) @@ -66,7 +67,7 @@ describe("/api/global/roles", () => { const res = await config.api.roles.get() expect(res.body).toBeDefined() expect(res.body[appId].roles.length).toEqual(5) - expect(res.body[appId].roles.map((r: any) => r._id)).toContain(role._id) + expect(res.body[appId].roles.map((r: any) => r._id)).toContain(ROLE_NAME) }) })