Remove TODOs.
This commit is contained in:
parent
0b8c829ed1
commit
89e64d18a5
|
@ -287,7 +287,6 @@ class GoogleSheetsIntegration implements DatasourcePlus {
|
|||
): Promise<Schema> {
|
||||
// not fully configured yet
|
||||
if (!this.config.auth) {
|
||||
// TODO(samwho): is this the correct behaviour?
|
||||
return { tables: {}, errors: {} }
|
||||
}
|
||||
await this.connect()
|
||||
|
|
|
@ -305,7 +305,7 @@ export function finaliseExternalTables(
|
|||
for (let [name, table] of Object.entries(tables)) {
|
||||
finalTables[name] = copyExistingPropsOver(name, table, entities, tableIds)
|
||||
}
|
||||
// sort the tables by name (TODO(samwho): why?)
|
||||
// sort the tables by name, this is for the UI to display them in alphabetical order
|
||||
return Object.entries(finalTables)
|
||||
.sort(([a], [b]) => a.localeCompare(b))
|
||||
.reduce((r, [k, v]) => ({ ...r, [k]: v }), {})
|
||||
|
|
Loading…
Reference in New Issue