MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove TODOs.

This commit is contained in:
Sam Rose 2023-10-13 16:11:56 +01:00
parent 0b8c829ed1
commit 89e64d18a5
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/server/src/integrations/googlesheets.ts
View File

@ -287,7 +287,6 @@ class GoogleSheetsIntegration implements DatasourcePlus {
): Promise<Schema> { ): Promise<Schema> {
// not fully configured yet // not fully configured yet
if (!this.config.auth) { if (!this.config.auth) {
// TODO(samwho): is this the correct behaviour?
return { tables: {}, errors: {} } return { tables: {}, errors: {} }
} }
await this.connect() await this.connect()

2
packages/server/src/integrations/utils.ts
View File

@ -305,7 +305,7 @@ export function finaliseExternalTables(
for (let [name, table] of Object.entries(tables)) { for (let [name, table] of Object.entries(tables)) {
finalTables[name] = copyExistingPropsOver(name, table, entities, tableIds) finalTables[name] = copyExistingPropsOver(name, table, entities, tableIds)
} }
// sort the tables by name (TODO(samwho): why?) // sort the tables by name, this is for the UI to display them in alphabetical order
return Object.entries(finalTables) return Object.entries(finalTables)
.sort(([a], [b]) => a.localeCompare(b)) .sort(([a], [b]) => a.localeCompare(b))
.reduce((r, [k, v]) => ({ ...r, [k]: v }), {}) .reduce((r, [k, v]) => ({ ...r, [k]: v }), {})