Improve view calculation config

This commit is contained in:
Andrew Kingston 2024-10-11 09:27:04 +01:00
parent 88b2f423f7
commit 8be7f82ccb
No known key found for this signature in database
2 changed files with 19 additions and 29 deletions

View File

@ -121,7 +121,7 @@
}
const addCalc = () => {
calculations = [...calculations, {}]
calculations = [...calculations, { type: CalculationType.AVG }]
}
const deleteCalc = idx => {
@ -188,20 +188,14 @@
size="M"
onConfirm={save}
>
{#if !calculations.length}
<div>
<ActionButton quiet icon="Add" on:click={addCalc}>
Add your first calculation
</ActionButton>
</div>
{:else}
{#if calculations.length}
<div class="calculations">
{#each calculations as calc, idx}
<span>{idx === 0 ? "Calculate" : "and"} the</span>
<Select
options={getTypeOptions(calc, calculations)}
bind:value={calc.type}
placeholder="Function"
placeholder={false}
/>
<span>of</span>
<Select
@ -211,7 +205,7 @@
/>
<Icon
hoverable
name="Close"
name="Delete"
size="S"
on:click={() => deleteCalc(idx)}
color="var(--spectrum-global-color-gray-700)"
@ -226,22 +220,22 @@
/>
</div>
</div>
<div class="buttons">
<ActionButton
quiet
icon="Add"
on:click={addCalc}
disabled={calculations.length >= 5}
>
Add calculation
</ActionButton>
</div>
<InfoDisplay
icon="Help"
quiet
body="Calculations only work with numeric columns and a maximum of 5 calculations can be added at once."
/>
{/if}
<div class="buttons">
<ActionButton
quiet
icon="Add"
on:click={addCalc}
disabled={calculations.length >= 5}
>
Add calculation
</ActionButton>
</div>
<InfoDisplay
icon="Help"
quiet
body="Calculations only work with numeric columns and a maximum of 5 calculations can be added at once."
/>
</ModalContent>
</Modal>

View File

@ -14,10 +14,6 @@ export function canBeDisplayColumn(column) {
}
export function canBeSortColumn(column) {
if (!sharedCore.canBeSortColumn(column.type)) {
return false
}
if (column.related) {
// If it's a related column (only available in the frontend), don't allow using it as display column
return false