Review comments.
This commit is contained in:
parent
223b5a0e16
commit
8d02fabb35
|
@ -38,12 +38,16 @@ exports.updateRelatedFormula = async (appId, table, enrichedRows) => {
|
|||
}
|
||||
}
|
||||
for (let tableId of table.relatedFormula) {
|
||||
let relatedTable
|
||||
try {
|
||||
// no rows to update, skip
|
||||
if (!relatedRows[tableId] || relatedRows[tableId].length === 0) {
|
||||
continue
|
||||
}
|
||||
const relatedTable = await db.get(tableId)
|
||||
relatedTable = await db.get(tableId)
|
||||
} catch (err) {
|
||||
// no error scenario, table doesn't seem to exist anymore, ignore
|
||||
}
|
||||
for (let column of Object.values(relatedTable.schema)) {
|
||||
// needs updated in related rows
|
||||
if (
|
||||
|
@ -60,9 +64,6 @@ exports.updateRelatedFormula = async (appId, table, enrichedRows) => {
|
|||
)
|
||||
}
|
||||
}
|
||||
} catch (err) {
|
||||
// no error scenario, table doesn't seem to exist anymore, ignore
|
||||
}
|
||||
}
|
||||
}
|
||||
await Promise.all(promises)
|
||||
|
|
|
@ -37,7 +37,6 @@ function getFormulaThatUseColumn(table, columnNames) {
|
|||
* This functions checks for when a related table, column or related column is deleted, if any
|
||||
* tables need to have the formula column removed.
|
||||
*/
|
||||
|
||||
async function checkIfFormulaNeedsCleared(
|
||||
appId,
|
||||
table,
|
||||
|
|
Loading…
Reference in New Issue