Added error messages to inputs instead
This commit is contained in:
parent
dfa46651b6
commit
8e19469509
|
@ -6,7 +6,8 @@
|
|||
|
||||
export let title
|
||||
export let fillWidth
|
||||
export let visible = false
|
||||
|
||||
let visible = false
|
||||
|
||||
export function show() {
|
||||
if (visible) {
|
||||
|
|
|
@ -41,12 +41,14 @@
|
|||
bind:value={option.label}
|
||||
label="Label"
|
||||
labelPosition="left"
|
||||
error={option.error?.label}
|
||||
/>
|
||||
<Input
|
||||
placeholder="Value"
|
||||
bind:value={option.value}
|
||||
label="Value"
|
||||
labelPosition="left"
|
||||
error={option.error?.value}
|
||||
/>
|
||||
<Icon
|
||||
name="Close"
|
||||
|
|
|
@ -7,55 +7,60 @@
|
|||
|
||||
export let value
|
||||
|
||||
let drawerVisible = false
|
||||
let drawer
|
||||
let valid = true
|
||||
let tempValue = value || []
|
||||
|
||||
const saveFilter = async () => {
|
||||
// Filter out incomplete options, but if all are incomplete then show error
|
||||
let filteredOptions = tempValue.filter(
|
||||
option => option.value && option.label
|
||||
)
|
||||
if (filteredOptions.length > 0 || tempValue.length === 0) {
|
||||
tempValue = filteredOptions
|
||||
valid = true
|
||||
dispatch("change", tempValue)
|
||||
let hasError = false
|
||||
for (let i = 0; i < tempValue.length; i++) {
|
||||
let option = tempValue[i]
|
||||
if (!(option.label && option.value)) {
|
||||
option.error = {
|
||||
label: option.label ? undefined : "You must provide a label.",
|
||||
value: option.value ? undefined : "You must provide a value.",
|
||||
}
|
||||
tempValue[i] = option
|
||||
hasError = true
|
||||
}
|
||||
}
|
||||
if (!hasError) {
|
||||
drawer.hide()
|
||||
} else {
|
||||
valid = false
|
||||
}
|
||||
dispatch("change", tempValue)
|
||||
}
|
||||
|
||||
const clearOptionErrors = () => {
|
||||
for (let i = 0; i < tempValue.length; i++) {
|
||||
let option = tempValue[i]
|
||||
option.error = undefined
|
||||
tempValue[i] = option
|
||||
}
|
||||
}
|
||||
|
||||
//If the drawer is hidden or error corrected, reset the validation
|
||||
$: {
|
||||
if (
|
||||
!drawerVisible ||
|
||||
tempValue.some(option => option.label && option.value)
|
||||
) {
|
||||
valid = true
|
||||
for (let i = 0; i < tempValue.length; i++) {
|
||||
let option = tempValue[i]
|
||||
if (option.error?.label && option.label) {
|
||||
option.error.label = undefined
|
||||
}
|
||||
if (option.error?.value && option.value) {
|
||||
option.error.value = undefined
|
||||
}
|
||||
tempValue[i] = option
|
||||
}
|
||||
}
|
||||
</script>
|
||||
|
||||
<ActionButton on:click={drawer.show}>Define Options</ActionButton>
|
||||
<Drawer bind:this={drawer} bind:visible={drawerVisible} title="Options">
|
||||
<ActionButton
|
||||
on:click={() => {
|
||||
clearOptionErrors()
|
||||
drawer.show()
|
||||
}}>Define Options</ActionButton
|
||||
>
|
||||
<Drawer bind:this={drawer} title="Options">
|
||||
<svelte:fragment slot="description">
|
||||
{#if !valid}
|
||||
<span class="syntax-error"
|
||||
>You must provide option labels and values.</span
|
||||
>
|
||||
{:else}
|
||||
Define the options for this picker.
|
||||
{/if}
|
||||
</svelte:fragment>
|
||||
<Button cta slot="buttons" on:click={saveFilter}>Save</Button>
|
||||
<OptionsDrawer bind:options={tempValue} slot="body" />
|
||||
</Drawer>
|
||||
|
||||
<style>
|
||||
.syntax-error {
|
||||
padding-top: var(--spacing-m);
|
||||
color: var(--red);
|
||||
}
|
||||
</style>
|
||||
|
|
Loading…
Reference in New Issue