Handle webhook errors (#9715)

packages/server/src/automations/steps/discord.ts

@@ -67,7 +67,16 @@ export async function run({ inputs }: AutomationStepInput) {
   if (!avatar_url) {
     avatar_url = DEFAULT_AVATAR_URL
   }
-  const response = await fetch(url, {
+  if (!url?.trim()?.length) {
+    return {
+      httpStatus: 400,
+      response: "Missing Webhook URL",
+      success: false,
+    }
+  }
+  let response
+  try {
+    response = await fetch(url, {
       method: "post",
       body: JSON.stringify({
         username,
@@ -78,6 +87,13 @@ export async function run({ inputs }: AutomationStepInput) {
         "Content-Type": "application/json",
       },
     })
+  } catch (err: any) {
+    return {
+      httpStatus: 400,
+      response: err.message,
+      success: false,
+    }
+  }
 
   const { status, message } = await getFetchResponse(response)
   return {

packages/server/src/automations/steps/integromat.ts

@@ -69,7 +69,16 @@ export const definition: AutomationStepSchema = {
 export async function run({ inputs }: AutomationStepInput) {
   const { url, value1, value2, value3, value4, value5 } = inputs
 
-  const response = await fetch(url, {
+  if (!url?.trim()?.length) {
+    return {
+      httpStatus: 400,
+      response: "Missing Webhook URL",
+      success: false,
+    }
+  }
+  let response
+  try {
+    response = await fetch(url, {
       method: "post",
       body: JSON.stringify({
         value1,
@@ -82,6 +91,13 @@ export async function run({ inputs }: AutomationStepInput) {
         "Content-Type": "application/json",
       },
     })
+  } catch (err: any) {
+    return {
+      httpStatus: 400,
+      response: err.message,
+      success: false,
+    }
+  }
 
   const { status, message } = await getFetchResponse(response)
   return {

packages/server/src/automations/steps/slack.ts

@@ -50,7 +50,16 @@ export const definition: AutomationStepSchema = {
 
 export async function run({ inputs }: AutomationStepInput) {
   let { url, text } = inputs
-  const response = await fetch(url, {
+  if (!url?.trim()?.length) {
+    return {
+      httpStatus: 400,
+      response: "Missing Webhook URL",
+      success: false,
+    }
+  }
+  let response
+  try {
+    response = await fetch(url, {
       method: "post",
       body: JSON.stringify({
         text,
@@ -59,6 +68,13 @@ export async function run({ inputs }: AutomationStepInput) {
         "Content-Type": "application/json",
       },
     })
+  } catch (err: any) {
+    return {
+      httpStatus: 400,
+      response: err.message,
+      success: false,
+    }
+  }
 
   const { status, message } = await getFetchResponse(response)
   return {

packages/server/src/automations/steps/zapier.ts

@@ -63,9 +63,18 @@ export const definition: AutomationStepSchema = {
 export async function run({ inputs }: AutomationStepInput) {
   const { url, value1, value2, value3, value4, value5 } = inputs
 
+  if (!url?.trim()?.length) {
+    return {
+      httpStatus: 400,
+      response: "Missing Webhook URL",
+      success: false,
+    }
+  }
   // send the platform to make sure zaps always work, even
   // if no values supplied
-  const response = await fetch(url, {
+  let response
+  try {
+    response = await fetch(url, {
       method: "post",
       body: JSON.stringify({
         platform: "budibase",
@@ -79,6 +88,13 @@ export async function run({ inputs }: AutomationStepInput) {
         "Content-Type": "application/json",
       },
     })
+  } catch (err: any) {
+    return {
+      httpStatus: 400,
+      response: err.message,
+      success: false,
+    }
+  }
 
   const { status, message } = await getFetchResponse(response)