MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary searching through large rows array

This commit is contained in:
Andrew Kingston 2023-03-08 10:15:46 +00:00
parent dfce198fe5
commit 9020060f17
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/frontend-core/src/components/sheet/stores/rows.js
View File

@ -135,7 +135,8 @@ export const createRowsStore = context => {
// Get index of row to check if it exists // Get index of row to check if it exists
const $rows = get(rows) const $rows = get(rows)
const index = $rows.findIndex(row => row._id === id) const $rowLookupMap = get(rowLookupMap)
const index = $rowLookupMap[id]
// Process as either an update, addition or deletion // Process as either an update, addition or deletion
if (newRow) { if (newRow) {
@ -167,7 +168,8 @@ export const createRowsStore = context => {
// Updates a value of a row // Updates a value of a row
const updateRow = async (rowId, column, value) => { const updateRow = async (rowId, column, value) => {
const $rows = get(rows) const $rows = get(rows)
const index = $rows.findIndex(x => x._id === rowId) const $rowLookupMap = get(rowLookupMap)
const index = $rowLookupMap[rowId]
const row = $rows[index] const row = $rows[index]
if (index === -1 || row?.[column] === value) { if (index === -1 || row?.[column] === value) {
return return