From 9e2915ff0fc0a7279b95b1b05f9dd8e8baec1cbc Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Fri, 10 Jan 2025 16:24:55 +0100 Subject: [PATCH 1/3] Fix wrong conversion --- packages/frontend-core/src/fetch/UserFetch.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/frontend-core/src/fetch/UserFetch.ts b/packages/frontend-core/src/fetch/UserFetch.ts index 656cd840fe..58aa4f5a96 100644 --- a/packages/frontend-core/src/fetch/UserFetch.ts +++ b/packages/frontend-core/src/fetch/UserFetch.ts @@ -52,7 +52,7 @@ export default class UserFetch extends DataFetch< const finalQuery: SearchFilters = utils.isSupportedUserSearch(rest) ? rest - : { [BasicOperator.EMPTY]: { email: null } } + : { [BasicOperator.STRING]: { email: null as any } } try { const opts: SearchUsersRequest = { From e7400f982cc6bab2bada801e94a76b167332b84e Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Fri, 10 Jan 2025 16:29:42 +0100 Subject: [PATCH 2/3] Add comment --- packages/frontend-core/src/fetch/UserFetch.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/frontend-core/src/fetch/UserFetch.ts b/packages/frontend-core/src/fetch/UserFetch.ts index e8e7dc8721..1fe9c0a383 100644 --- a/packages/frontend-core/src/fetch/UserFetch.ts +++ b/packages/frontend-core/src/fetch/UserFetch.ts @@ -56,7 +56,7 @@ export default class UserFetch extends DataFetch< const finalQuery: SearchFilters = utils.isSupportedUserSearch(rest) ? rest - : { [BasicOperator.STRING]: { email: null as any } } + : { [BasicOperator.STRING]: { email: null as any } } // TODO: chech. Left as any to not change the behaviour it had when it was js try { const opts: SearchUsersRequest = { From 337339d6e5366b36d437dc384f29963506cee6df Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Fri, 10 Jan 2025 16:39:55 +0100 Subject: [PATCH 3/3] Remove confusing empty filter --- packages/frontend-core/src/fetch/UserFetch.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/frontend-core/src/fetch/UserFetch.ts b/packages/frontend-core/src/fetch/UserFetch.ts index 1fe9c0a383..36aebac506 100644 --- a/packages/frontend-core/src/fetch/UserFetch.ts +++ b/packages/frontend-core/src/fetch/UserFetch.ts @@ -2,11 +2,7 @@ import { get } from "svelte/store" import DataFetch, { DataFetchParams } from "./DataFetch" import { TableNames } from "../constants" import { utils } from "@budibase/shared-core" -import { - BasicOperator, - SearchFilters, - SearchUsersRequest, -} from "@budibase/types" +import { SearchFilters, SearchUsersRequest } from "@budibase/types" interface UserFetchQuery { appId: string @@ -56,7 +52,7 @@ export default class UserFetch extends DataFetch< const finalQuery: SearchFilters = utils.isSupportedUserSearch(rest) ? rest - : { [BasicOperator.STRING]: { email: null as any } } // TODO: chech. Left as any to not change the behaviour it had when it was js + : {} try { const opts: SearchUsersRequest = {