MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rename LOG_4XX to ENABLE_4XX_HTTP_LOGGING and enable by default

This commit is contained in:
Rory Powell 2023-02-13 14:39:24 +00:00
parent c78b21ef5f
commit 91e63c8ec4
5 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/backend-core/src/environment.ts
View File

@ -83,7 +83,7 @@ const environment = {
SESSION_UPDATE_PERIOD: process.env.SESSION_UPDATE_PERIOD, SESSION_UPDATE_PERIOD: process.env.SESSION_UPDATE_PERIOD,
DEPLOYMENT_ENVIRONMENT: DEPLOYMENT_ENVIRONMENT:
process.env.DEPLOYMENT_ENVIRONMENT || "docker-compose", process.env.DEPLOYMENT_ENVIRONMENT || "docker-compose",
LOG_4XX: process.env.LOG_4XX, ENABLE_4XX_HTTP_LOGGING: process.env.ENABLE_4XX_HTTP_LOGGING || true,
_set(key: any, value: any) { _set(key: any, value: any) {
process.env[key] = value process.env[key] = value
// @ts-ignore // @ts-ignore

2
packages/backend-core/src/middleware/errorHandling.ts
View File

@ -9,7 +9,7 @@ export async function errorHandling(ctx: any, next: any) {
const status = err.status || err.statusCode || 500 const status = err.status || err.statusCode || 500
ctx.status = status ctx.status = status
if (status > 499 || env.LOG_4XX) { if (status > 499 || env.ENABLE_4XX_HTTP_LOGGING) {
ctx.log.error(err) ctx.log.error(err)
} }

1
packages/backend-core/tests/jestEnv.ts
View File

@ -3,3 +3,4 @@ process.env.MULTI_TENANCY = "1"
process.env.NODE_ENV = "jest" process.env.NODE_ENV = "jest"
process.env.MOCK_REDIS = "1" process.env.MOCK_REDIS = "1"
process.env.LOG_LEVEL = process.env.LOG_LEVEL || "error" process.env.LOG_LEVEL = process.env.LOG_LEVEL || "error"
process.env.ENABLE_4XX_HTTP_LOGGING = "0"

1
packages/server/src/tests/jestEnv.ts
View File

@ -6,4 +6,5 @@ process.env.MULTI_TENANCY = "1"
// @ts-ignore // @ts-ignore
process.env.BUDIBASE_DIR = tmpdir("budibase-unittests") process.env.BUDIBASE_DIR = tmpdir("budibase-unittests")
process.env.LOG_LEVEL = process.env.LOG_LEVEL || "error" process.env.LOG_LEVEL = process.env.LOG_LEVEL || "error"
process.env.ENABLE_4XX_HTTP_LOGGING = "0"
process.env.MOCK_REDIS = "1" process.env.MOCK_REDIS = "1"

1
packages/worker/src/tests/jestEnv.ts
View File

@ -2,6 +2,7 @@ process.env.SELF_HOSTED = "0"
process.env.NODE_ENV = "jest" process.env.NODE_ENV = "jest"
process.env.JWT_SECRET = "test-jwtsecret" process.env.JWT_SECRET = "test-jwtsecret"
process.env.LOG_LEVEL = process.env.LOG_LEVEL || "error" process.env.LOG_LEVEL = process.env.LOG_LEVEL || "error"
process.env.ENABLE_4XX_HTTP_LOGGING = "0"
process.env.MULTI_TENANCY = "1" process.env.MULTI_TENANCY = "1"
process.env.MINIO_URL = "http://localhost" process.env.MINIO_URL = "http://localhost"
process.env.MINIO_ACCESS_KEY = "test" process.env.MINIO_ACCESS_KEY = "test"