MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

prevent empty snippets being saved, don't crash for old empty snippets

This commit is contained in:
Martin McKeaveney 2024-12-03 18:55:06 +00:00
parent 5f28689800
commit 92e5667b81
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/builder/src/components/common/bindings/SnippetDrawer.svelte
View File

@ -63,7 +63,7 @@
if (!name?.length) { if (!name?.length) {
return "Name is required" return "Name is required"
} }
if (snippets.some(snippet => snippet.name === name)) { if (!snippet?.name && snippets.some(snippet => snippet.name === name)) {
return "That name is already in use" return "That name is already in use"
} }
if (firstCharNumberRegex.test(name)) { if (firstCharNumberRegex.test(name)) {
@ -106,11 +106,7 @@
Delete Delete
</Button> </Button>
{/if} {/if}
<Button <Button cta on:click={saveSnippet} disabled={!code || loading || nameError}>
cta
on:click={saveSnippet}
disabled={!snippet && (loading || nameError)}
>
Save Save
</Button> </Button>
</svelte:fragment> </svelte:fragment>

2
packages/builder/src/components/common/bindings/SnippetSidePanel.svelte
View File

@ -186,7 +186,7 @@
<div class="snippet-popover"> <div class="snippet-popover">
{#key hoveredSnippet} {#key hoveredSnippet}
<CodeEditor <CodeEditor
value={hoveredSnippet.code.trim()} value={hoveredSnippet.code?.trim()}
mode={EditorModes.JS} mode={EditorModes.JS}
readonly readonly
/> />