MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add function to close side panel based on the browser's history. (#13944) 

* Add function to close side panel based on the browser's history.

* Switched to hashchange, removed from SidePanel, added to ClientApp.svelte

* Removed unused onMount, fixed lint issue

* Removed unnecessary if statement.
This commit is contained in:
Conor Webb 2024-06-17 08:21:26 +01:00 committed by GitHub
parent c6a7bf6ed1
commit 92f9501d26
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/client/src/components/ClientApp.svelte
View File

@ -19,6 +19,7 @@
devToolsStore, devToolsStore,
devToolsEnabled, devToolsEnabled,
environmentStore, environmentStore,
sidePanelStore,
} from "stores" } from "stores"
import NotificationDisplay from "components/overlay/NotificationDisplay.svelte" import NotificationDisplay from "components/overlay/NotificationDisplay.svelte"
import ConfirmationDisplay from "components/overlay/ConfirmationDisplay.svelte" import ConfirmationDisplay from "components/overlay/ConfirmationDisplay.svelte"
@ -102,6 +103,16 @@
embedded: !!$appStore.embedded, embedded: !!$appStore.embedded,
}) })
} }
const handleHashChange = () => {
const { open } = $sidePanelStore
if (open) {
sidePanelStore.actions.close()
}
}
window.addEventListener("hashchange", handleHashChange)
return () => {
window.removeEventListener("hashchange", handleHashChange)
}
}) })
$: { $: {

4
packages/client/src/components/app/SidePanel.svelte
View File

@ -29,10 +29,6 @@
} }
} }
// $: {
// }
// Derive visibility // Derive visibility
$: open = $sidePanelStore.contentId === $component.id $: open = $sidePanelStore.contentId === $component.id