From 949c6b8653b61a0a18038e39da61b8730597dccf Mon Sep 17 00:00:00 2001
From: mike12345567 <me@michaeldrury.co.uk>
Date: Thu, 28 Oct 2021 22:44:31 +0100
Subject: [PATCH] Adding SQL relationship building.

---
 .../DataTable/modals/CreateEditColumn.svelte  |  6 ++-
 .../src/api/controllers/table/external.js     | 41 ++++++++++++++-----
 2 files changed, 35 insertions(+), 12 deletions(-)

diff --git a/packages/builder/src/components/backend/DataTable/modals/CreateEditColumn.svelte b/packages/builder/src/components/backend/DataTable/modals/CreateEditColumn.svelte
index 221d391cbf..54bbb7fadf 100644
--- a/packages/builder/src/components/backend/DataTable/modals/CreateEditColumn.svelte
+++ b/packages/builder/src/components/backend/DataTable/modals/CreateEditColumn.svelte
@@ -89,6 +89,10 @@
     if (field.type === AUTO_TYPE) {
       field = buildAutoColumn($tables.draft.name, field.name, field.subtype)
     }
+    // for now you can't create other options, just many to many for SQL
+    if (field.type === LINK_TYPE && external) {
+      field.relationshipType = RelationshipTypes.ONE_TO_MANY
+    }
     await tables.saveField({
       originalName,
       field,
@@ -324,7 +328,7 @@
       getOptionLabel={table => table.name}
       getOptionValue={table => table._id}
     />
-    {#if relationshipOptions && relationshipOptions.length > 0}
+    {#if relationshipOptions && relationshipOptions.length > 0 && !external}
       <RadioGroup
         disabled={linkEditDisabled}
         label="Define the relationship"
diff --git a/packages/server/src/api/controllers/table/external.js b/packages/server/src/api/controllers/table/external.js
index 42454fd2e8..5fe923cb96 100644
--- a/packages/server/src/api/controllers/table/external.js
+++ b/packages/server/src/api/controllers/table/external.js
@@ -4,7 +4,11 @@ const {
   breakExternalTableId,
 } = require("../../../integrations/utils")
 const { getTable } = require("./utils")
-const { DataSourceOperation, FieldTypes } = require("../../../constants")
+const {
+  DataSourceOperation,
+  FieldTypes,
+  RelationshipTypes,
+} = require("../../../constants")
 const { makeExternalQuery } = require("../../../integrations/base/utils")
 const { cloneDeep } = require("lodash/fp")
 
@@ -42,6 +46,17 @@ function getDatasourceId(table) {
   return breakExternalTableId(table._id).datasourceId
 }
 
+function generateRelatedSchema(linkColumn, table) {
+  // generate column for other table
+  const relatedSchema = cloneDeep(linkColumn)
+  relatedSchema.fieldName = linkColumn.foreignKey
+  relatedSchema.foreignKey = linkColumn.fieldName
+  relatedSchema.relationshipType = RelationshipTypes.MANY_TO_ONE
+  relatedSchema.tableId = table._id
+  delete relatedSchema.main
+  return relatedSchema
+}
+
 exports.save = async function (ctx) {
   const appId = ctx.appId
   const table = ctx.request.body
@@ -64,24 +79,28 @@ exports.save = async function (ctx) {
   const tables = datasource.entities
 
   // check if relations need setup
-  for (let [key, schema] of Object.entries(tableToSave.schema)) {
-    // TODO: this assumes all relationships are the same, need to handle cardinality and many to many
+  for (let schema of Object.values(tableToSave.schema)) {
+    // TODO: many to many handling
     if (schema.type === FieldTypes.LINK) {
       const relatedTable = Object.values(tables).find(
         table => table._id === schema.tableId
       )
+      // setup the schema in this table
       const relatedField = schema.fieldName
+      const relatedPrimary = relatedTable.primary[0]
+      // generate a foreign key
       const foreignKey = `fk_${relatedTable.name}_${schema.fieldName}`
-      // create foreign key
-      tableToSave.schema[foreignKey] = { type: FieldTypes.NUMBER }
-      // setup the relation in other table and this one
+
+      schema.relationshipType = RelationshipTypes.ONE_TO_MANY
       schema.foreignKey = foreignKey
-      schema.fieldName = foreignKey
+      schema.fieldName = relatedPrimary
       schema.main = true
-      const relatedSchema = cloneDeep(schema)
-      relatedSchema.fieldName = key
-      delete relatedSchema.main
-      relatedTable.schema[relatedField] = relatedSchema
+
+      relatedTable.schema[relatedField] = generateRelatedSchema(schema, table)
+      tableToSave.schema[foreignKey] = {
+        type: FieldTypes.NUMBER,
+        constraints: {},
+      }
     }
   }