From 97e63d9e28cbb1c8fde9d5750ed472dd174140e0 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Tue, 28 May 2024 12:53:57 +0200 Subject: [PATCH 01/16] Rename --- .../{HideColumnsButton.svelte => ColumnsSettingButton.svelte} | 0 packages/frontend-core/src/components/grid/layout/Grid.svelte | 4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-) rename packages/frontend-core/src/components/grid/controls/{HideColumnsButton.svelte => ColumnsSettingButton.svelte} (100%) diff --git a/packages/frontend-core/src/components/grid/controls/HideColumnsButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte similarity index 100% rename from packages/frontend-core/src/components/grid/controls/HideColumnsButton.svelte rename to packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte diff --git a/packages/frontend-core/src/components/grid/layout/Grid.svelte b/packages/frontend-core/src/components/grid/layout/Grid.svelte index 4fb3747bfd..0628e8232e 100644 --- a/packages/frontend-core/src/components/grid/layout/Grid.svelte +++ b/packages/frontend-core/src/components/grid/layout/Grid.svelte @@ -18,7 +18,7 @@ import UserAvatars from "./UserAvatars.svelte" import KeyboardManager from "../overlays/KeyboardManager.svelte" import SortButton from "../controls/SortButton.svelte" - import HideColumnsButton from "../controls/HideColumnsButton.svelte" + import ColumnsSettingButton from "../controls/ColumnsSettingButton.svelte" import SizeButton from "../controls/SizeButton.svelte" import NewRow from "./NewRow.svelte" import { createGridWebsocket } from "../lib/websocket" @@ -152,7 +152,7 @@
- +
From bc6ead9dee1390e92236aa434fa716e80b26b2bf Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Tue, 28 May 2024 12:56:25 +0200 Subject: [PATCH 02/16] Change icon --- .../src/components/grid/controls/ColumnsSettingButton.svelte | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index 5b74e01958..b9beb154ae 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -29,13 +29,13 @@ const getText = columns => { const hidden = columns.filter(col => !col.visible).length - return hidden ? `Hide columns (${hidden})` : "Hide columns" + return hidden ? `Columns (${hidden})` : "Columns" }
(open = !open)} From be2d63497edb0b572358af3aa83e19ca15c16375 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Tue, 28 May 2024 16:12:35 +0200 Subject: [PATCH 03/16] Remove toggle all --- .../grid/controls/ColumnsSettingButton.svelte | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index b9beb154ae..6efaed5d96 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -17,16 +17,6 @@ dispatch(visible ? "show-column" : "hide-column") } - const toggleAll = async visible => { - let mutations = {} - $columns.forEach(column => { - mutations[column.name] = { visible } - }) - datasource.actions.addSchemaMutations(mutations) - await datasource.actions.saveSchemaMutations() - dispatch(visible ? "show-column" : "hide-column") - } - const getText = columns => { const hidden = columns.filter(col => !col.visible).length return hidden ? `Columns (${hidden})` : "Columns" @@ -69,10 +59,6 @@ /> {/each}
-
- toggleAll(true)}>Show all - toggleAll(false)}>Hide all -
From 62e1ba28b2b0a94d6c23912fca88e20b20823b48 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Tue, 28 May 2024 17:16:38 +0200 Subject: [PATCH 04/16] Add ToggleActionButtonGroup --- .../grid/controls/ColumnsSettingButton.svelte | 37 ++++++++++++++++--- .../controls/ToggleActionButtonGroup.svelte | 25 +++++++++++++ 2 files changed, 56 insertions(+), 6 deletions(-) create mode 100644 packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index 6efaed5d96..2f3b1df405 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -2,6 +2,7 @@ import { getContext } from "svelte" import { ActionButton, Popover, Toggle, Icon } from "@budibase/bbui" import { getColumnIcon } from "../lib/utils" + import ToggleActionButtonGroup from "./ToggleActionButtonGroup.svelte" const { columns, datasource, stickyColumn, dispatch } = getContext("grid") @@ -11,8 +12,11 @@ $: anyHidden = $columns.some(col => !col.visible) $: text = getText($columns) - const toggleColumn = async (column, visible) => { - datasource.actions.addSchemaMutation(column.name, { visible }) + const toggleColumn = async (column, permission) => { + const visible = permission !== PERMISSION_OPTIONS.HIDDEN + const readonly = permission === PERMISSION_OPTIONS.READONLY + + datasource.actions.addSchemaMutation(column.name, { visible, readonly }) await datasource.actions.saveSchemaMutations() dispatch(visible ? "show-column" : "hide-column") } @@ -21,6 +25,24 @@ const hidden = columns.filter(col => !col.visible).length return hidden ? `Columns (${hidden})` : "Columns" } + + const PERMISSION_OPTIONS = { + WRITABLE: "writable", + READONLY: "readonly", + HIDDEN: "hidden", + } + + function columnToPermissionOptions(column) { + if (!column.visible) { + return PERMISSION_OPTIONS.HIDDEN + } + + if (column.readonly) { + return PERMISSION_OPTIONS.READONLY + } + + return PERMISSION_OPTIONS.WRITABLE + }
@@ -51,11 +73,14 @@ {column.label}
- toggleColumn(column, e.detail)} - disabled={column.primaryDisplay} + value={columnToPermissionOptions(column)} + options={[ + { icon: "Edit", value: PERMISSION_OPTIONS.WRITABLE }, + { icon: "Visibility", value: PERMISSION_OPTIONS.READONLY }, + { icon: "VisibilityOff", value: PERMISSION_OPTIONS.HIDDEN }, + ]} /> {/each} diff --git a/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte b/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte new file mode 100644 index 0000000000..647b1af526 --- /dev/null +++ b/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte @@ -0,0 +1,25 @@ + + +
+ {#each options as option} + onClick(option.value)} + size="S" + icon={option.icon} + quiet + selected={option.value === value} + /> + {/each} +
From 4262532cb1cf454c70ccd7fc58eaa1286a3192b2 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Tue, 28 May 2024 17:48:50 +0200 Subject: [PATCH 05/16] Fix noPadding and quiet --- packages/bbui/src/ActionButton/ActionButton.svelte | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/bbui/src/ActionButton/ActionButton.svelte b/packages/bbui/src/ActionButton/ActionButton.svelte index c346e34d54..96969d1435 100644 --- a/packages/bbui/src/ActionButton/ActionButton.svelte +++ b/packages/bbui/src/ActionButton/ActionButton.svelte @@ -109,16 +109,16 @@ background: var(--spectrum-global-color-gray-300); border-color: var(--spectrum-global-color-gray-500); } - .noPadding { - padding: 0; - min-width: 0; - } .spectrum-ActionButton--quiet { padding: 0 8px; } .spectrum-ActionButton--quiet.is-selected { color: var(--spectrum-global-color-gray-900); } + .noPadding { + padding: 0; + min-width: 0; + } .is-selected:not(.emphasized) .spectrum-Icon { color: var(--spectrum-global-color-gray-900); } From a689d82b66aefa64aab5c251d3a9d8c7e46e462e Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Wed, 29 May 2024 15:31:25 +0200 Subject: [PATCH 06/16] Unify components --- .../grid/controls/ColumnsSettingButton.svelte | 27 ++++++++++++------- .../controls/ToggleActionButtonGroup.svelte | 25 ----------------- 2 files changed, 17 insertions(+), 35 deletions(-) delete mode 100644 packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index 2f3b1df405..8fe3854d93 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -2,7 +2,6 @@ import { getContext } from "svelte" import { ActionButton, Popover, Toggle, Icon } from "@budibase/bbui" import { getColumnIcon } from "../lib/utils" - import ToggleActionButtonGroup from "./ToggleActionButtonGroup.svelte" const { columns, datasource, stickyColumn, dispatch } = getContext("grid") @@ -32,6 +31,12 @@ HIDDEN: "hidden", } + const options = [ + { icon: "Edit", value: PERMISSION_OPTIONS.WRITABLE }, + { icon: "Visibility", value: PERMISSION_OPTIONS.READONLY }, + { icon: "VisibilityOff", value: PERMISSION_OPTIONS.HIDDEN }, + ] + function columnToPermissionOptions(column) { if (!column.visible) { return PERMISSION_OPTIONS.HIDDEN @@ -73,15 +78,17 @@ {column.label} - toggleColumn(column, e.detail)} - value={columnToPermissionOptions(column)} - options={[ - { icon: "Edit", value: PERMISSION_OPTIONS.WRITABLE }, - { icon: "Visibility", value: PERMISSION_OPTIONS.READONLY }, - { icon: "VisibilityOff", value: PERMISSION_OPTIONS.HIDDEN }, - ]} - /> +
+ {#each options as option} + toggleColumn(column, option.value)} + size="S" + icon={option.icon} + quiet + selected={option.value === columnToPermissionOptions(column)} + /> + {/each} +
{/each} diff --git a/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte b/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte deleted file mode 100644 index 647b1af526..0000000000 --- a/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte +++ /dev/null @@ -1,25 +0,0 @@ - - -
- {#each options as option} - onClick(option.value)} - size="S" - icon={option.icon} - quiet - selected={option.value === value} - /> - {/each} -
From 151ff27351e9ac0422d47933286f82a4fa1b4533 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Wed, 29 May 2024 15:38:30 +0200 Subject: [PATCH 07/16] Styling --- .../grid/controls/ColumnsSettingButton.svelte | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index 8fe3854d93..2608eea75f 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -78,7 +78,7 @@ {column.label} -
+
{#each options as option} toggleColumn(column, option.value)} @@ -86,6 +86,7 @@ icon={option.icon} quiet selected={option.value === columnToPermissionOptions(column)} + noPadding /> {/each}
@@ -101,11 +102,6 @@ flex-direction: column; gap: 12px; } - .buttons { - display: flex; - flex-direction: row; - gap: 8px; - } .columns { display: grid; align-items: center; @@ -118,4 +114,16 @@ display: flex; gap: 8px; } + .permissionPicker { + display: flex; + gap: var(--spacing-xs); + padding-left: calc(var(--spacing-xl) * 2); + } + + .permissionPicker :global(.spectrum-Icon) { + width: 14px; + } + .permissionPicker :global(.spectrum-ActionButton) { + width: 22px; + } From 06549149b6867acac854751a85aa42c77f64f30f Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Wed, 29 May 2024 16:01:11 +0200 Subject: [PATCH 08/16] Remove readonly --- .../components/grid/controls/ColumnsSettingButton.svelte | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index 2608eea75f..c3ce6d2743 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -13,9 +13,8 @@ const toggleColumn = async (column, permission) => { const visible = permission !== PERMISSION_OPTIONS.HIDDEN - const readonly = permission === PERMISSION_OPTIONS.READONLY - datasource.actions.addSchemaMutation(column.name, { visible, readonly }) + datasource.actions.addSchemaMutation(column.name, { visible }) await datasource.actions.saveSchemaMutations() dispatch(visible ? "show-column" : "hide-column") } @@ -27,13 +26,11 @@ const PERMISSION_OPTIONS = { WRITABLE: "writable", - READONLY: "readonly", HIDDEN: "hidden", } const options = [ { icon: "Edit", value: PERMISSION_OPTIONS.WRITABLE }, - { icon: "Visibility", value: PERMISSION_OPTIONS.READONLY }, { icon: "VisibilityOff", value: PERMISSION_OPTIONS.HIDDEN }, ] @@ -42,10 +39,6 @@ return PERMISSION_OPTIONS.HIDDEN } - if (column.readonly) { - return PERMISSION_OPTIONS.READONLY - } - return PERMISSION_OPTIONS.WRITABLE } From 5b42aff1f750f2ae3c175d147e164b183fd46c8b Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Wed, 29 May 2024 16:21:19 +0200 Subject: [PATCH 09/16] Add picker to sticky columns --- .../bbui/src/ActionButton/ActionButton.svelte | 4 ++++ .../grid/controls/ColumnsSettingButton.svelte | 15 ++++++++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/packages/bbui/src/ActionButton/ActionButton.svelte b/packages/bbui/src/ActionButton/ActionButton.svelte index 96969d1435..d3cec0f307 100644 --- a/packages/bbui/src/ActionButton/ActionButton.svelte +++ b/packages/bbui/src/ActionButton/ActionButton.svelte @@ -57,6 +57,7 @@ class:fullWidth class="spectrum-ActionButton spectrum-ActionButton--size{size}" class:active + class:disabled {disabled} on:longPress on:click|preventDefault @@ -122,6 +123,9 @@ .is-selected:not(.emphasized) .spectrum-Icon { color: var(--spectrum-global-color-gray-900); } + .is-selected.disabled .spectrum-Icon { + color: var(--spectrum-global-color-gray-500); + } .tooltip { position: absolute; pointer-events: none; diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index c3ce6d2743..2f8e141a61 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -64,7 +64,19 @@ {$stickyColumn.label}
- + +
+ {#each options as option} + + {/each} +
{/if} {#each $columns as column}
@@ -99,6 +111,7 @@ display: grid; align-items: center; grid-template-columns: 1fr auto; + gap: 8px; } .columns :global(.spectrum-Switch) { margin-right: 0; From 53968f0725d4b1d9019ebe64e45061b0dd81a79e Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Wed, 29 May 2024 16:22:32 +0200 Subject: [PATCH 10/16] Copy change --- .../src/components/grid/controls/ColumnsSettingButton.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index 2f8e141a61..5d398574c3 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -21,7 +21,7 @@ const getText = columns => { const hidden = columns.filter(col => !col.visible).length - return hidden ? `Columns (${hidden})` : "Columns" + return hidden ? `Columns (${hidden} restricted)` : "Columns" } const PERMISSION_OPTIONS = { From 3d15f71344273796bc13fd68fda52020ba2198d7 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Wed, 29 May 2024 16:50:07 +0200 Subject: [PATCH 11/16] Break down component --- .../grid/controls/ColumnsSettingButton.svelte | 57 ++++++------------- .../controls/ToggleActionButtonGroup.svelte | 41 +++++++++++++ 2 files changed, 59 insertions(+), 39 deletions(-) create mode 100644 packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index 5d398574c3..0a85e41966 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -1,7 +1,8 @@ + +
+ {#each options as option} + dispatch("click", option.value)} + {disabled} + size="S" + icon={option.icon} + quiet + selected={option.value === value} + noPadding + tooltip={option.tooltip} + /> + {/each} +
+ + From 21e5c8ecda3f243718ad8fc9890bdb392f3f2c47 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Wed, 29 May 2024 17:19:07 +0200 Subject: [PATCH 12/16] Overflow tooltip --- packages/bbui/src/Popover/Popover.svelte | 5 +++++ .../src/components/grid/controls/ColumnsSettingButton.svelte | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/bbui/src/Popover/Popover.svelte b/packages/bbui/src/Popover/Popover.svelte index aa811afe1e..05d8af1693 100644 --- a/packages/bbui/src/Popover/Popover.svelte +++ b/packages/bbui/src/Popover/Popover.svelte @@ -27,6 +27,7 @@ export let clickOutsideOverride = false export let resizable = true export let wrap = false + export let overflow = false $: target = portalTarget || getContext(Context.PopoverRoot) || ".spectrum" @@ -104,6 +105,7 @@ class="spectrum-Popover is-open" class:customZindex class:hidden={!showPopover} + class:overflow role="presentation" style="height: {customHeight}; --customZindex: {customZindex};" transition:fly|local={{ y: -20, duration: animate ? 260 : 0 }} @@ -122,6 +124,9 @@ overflow: auto; transition: opacity 260ms ease-out; } + .spectrum-Popover.overflow { + overflow: visible; + } .hidden { opacity: 0; pointer-events: none; diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index 0a85e41966..1c8a8ec6a0 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -31,7 +31,7 @@ } const options = [ - { icon: "Edit", value: PERMISSION_OPTIONS.WRITABLE, tooltip: "Writable" }, + { icon: "Edit", value: PERMISSION_OPTIONS.WRITABLE, tooltip: "Writeable" }, { icon: "VisibilityOff", value: PERMISSION_OPTIONS.HIDDEN, @@ -61,7 +61,7 @@
- +
{#if $stickyColumn} From 8b22beb0a204baa91fd298cb3d23748d61c9759c Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Thu, 30 May 2024 10:07:17 +0200 Subject: [PATCH 13/16] Use AbsTooltip --- .../controls/ToggleActionButtonGroup.svelte | 23 ++++++++++--------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte b/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte index 4c82da9e21..4f83f069d3 100644 --- a/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte +++ b/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte @@ -3,7 +3,7 @@ let dispatch = createEventDispatcher() - import { ActionButton } from "@budibase/bbui" + import { ActionButton, AbsTooltip, TooltipType } from "@budibase/bbui" export let value export let options @@ -12,16 +12,17 @@
{#each options as option} - dispatch("click", option.value)} - {disabled} - size="S" - icon={option.icon} - quiet - selected={option.value === value} - noPadding - tooltip={option.tooltip} - /> + + dispatch("click", option.value)} + {disabled} + size="S" + icon={option.icon} + quiet + selected={option.value === value} + noPadding + /> + {/each}
From a672c0089931e14eda859c00661d338d9791fbeb Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Thu, 30 May 2024 10:07:47 +0200 Subject: [PATCH 14/16] Copy changes --- .../src/components/grid/controls/ColumnsSettingButton.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index 1c8a8ec6a0..7ba746da33 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -31,7 +31,7 @@ } const options = [ - { icon: "Edit", value: PERMISSION_OPTIONS.WRITABLE, tooltip: "Writeable" }, + { icon: "Edit", value: PERMISSION_OPTIONS.WRITABLE, tooltip: "Writable" }, { icon: "VisibilityOff", value: PERMISSION_OPTIONS.HIDDEN, From b5a036509784576e00555f4a6e25479fc3e60863 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Thu, 30 May 2024 10:11:04 +0200 Subject: [PATCH 15/16] Remove new overflow setting --- packages/bbui/src/Popover/Popover.svelte | 5 ----- .../src/components/grid/controls/ColumnsSettingButton.svelte | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/bbui/src/Popover/Popover.svelte b/packages/bbui/src/Popover/Popover.svelte index 05d8af1693..aa811afe1e 100644 --- a/packages/bbui/src/Popover/Popover.svelte +++ b/packages/bbui/src/Popover/Popover.svelte @@ -27,7 +27,6 @@ export let clickOutsideOverride = false export let resizable = true export let wrap = false - export let overflow = false $: target = portalTarget || getContext(Context.PopoverRoot) || ".spectrum" @@ -105,7 +104,6 @@ class="spectrum-Popover is-open" class:customZindex class:hidden={!showPopover} - class:overflow role="presentation" style="height: {customHeight}; --customZindex: {customZindex};" transition:fly|local={{ y: -20, duration: animate ? 260 : 0 }} @@ -124,9 +122,6 @@ overflow: auto; transition: opacity 260ms ease-out; } - .spectrum-Popover.overflow { - overflow: visible; - } .hidden { opacity: 0; pointer-events: none; diff --git a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte index 7ba746da33..0a85e41966 100644 --- a/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte +++ b/packages/frontend-core/src/components/grid/controls/ColumnsSettingButton.svelte @@ -61,7 +61,7 @@
- +
{#if $stickyColumn} From adcda035ed9dc736a68b61f6a0809ff44022e344 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Thu, 30 May 2024 10:11:11 +0200 Subject: [PATCH 16/16] Change size --- .../components/grid/controls/ToggleActionButtonGroup.svelte | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte b/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte index 4f83f069d3..e705b5016d 100644 --- a/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte +++ b/packages/frontend-core/src/components/grid/controls/ToggleActionButtonGroup.svelte @@ -37,6 +37,7 @@ width: 14px; } .permissionPicker :global(.spectrum-ActionButton) { - width: 22px; + width: 28px; + height: 28px; }