From 97375d1a330a4cfd12953097bc96c037a778c262 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Tue, 5 Mar 2024 11:54:39 +0000 Subject: [PATCH] Fallback to binding example syntax for code-mirror popover plugin when no context exists --- .../src/components/common/CodeEditor/CodeEditor.svelte | 4 ++-- packages/builder/src/components/common/CodeEditor/index.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte b/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte index 080476a9b7..88661467be 100644 --- a/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte +++ b/packages/builder/src/components/common/CodeEditor/CodeEditor.svelte @@ -174,7 +174,7 @@ complete.push( autocompletion({ override: [...completions], - closeOnBlur: false, + closeOnBlur: true, icons: false, optionClass: () => "autocomplete-option", }) @@ -462,7 +462,7 @@ overflow: hidden; max-height: 480px; } - .code-editor :global(.binding__example.helper) { + .code-editor :global(.binding__example) { color: var(--spectrum-global-color-blue-700); } .code-editor :global(.binding__example span) { diff --git a/packages/builder/src/components/common/CodeEditor/index.js b/packages/builder/src/components/common/CodeEditor/index.js index 82c8ddf647..bd55c371e6 100644 --- a/packages/builder/src/components/common/CodeEditor/index.js +++ b/packages/builder/src/components/common/CodeEditor/index.js @@ -166,7 +166,7 @@ export const buildBindingInfoNode = (completion, binding) => { const ele = document.createElement("div") ele.classList.add("info-bubble") - if (binding.valueHTML) { + if (binding.value != null && binding.valueHTML) { ele.innerHTML = `
${binding.valueHTML}
` return ele }