From 998f1806aad5ecb9091a8440467411cc0ffb033f Mon Sep 17 00:00:00 2001
From: Dean <deanhannigan@gmail.com>
Date: Tue, 20 Jun 2023 16:29:09 +0100
Subject: [PATCH] Updated analytics tests to account for the embedded

---
 .../backend-core/src/events/publishers/serve.ts |  4 ++--
 .../src/api/routes/tests/analytics.spec.js      | 17 ++++++++++++++++-
 2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/packages/backend-core/src/events/publishers/serve.ts b/packages/backend-core/src/events/publishers/serve.ts
index 5fb0883b0b..ac6a23dfdb 100644
--- a/packages/backend-core/src/events/publishers/serve.ts
+++ b/packages/backend-core/src/events/publishers/serve.ts
@@ -17,12 +17,12 @@ async function servedBuilder(timezone: string) {
 async function servedApp(
   app: App,
   timezone: string,
-  embed: boolean | undefined
+  embed?: boolean | undefined
 ) {
   const properties: AppServedEvent = {
     appVersion: app.version,
     timezone,
-    embed,
+    embed: embed === true,
   }
   await publishEvent(Event.SERVED_APP, properties)
 }
diff --git a/packages/server/src/api/routes/tests/analytics.spec.js b/packages/server/src/api/routes/tests/analytics.spec.js
index ac7cd978c8..5dfe2ce3e6 100644
--- a/packages/server/src/api/routes/tests/analytics.spec.js
+++ b/packages/server/src/api/routes/tests/analytics.spec.js
@@ -55,7 +55,22 @@ describe("/static", () => {
         .expect(200)
 
       expect(events.serve.servedApp).toBeCalledTimes(1)
-      expect(events.serve.servedApp).toBeCalledWith(config.getProdApp(), timezone)
+      expect(events.serve.servedApp).toBeCalledWith(config.getProdApp(), timezone, undefined)
+      expect(events.serve.servedAppPreview).not.toBeCalled()
+    })
+
+    it("should ping from an embedded app", async () => {
+      const headers = config.defaultHeaders()
+      headers[constants.Header.APP_ID] = config.prodAppId
+
+      await request
+        .post("/api/bbtel/ping")
+        .send({source: "app", timezone, embedded: true})
+        .set(headers)
+        .expect(200)
+
+      expect(events.serve.servedApp).toBeCalledTimes(1)
+      expect(events.serve.servedApp).toBeCalledWith(config.getProdApp(), timezone, true)
       expect(events.serve.servedAppPreview).not.toBeCalled()
     })
   })