From 9f92ee2d0b42ac5f778a58505e7c58cffbdceaed Mon Sep 17 00:00:00 2001
From: Andrew Kingston <andrew@kingston.dev>
Date: Fri, 18 Feb 2022 13:08:18 +0000
Subject: [PATCH] Add compact setting to table

---
 .../bbui/src/Table/AttachmentRenderer.svelte  | 15 +++++++----
 packages/bbui/src/Table/Table.svelte          | 27 ++++++++++++++-----
 packages/client/manifest.json                 |  5 ++++
 .../src/components/app/table/Table.svelte     |  2 ++
 4 files changed, 38 insertions(+), 11 deletions(-)

diff --git a/packages/bbui/src/Table/AttachmentRenderer.svelte b/packages/bbui/src/Table/AttachmentRenderer.svelte
index 797ca93695..97ce1394cc 100644
--- a/packages/bbui/src/Table/AttachmentRenderer.svelte
+++ b/packages/bbui/src/Table/AttachmentRenderer.svelte
@@ -17,14 +17,16 @@
 {#each attachments as attachment}
   {#if isImage(attachment.extension)}
     <Link quiet target="_blank" href={attachment.url}>
-      <img src={attachment.url} alt={attachment.extension} />
+      <div class="center">
+        <img src={attachment.url} alt={attachment.extension} />
+      </div>
     </Link>
   {:else}
     <Tooltip text={attachment.name} direction="right">
       <div class="file">
-        <Link quiet target="_blank" href={attachment.url}
-          >{attachment.extension}</Link
-        >
+        <Link quiet target="_blank" href={attachment.url}>
+          {attachment.extension}
+        </Link>
       </div>
     </Tooltip>
   {/if}
@@ -38,12 +40,15 @@
     height: 32px;
     max-width: 64px;
   }
+  .center,
   .file {
-    height: 32px;
     display: flex;
     flex-direction: row;
     justify-content: flex-start;
     align-items: center;
+  }
+  .file {
+    height: 32px;
     padding: 0 8px;
     color: var(--spectrum-global-color-gray-800);
     border: 1px solid var(--spectrum-global-color-gray-300);
diff --git a/packages/bbui/src/Table/Table.svelte b/packages/bbui/src/Table/Table.svelte
index 90e3babdde..c23c226185 100644
--- a/packages/bbui/src/Table/Table.svelte
+++ b/packages/bbui/src/Table/Table.svelte
@@ -29,12 +29,12 @@
   export let customRenderers = []
   export let disableSorting = false
   export let autoSortColumns = true
+  export let compact = false
 
   const dispatch = createEventDispatcher()
-  rowCount = 8
 
   // Config
-  const rowHeight = 55
+  $: rowHeight = compact ? 46 : 55
   const headerHeight = 36
   const rowPreload = 5
 
@@ -238,6 +238,7 @@
 <div
   class="wrapper"
   class:wrapper--quiet={quiet}
+  class:wrapper--compact={compact}
   bind:offsetHeight={height}
   style={`--row-height: ${rowHeight}px; --header-height: ${headerHeight}px;`}
 >
@@ -251,7 +252,7 @@
     >
       {#if fields.length}
         {#if showEditColumn}
-          <div class="spectrum-Table-headCell">
+          <div class="spectrum-Table-headCell spectrum-Table-headCell--divider">
             {editColumnTitle || ""}
           </div>
         {/if}
@@ -306,9 +307,7 @@
           >
             {#if idx >= firstVisibleRow && idx <= lastVisibleRow}
               {#if showEditColumn}
-                <div
-                  class="spectrum-Table-cell spectrum-Table-cell--divider spectrum-Table-cell--edit"
-                >
+                <div class="spectrum-Table-cell spectrum-Table-cell--divider">
                   <SelectEditRenderer
                     data={row}
                     selected={selectedRows.includes(row)}
@@ -363,10 +362,16 @@
     z-index: 0;
     --table-bg: var(--spectrum-global-color-gray-50);
     --table-border: 1px solid var(--spectrum-alias-border-color-mid);
+    --cell-padding: 20px;
   }
   .wrapper--quiet {
     --table-bg: var(--spectrum-alias-background-color-transparent);
   }
+  .wrapper--compact {
+    /*--spectrum-table-header-padding-x: 5px;*/
+    /*--spectrum-table-cell-padding-x: 5px;*/
+    --cell-padding: 12px;
+  }
 
   /* Table */
   .spectrum-Table {
@@ -397,6 +402,11 @@
     background-color: var(--spectrum-alias-background-color-secondary);
     z-index: 2;
     border-bottom: var(--table-border);
+    padding-left: var(--cell-padding);
+    padding-right: 0;
+  }
+  .spectrum-Table-headCell--divider {
+    padding-right: var(--cell-padding);
   }
   .spectrum-Table-headCell-content {
     overflow: hidden;
@@ -469,6 +479,11 @@
     transition: background-color
       var(--spectrum-global-animation-duration-100, 0.13s) ease-in-out;
     border-bottom: 1px solid var(--spectrum-alias-border-color-mid);
+    padding-left: var(--cell-padding);
+    padding-right: 0;
+  }
+  .spectrum-Table-cell--divider {
+    padding-right: var(--cell-padding);
   }
   .spectrum-Table-cell--empty {
     grid-column: 1 / -1;
diff --git a/packages/client/manifest.json b/packages/client/manifest.json
index 1b8d261398..c08c4e17d3 100644
--- a/packages/client/manifest.json
+++ b/packages/client/manifest.json
@@ -2702,6 +2702,11 @@
         "label": "Quiet",
         "key": "quiet"
       },
+      {
+        "type": "boolean",
+        "label": "Compact",
+        "key": "compact"
+      },
       {
         "type": "boolean",
         "label": "Show auto columns",
diff --git a/packages/client/src/components/app/table/Table.svelte b/packages/client/src/components/app/table/Table.svelte
index 43dd8957fe..161d34104a 100644
--- a/packages/client/src/components/app/table/Table.svelte
+++ b/packages/client/src/components/app/table/Table.svelte
@@ -14,6 +14,7 @@
   export let linkURL
   export let linkColumn
   export let linkPeek
+  export let compact
 
   const component = getContext("component")
   const { styleable, getAction, ActionTypes, routeStore } = getContext("sdk")
@@ -122,6 +123,7 @@
     {loading}
     {rowCount}
     {quiet}
+    {compact}
     {customRenderers}
     allowSelectRows={false}
     allowEditRows={false}