MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use 422 instead of 400 trying to delete row action automations

This commit is contained in:
Adria Navarro 2024-07-23 12:21:52 +02:00
parent af0b69e8b6
commit a03094db33
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/server/src/api/controllers/automation.ts
View File

@ -97,7 +97,7 @@ export async function destroy(ctx: UserCtx<void, DeleteAutomationResponse>) {
const automation = await sdk.automations.get(ctx.params.id) const automation = await sdk.automations.get(ctx.params.id)
if (coreSdk.automations.isRowAction(automation)) { if (coreSdk.automations.isRowAction(automation)) {
ctx.throw("Row actions cannot be deleted", 400) ctx.throw("Row actions automations cannot be deleted", 422)
} }
ctx.body = await sdk.automations.remove(automationId, ctx.params.rev) ctx.body = await sdk.automations.remove(automationId, ctx.params.rev)

5
packages/server/src/api/routes/tests/automation.spec.ts
View File

@ -433,7 +433,10 @@ describe("/automations", () => {
.delete(`/api/automations/${automation._id}/${automation._rev}`) .delete(`/api/automations/${automation._id}/${automation._rev}`)
.set(config.defaultHeaders()) .set(config.defaultHeaders())
.expect("Content-Type", /json/) .expect("Content-Type", /json/)
.expect(400, { message: "Row actions cannot be deleted", status: 400 }) .expect(422, {
message: "Row actions automations cannot be deleted",
status: 422,
})
expect(events.automation.deleted).not.toHaveBeenCalled() expect(events.automation.deleted).not.toHaveBeenCalled()
}) })