Merge pull request #4820 from Budibase/fix/preview-event-callbacks

Properly remove window event listener when unmounting component preview
2022-03-08 08:44:13 +00:00 · 2022-03-08 08:44:13 +00:00 · a4cf6b6197
parent 45863690c4 8d87968a74
commit a4cf6b6197
1 changed files with 2 additions and 1 deletions
--- a/packages/builder/src/components/design/AppPreview/CurrentItemPreview.svelte
+++ b/packages/builder/src/components/design/AppPreview/CurrentItemPreview.svelte
@ -134,8 +134,9 @@

  // Remove all iframe event listeners on component destroy
  onDestroy(() => {
-    if (iframe.contentWindow) {
    window.removeEventListener("message", receiveMessage)
+
+    if (iframe.contentWindow) {
      if (!$store.clientFeatures.messagePassing) {
        // Legacy - remove in later versions of BB
        iframe.contentWindow.removeEventListener(