MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Updating application tests to run a lot deeper, which required updating some other tests to account for creation of empty screens and layouts.

This commit is contained in:
mike12345567 2021-03-10 12:56:30 +00:00
parent a48f1c72f2
commit a6bde49ad3
6 changed files with 61 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/server/src/api/controllers/application.js
View File

@ -104,9 +104,10 @@ async function createInstance(template) {
await createRoutingView(appId)
// replicate the template data to the instance DB
// this is currently very hard to test, downloading and importing template files
/* istanbul ignore next */
if (template) {
let dbDumpReadStream
if (template.fileImportPath) {
dbDumpReadStream = fs.createReadStream(template.fileImportPath)
} else {
@ -181,8 +182,9 @@ exports.create = async function(ctx) {
const instanceDb = new CouchDB(appId)
await instanceDb.put(newApplication)
const newAppFolder = await createEmptyAppPackage(ctx, newApplication)
/* istanbul ignore next */
if (env.NODE_ENV !== "jest") {
const newAppFolder = await createEmptyAppPackage(ctx, newApplication)
await downloadExtractComponentLibraries(newAppFolder)
}

39
packages/server/src/api/routes/tests/application.spec.js
View File

@ -58,4 +58,43 @@ describe("/applications", () => {
})
})
describe("fetchAppDefinition", () => {
it("should be able to get an apps definition", async () => {
const res = await request
.get(`/api/applications/${config.getAppId()}/definition`)
.set(config.defaultHeaders())
.expect('Content-Type', /json/)
.expect(200)
// should have empty packages
expect(res.body.screens.length).toEqual(2)
expect(res.body.layouts.length).toEqual(2)
})
})
describe("fetchAppPackage", () => {
it("should be able to fetch the app package", async () => {
const res = await request
.get(`/api/applications/${config.getAppId()}/appPackage`)
.set(config.defaultHeaders())
.expect('Content-Type', /json/)
.expect(200)
expect(res.body.application).toBeDefined()
expect(res.body.screens.length).toEqual(2)
expect(res.body.layouts.length).toEqual(2)
})
})
describe("update", () => {
it("should be able to fetch the app package", async () => {
const res = await request
.put(`/api/applications/${config.getAppId()}`)
.send({
name: "TEST_APP"
})
.set(config.defaultHeaders())
.expect('Content-Type', /json/)
.expect(200)
expect(res.body.rev).toBeDefined()
})
})
})

2
packages/server/src/api/routes/tests/automation.spec.js
View File

@ -73,7 +73,7 @@ describe("/automations", () => {
.expect('Content-Type', /json/)
.expect(200)
expect(Object.keys(res.body.action).length).toEqual(Object.keys(ACTION_DEFINITIONS).length)
expect(Object.keys(res.body.action).length).toBeGreaterThanOrEqual(Object.keys(ACTION_DEFINITIONS).length)
expect(Object.keys(res.body.trigger).length).toEqual(Object.keys(TRIGGER_DEFINITIONS).length)
expect(Object.keys(res.body.logic).length).toEqual(Object.keys(LOGIC_DEFINITIONS).length)
})

29
packages/server/src/api/routes/tests/routing.spec.js
View File

@ -3,6 +3,8 @@ const { basicScreen } = require("./utilities/structures")
const { checkBuilderEndpoint } = require("./utilities/TestFunctions")
const { BUILTIN_ROLE_IDS } = require("../../../utilities/security/roles")
const route = "/test"
describe("/routing", () => {
let request = setup.getRequest()
let config = setup.getConfig()
@ -12,9 +14,12 @@ describe("/routing", () => {
beforeEach(async () => {
await config.init()
screen = await config.createScreen(basicScreen())
screen = basicScreen()
screen.routing.route = route
screen = await config.createScreen(screen)
screen2 = basicScreen()
screen2.routing.roleId = BUILTIN_ROLE_IDS.POWER
screen2.routing.route = route
screen2 = await config.createScreen(screen2)
})
@ -26,9 +31,9 @@ describe("/routing", () => {
.expect("Content-Type", /json/)
.expect(200)
expect(res.body.routes).toBeDefined()
expect(res.body.routes["/"]).toEqual({
expect(res.body.routes[route]).toEqual({
subpaths: {
["/"]: {
[route]: {
screenId: screen._id,
roleId: screen.routing.roleId
}
@ -43,9 +48,9 @@ describe("/routing", () => {
.expect("Content-Type", /json/)
.expect(200)
expect(res.body.routes).toBeDefined()
expect(res.body.routes["/"]).toEqual({
expect(res.body.routes[route]).toEqual({
subpaths: {
["/"]: {
[route]: {
screenId: screen2._id,
roleId: screen2.routing.roleId
}
@ -62,16 +67,10 @@ describe("/routing", () => {
.expect("Content-Type", /json/)
.expect(200)
expect(res.body.routes).toBeDefined()
expect(res.body.routes["/"]).toEqual({
subpaths: {
["/"]: {
screens: {
[screen2.routing.roleId]: screen2._id,
[screen.routing.roleId]: screen._id,
}
}
}
})
expect(res.body.routes[route].subpaths[route]).toBeDefined()
const subpath = res.body.routes[route].subpaths[route]
expect(subpath.screens[screen2.routing.roleId]).toEqual(screen2._id)
expect(subpath.screens[screen.routing.roleId]).toEqual(screen._id)
})
it("make sure it is a builder only endpoint", async () => {

4
packages/server/src/api/routes/tests/screen.spec.js
View File

@ -21,8 +21,8 @@ describe("/screens", () => {
.set(config.defaultHeaders())
.expect("Content-Type", /json/)
.expect(200)
expect(res.body.length).toEqual(1)
expect(res.body[0]._id).toEqual(screen._id)
expect(res.body.length).toEqual(3)
expect(res.body.some(s => s._id === screen._id)).toEqual(true)
})
it("should apply authorization to endpoint", async () => {

2
packages/server/src/api/routes/tests/utilities/TestConfiguration.js
View File

@ -241,7 +241,7 @@ class TestConfiguration {
async createUser(
email = EMAIL,
password = PASSWORD,
roleId = BUILTIN_ROLE_IDS.POWER,
roleId = BUILTIN_ROLE_IDS.POWER
) {
return this._req(
{