MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix trimming extra view fields and ensure empty views allow nothing

This commit is contained in:
Andrew Kingston 2023-08-14 12:04:36 +01:00
parent d1b3d033dd
commit a7b37a4550
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/server/src/middleware/trimViewRowInfo.ts
View File

@ -23,7 +23,7 @@ export default async (ctx: Ctx<Row>, next: Next) => {
// don't need to trim delete requests // don't need to trim delete requests
if (ctx?.method?.toLowerCase() !== "delete") { if (ctx?.method?.toLowerCase() !== "delete") {
await trimViewFields(ctx.request.body, viewId, tableId) await trimViewFields(ctx.request.body, viewId)
} }
ctx.params.sourceId = tableId ctx.params.sourceId = tableId
@ -35,17 +35,10 @@ export default async (ctx: Ctx<Row>, next: Next) => {
export async function trimViewFields<T extends Row>( export async function trimViewFields<T extends Row>(
body: Row, body: Row,
viewId: string, viewId: string,
tableId: string
): Promise<void> { ): Promise<void> {
const view = await sdk.views.get(viewId) const view = await sdk.views.get(viewId)
if (!view?.schema || !Object.keys(view.schema).length) {
return
}
const table = await sdk.tables.getTable(tableId)
const { schema } = sdk.views.enrichSchema(view!, table.schema)
const allowedKeys = [ const allowedKeys = [
...Object.keys(schema), ...Object.keys(view?.schema || {}),
...db.CONSTANT_EXTERNAL_ROW_COLS, ...db.CONSTANT_EXTERNAL_ROW_COLS,
...db.CONSTANT_INTERNAL_ROW_COLS, ...db.CONSTANT_INTERNAL_ROW_COLS,
] ]