MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Respond to PR feedback.

This commit is contained in:
Sam Rose 2024-09-26 16:21:34 +01:00
parent 743140eeae
commit aa738659ae
No known key found for this signature in database
2 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
packages/server/src/api/controllers/row/utils/basic.ts
View File

@ -134,22 +134,20 @@ export async function basicProcessing({
} }
let columns: string[] = Object.keys(table.schema) let columns: string[] = Object.keys(table.schema)
if (!isCalculationView) { if (!sqs && !isCalculationView) {
if (!sqs) { thisRow._id = generateIdForRow(row, table, isLinked)
thisRow._id = generateIdForRow(row, table, isLinked) thisRow.tableId = table._id
thisRow.tableId = table._id thisRow._rev = "rev"
thisRow._rev = "rev" columns = columns.concat(PROTECTED_EXTERNAL_COLUMNS)
columns = columns.concat(PROTECTED_EXTERNAL_COLUMNS) } else if (!isCalculationView) {
} else { columns = columns.concat(PROTECTED_EXTERNAL_COLUMNS)
columns = columns.concat(PROTECTED_EXTERNAL_COLUMNS) for (let internalColumn of [...PROTECTED_INTERNAL_COLUMNS, ...columns]) {
for (let internalColumn of [...PROTECTED_INTERNAL_COLUMNS, ...columns]) { thisRow[internalColumn] = extractFieldValue({
thisRow[internalColumn] = extractFieldValue({ row,
row, tableName: table._id!,
tableName: table._id!, fieldName: internalColumn,
fieldName: internalColumn, isLinked,
isLinked, })
})
}
} }
} }
for (let col of columns) { for (let col of columns) {

1
packages/server/src/sdk/app/rows/internal.ts
View File

@ -1,7 +1,6 @@
import { context, db } from "@budibase/backend-core" import { context, db } from "@budibase/backend-core"
import { Row, Table, ViewV2 } from "@budibase/types" import { Row, Table, ViewV2 } from "@budibase/types"
import sdk from "../../../sdk" import sdk from "../../../sdk"
import cloneDeep from "lodash/fp/cloneDeep"
import { finaliseRow } from "../../../api/controllers/row/staticFormula" import { finaliseRow } from "../../../api/controllers/row/staticFormula"
import { import {
inputProcessing, inputProcessing,