From aa7fe8f1b5b6dafc0b51423c0aabfdc5c7b7603a Mon Sep 17 00:00:00 2001 From: Dean Date: Wed, 3 Apr 2024 09:11:56 +0100 Subject: [PATCH] PR feedback --- .../design/[screenId]/_components/AppPreview.svelte | 2 +- .../client/src/components/preview/SelectionIndicator.svelte | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte index dc22840261..0ce9e096f2 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte +++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte @@ -125,7 +125,7 @@ // Catch any app errors loading = false error = event.error || "An unknown error occurred" - } else if (type === "select-component" && "id" in data) { + } else if (type === "select-component" && data.id) { componentStore.select(data.id) componentTreeNodesStore.makeNodeVisible(data.id) } else if (type === "hover-component") { diff --git a/packages/client/src/components/preview/SelectionIndicator.svelte b/packages/client/src/components/preview/SelectionIndicator.svelte index cb7d48e919..a271389cbd 100644 --- a/packages/client/src/components/preview/SelectionIndicator.svelte +++ b/packages/client/src/components/preview/SelectionIndicator.svelte @@ -5,14 +5,10 @@ $: color = $builderStore.editMode ? "var(--spectrum-global-color-static-green-500)" : "var(--spectrum-global-color-static-blue-600)" - - $: isScreen = $builderStore.selectedComponentId?.startsWith( - $builderStore.screen._id - )