Merge pull request #1917 from Budibase/fix/sql-id-issue

Fixing issue with SQL _id field
This commit is contained in:
Michael Drury 2021-07-05 15:30:45 +01:00 committed by GitHub
commit ae409bacee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions

View File

@ -25,6 +25,8 @@ export function generateRowIdField(keyProps: any[] = []) {
keyProps = [keyProps]
}
// this conserves order and types
// we have to swap the double quotes to single quotes for use in HBS statements
// when using the literal helper the double quotes can break things
return encodeURIComponent(JSON.stringify(keyProps).replace(/"/g, "'"))
}
@ -33,7 +35,11 @@ export function breakRowIdField(_id: string) {
if (!_id) {
return null
}
return JSON.parse(decodeURIComponent(_id))
// have to replace on the way back as we swapped out the double quotes
// when encoding, but JSON can't handle the single quotes
const decoded = decodeURIComponent(_id).replace(/'/g, '"')
const parsed = JSON.parse(decoded)
return Array.isArray(parsed) ? parsed : [parsed]
}
export function convertType(type: string, map: { [key: string]: any }) {