MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Prevent collapsed component settings sections reverting on component settings changes. (#12523) 

* wip

* lint

* fixes

* Pr feedback

* remove unneeded renaming

* remove other unneeded renaming
This commit is contained in:
Gerard Burns 2023-12-08 12:22:40 +00:00 committed by GitHub
parent 930b8c934f
commit af35250371
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/bbui/src/DetailSummary/DetailSummary.svelte
View File

@ -1,20 +1,17 @@
<script> <script>
import Icon from "../Icon/Icon.svelte" import Icon from "../Icon/Icon.svelte"
import { createEventDispatcher } from "svelte"
export let name export let name
export let show = false export let initiallyShow = false
export let collapsible = true export let collapsible = true
const dispatch = createEventDispatcher() let show = initiallyShow
const onHeaderClick = () => { const onHeaderClick = () => {
if (!collapsible) { if (!collapsible) {
return return
} }
show = !show show = !show
if (show) {
dispatch("open")
}
} }
</script> </script>

3
packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ComponentSettingsSection.svelte
View File

@ -32,6 +32,7 @@
const generalSettings = settings.filter( const generalSettings = settings.filter(
setting => !setting.section && setting.tag === tag setting => !setting.section && setting.tag === tag
) )
const customSections = settings.filter( const customSections = settings.filter(
setting => setting.section && setting.tag === tag setting => setting.section && setting.tag === tag
) )
@ -151,7 +152,7 @@
{#if section.visible} {#if section.visible}
<DetailSummary <DetailSummary
name={showSectionTitle ? section.name : ""} name={showSectionTitle ? section.name : ""}
show={section.collapsed !== true} initiallyShow={section.collapsed !== true}
> >
{#if section.info} {#if section.info}
<div class="section-info"> <div class="section-info">