From af997be2e9c25c7aced01fdb06c1b884bb7b821c Mon Sep 17 00:00:00 2001
From: Mel O'Hagan <mel@budibase.com>
Date: Fri, 13 May 2022 21:22:10 +0100
Subject: [PATCH] Check type is string before match

---
 packages/server/src/integrations/mongodb.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/server/src/integrations/mongodb.ts b/packages/server/src/integrations/mongodb.ts
index afb7c4109c..8237cd7844 100644
--- a/packages/server/src/integrations/mongodb.ts
+++ b/packages/server/src/integrations/mongodb.ts
@@ -85,12 +85,12 @@ module MongoDBModule {
 
     createObjectIds(json: any): object {
       const self = this
-      function replaceObjectIds(json: any) {
+      function interpolateObjectIds(json: any) {
         for (let field of Object.keys(json)) {
           if (json[field] instanceof Object) {
             json[field] = self.createObjectIds(json[field])
           }
-          if (field === "_id") {
+          if (field === "_id" && typeof json[field] === "string") {
             const id = json["_id"].match(
               /(?<=objectid\(['"]).*(?=['"]\))/gi
             )?.[0]
@@ -104,11 +104,11 @@ module MongoDBModule {
 
       if (Array.isArray(json)) {
         for (let i = 0; i < json.length; i++) {
-          json[i] = replaceObjectIds(json[i])
+          json[i] = interpolateObjectIds(json[i])
         }
         return json
       }
-      return replaceObjectIds(json)
+      return interpolateObjectIds(json)
     }
 
     async create(query: { json: object; extra: { [key: string]: string } }) {