From 66cfb8eeddbc713e50372b2e8553fabed766035c Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Fri, 22 Mar 2024 17:04:45 +0000 Subject: [PATCH 01/54] Remove jest-testcontainers. --- jestTestcontainersConfigGenerator.js | 4 +-- packages/backend-core/src/db/Replication.ts | 2 +- packages/server/jest-testcontainers-config.js | 8 ------ packages/server/jest.config.ts | 2 ++ packages/server/scripts/test.sh | 2 ++ packages/server/src/tests/globalSetup.ts | 27 +++++++++++++++++++ packages/server/src/tests/globalTeardown.ts | 12 +++++++++ packages/server/src/tests/jestEnv.ts | 3 +++ packages/server/src/tests/test-couchdb.ini | 2 ++ .../server/src/tests/utilities/api/base.ts | 16 +++++++++++ 10 files changed, 67 insertions(+), 11 deletions(-) delete mode 100644 packages/server/jest-testcontainers-config.js create mode 100644 packages/server/src/tests/globalSetup.ts create mode 100644 packages/server/src/tests/globalTeardown.ts create mode 100644 packages/server/src/tests/test-couchdb.ini diff --git a/jestTestcontainersConfigGenerator.js b/jestTestcontainersConfigGenerator.js index 1e39ed771f..82d50145e6 100644 --- a/jestTestcontainersConfigGenerator.js +++ b/jestTestcontainersConfigGenerator.js @@ -10,7 +10,7 @@ module.exports = () => { wait: { type: "ports", timeout: 20000, - } - } + }, + }, } } diff --git a/packages/backend-core/src/db/Replication.ts b/packages/backend-core/src/db/Replication.ts index 9c960d76dd..735c2fa86e 100644 --- a/packages/backend-core/src/db/Replication.ts +++ b/packages/backend-core/src/db/Replication.ts @@ -27,7 +27,7 @@ class Replication { return resolve(info) }) .on("error", function (err) { - throw new Error(`Replication Error: ${err}`) + throw err }) }) } diff --git a/packages/server/jest-testcontainers-config.js b/packages/server/jest-testcontainers-config.js deleted file mode 100644 index 8ac0f0cd9d..0000000000 --- a/packages/server/jest-testcontainers-config.js +++ /dev/null @@ -1,8 +0,0 @@ -const { join } = require("path") -require("dotenv").config({ - path: join(__dirname, "..", "..", "hosting", ".env"), -}) - -const jestTestcontainersConfigGenerator = require("../../jestTestcontainersConfigGenerator") - -module.exports = jestTestcontainersConfigGenerator() diff --git a/packages/server/jest.config.ts b/packages/server/jest.config.ts index 6c6d6a20d3..20979d7999 100644 --- a/packages/server/jest.config.ts +++ b/packages/server/jest.config.ts @@ -18,6 +18,8 @@ const baseConfig: Config.InitialProjectOptions = { "svelte", ], setupFilesAfterEnv: ["./src/tests/jestSetup.ts"], + globalSetup: "./src/tests/globalSetup.ts", + globalTeardown: "./src/tests/globalTeardown.ts", transform: { "^.+\\.ts?$": "@swc/jest", "^.+\\.js?$": "@swc/jest", diff --git a/packages/server/scripts/test.sh b/packages/server/scripts/test.sh index 3ecf8bb794..58e68c9749 100644 --- a/packages/server/scripts/test.sh +++ b/packages/server/scripts/test.sh @@ -1,6 +1,8 @@ #!/bin/bash set -e +export DEBUG="testcontainers*" + if [[ -n $CI ]] then export NODE_OPTIONS="--max-old-space-size=4096 --no-node-snapshot $NODE_OPTIONS" diff --git a/packages/server/src/tests/globalSetup.ts b/packages/server/src/tests/globalSetup.ts new file mode 100644 index 0000000000..1bb61a79d9 --- /dev/null +++ b/packages/server/src/tests/globalSetup.ts @@ -0,0 +1,27 @@ +import { GenericContainer, Wait } from "testcontainers" + +export default async function setup() { + const container = await new GenericContainer("budibase/couchdb") + .withName("couchdb-service") + .withExposedPorts(5984) + .withEnvironment({ + COUCHDB_PASSWORD: "budibase", + COUCHDB_USER: "budibase", + }) + .withCopyFilesToContainer([ + { + source: "./src/tests/test-couchdb.ini", + target: "/opt/couchdb/etc/local.d/test-couchdb.ini", + }, + ]) + .withWaitStrategy( + Wait.forSuccessfulCommand( + "curl http://budibase:budibase@localhost:5984/_up" + ).withStartupTimeout(20000) + ) + .start() + + // @ts-expect-error + // eslint-disable-next-line no-undef + globalThis.__COUCHDB_CONTAINER_ID__ = container.getId() +} diff --git a/packages/server/src/tests/globalTeardown.ts b/packages/server/src/tests/globalTeardown.ts new file mode 100644 index 0000000000..4be959c1f9 --- /dev/null +++ b/packages/server/src/tests/globalTeardown.ts @@ -0,0 +1,12 @@ +import { getContainerRuntimeClient } from "testcontainers" + +export default async function teardown() { + const client = await getContainerRuntimeClient() + + // @ts-expect-error + // eslint-disable-next-line no-undef + const containerId = globalThis.__COUCHDB_CONTAINER_ID__ + const container = client.container.getById(containerId) + await client.container.stop(container) + await client.container.remove(container) +} diff --git a/packages/server/src/tests/jestEnv.ts b/packages/server/src/tests/jestEnv.ts index 7c58470e9b..3b0c2a88d9 100644 --- a/packages/server/src/tests/jestEnv.ts +++ b/packages/server/src/tests/jestEnv.ts @@ -11,3 +11,6 @@ process.env.PLATFORM_URL = "http://localhost:10000" process.env.REDIS_PASSWORD = "budibase" process.env.BUDIBASE_VERSION = "0.0.0+jest" process.env.WORKER_URL = "http://localhost:10000" +process.env.COUCH_DB_PASSWORD = "budibase" +process.env.COUCH_DB_USER = "budibase" +process.env.JWT_SECRET = "jwtsecret" diff --git a/packages/server/src/tests/test-couchdb.ini b/packages/server/src/tests/test-couchdb.ini new file mode 100644 index 0000000000..8924e6ec3f --- /dev/null +++ b/packages/server/src/tests/test-couchdb.ini @@ -0,0 +1,2 @@ +[log] +level = warn \ No newline at end of file diff --git a/packages/server/src/tests/utilities/api/base.ts b/packages/server/src/tests/utilities/api/base.ts index 4df58ff425..486514cfbe 100644 --- a/packages/server/src/tests/utilities/api/base.ts +++ b/packages/server/src/tests/utilities/api/base.ts @@ -187,6 +187,22 @@ export abstract class TestAPI { expect(response.body).toMatchObject(expectations.body) } + if (response.text && response.text.length > 0) { + // @ts-expect-error - we know this exists, it's just not in the types + const request = response.request as Test + const contentLength = response.headers["content-length"] + if (!contentLength) { + throw new Error( + `Failed request "${request.method} ${request.url}": Content-Length header not present, but response has a body (body length ${response.text.length})` + ) + } + if (parseInt(contentLength) !== response.text.length) { + throw new Error( + `Failed request "${request.method} ${request.url}": Content-Length header does not match response body length (header: ${contentLength}, body: ${response.text.length})` + ) + } + } + return response } From db21542d386ef5e2725209eca6e70e8dda52716f Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Fri, 22 Mar 2024 17:34:50 +0000 Subject: [PATCH 02/54] Cherry-pick 6b8422df016bd1c2d1a75133a00cb1bd4153c150 --- .../jest-testcontainers-config.js | 8 - packages/backend-core/jest.config.ts | 3 +- packages/backend-core/package.json | 1 - .../backend-core/src/tests/globalSetup.ts | 27 +++ .../backend-core/src/tests/globalTeardown.ts | 12 ++ packages/backend-core/tests/jestEnv.ts | 2 + packages/server/jest.config.ts | 1 - packages/server/package.json | 1 - packages/worker/jest-testcontainers-config.js | 8 - packages/worker/jest.config.ts | 3 +- packages/worker/package.json | 1 - packages/worker/src/tests/globalSetup.ts | 27 +++ packages/worker/src/tests/globalTeardown.ts | 12 ++ packages/worker/src/tests/jestEnv.ts | 2 + yarn.lock | 167 +++--------------- 15 files changed, 112 insertions(+), 163 deletions(-) delete mode 100644 packages/backend-core/jest-testcontainers-config.js create mode 100644 packages/backend-core/src/tests/globalSetup.ts create mode 100644 packages/backend-core/src/tests/globalTeardown.ts delete mode 100644 packages/worker/jest-testcontainers-config.js create mode 100644 packages/worker/src/tests/globalSetup.ts create mode 100644 packages/worker/src/tests/globalTeardown.ts diff --git a/packages/backend-core/jest-testcontainers-config.js b/packages/backend-core/jest-testcontainers-config.js deleted file mode 100644 index 8ac0f0cd9d..0000000000 --- a/packages/backend-core/jest-testcontainers-config.js +++ /dev/null @@ -1,8 +0,0 @@ -const { join } = require("path") -require("dotenv").config({ - path: join(__dirname, "..", "..", "hosting", ".env"), -}) - -const jestTestcontainersConfigGenerator = require("../../jestTestcontainersConfigGenerator") - -module.exports = jestTestcontainersConfigGenerator() diff --git a/packages/backend-core/jest.config.ts b/packages/backend-core/jest.config.ts index 3f1065ead2..83e87a6f7a 100644 --- a/packages/backend-core/jest.config.ts +++ b/packages/backend-core/jest.config.ts @@ -1,8 +1,9 @@ import { Config } from "@jest/types" const baseConfig: Config.InitialProjectOptions = { - preset: "@trendyol/jest-testcontainers", setupFiles: ["./tests/jestEnv.ts"], + globalSetup: "./src/tests/globalSetup.ts", + globalTeardown: "./src/tests/globalTeardown.ts", setupFilesAfterEnv: ["./tests/jestSetup.ts"], transform: { "^.+\\.ts?$": "@swc/jest", diff --git a/packages/backend-core/package.json b/packages/backend-core/package.json index fe56780982..030fec8728 100644 --- a/packages/backend-core/package.json +++ b/packages/backend-core/package.json @@ -60,7 +60,6 @@ "@shopify/jest-koa-mocks": "5.1.1", "@swc/core": "1.3.71", "@swc/jest": "0.2.27", - "@trendyol/jest-testcontainers": "^2.1.1", "@types/chance": "1.1.3", "@types/cookies": "0.7.8", "@types/jest": "29.5.5", diff --git a/packages/backend-core/src/tests/globalSetup.ts b/packages/backend-core/src/tests/globalSetup.ts new file mode 100644 index 0000000000..1bb61a79d9 --- /dev/null +++ b/packages/backend-core/src/tests/globalSetup.ts @@ -0,0 +1,27 @@ +import { GenericContainer, Wait } from "testcontainers" + +export default async function setup() { + const container = await new GenericContainer("budibase/couchdb") + .withName("couchdb-service") + .withExposedPorts(5984) + .withEnvironment({ + COUCHDB_PASSWORD: "budibase", + COUCHDB_USER: "budibase", + }) + .withCopyFilesToContainer([ + { + source: "./src/tests/test-couchdb.ini", + target: "/opt/couchdb/etc/local.d/test-couchdb.ini", + }, + ]) + .withWaitStrategy( + Wait.forSuccessfulCommand( + "curl http://budibase:budibase@localhost:5984/_up" + ).withStartupTimeout(20000) + ) + .start() + + // @ts-expect-error + // eslint-disable-next-line no-undef + globalThis.__COUCHDB_CONTAINER_ID__ = container.getId() +} diff --git a/packages/backend-core/src/tests/globalTeardown.ts b/packages/backend-core/src/tests/globalTeardown.ts new file mode 100644 index 0000000000..4be959c1f9 --- /dev/null +++ b/packages/backend-core/src/tests/globalTeardown.ts @@ -0,0 +1,12 @@ +import { getContainerRuntimeClient } from "testcontainers" + +export default async function teardown() { + const client = await getContainerRuntimeClient() + + // @ts-expect-error + // eslint-disable-next-line no-undef + const containerId = globalThis.__COUCHDB_CONTAINER_ID__ + const container = client.container.getById(containerId) + await client.container.stop(container) + await client.container.remove(container) +} diff --git a/packages/backend-core/tests/jestEnv.ts b/packages/backend-core/tests/jestEnv.ts index c2047118ec..bfeb3eca72 100644 --- a/packages/backend-core/tests/jestEnv.ts +++ b/packages/backend-core/tests/jestEnv.ts @@ -4,3 +4,5 @@ process.env.NODE_ENV = "jest" process.env.MOCK_REDIS = "1" process.env.LOG_LEVEL = process.env.LOG_LEVEL || "error" process.env.REDIS_PASSWORD = "budibase" +process.env.COUCH_DB_PASSWORD = "budibase" +process.env.COUCH_DB_USER = "budibase" diff --git a/packages/server/jest.config.ts b/packages/server/jest.config.ts index 20979d7999..5795bedca5 100644 --- a/packages/server/jest.config.ts +++ b/packages/server/jest.config.ts @@ -4,7 +4,6 @@ import * as fs from "fs" import { join } from "path" const baseConfig: Config.InitialProjectOptions = { - preset: "@trendyol/jest-testcontainers", setupFiles: ["./src/tests/jestEnv.ts"], moduleFileExtensions: [ "js", diff --git a/packages/server/package.json b/packages/server/package.json index 8e66f3d7e0..424a0559b7 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -121,7 +121,6 @@ "@babel/preset-env": "7.16.11", "@swc/core": "1.3.71", "@swc/jest": "0.2.27", - "@trendyol/jest-testcontainers": "2.1.1", "@types/global-agent": "2.1.1", "@types/google-spreadsheet": "3.1.5", "@types/jest": "29.5.5", diff --git a/packages/worker/jest-testcontainers-config.js b/packages/worker/jest-testcontainers-config.js deleted file mode 100644 index 8ac0f0cd9d..0000000000 --- a/packages/worker/jest-testcontainers-config.js +++ /dev/null @@ -1,8 +0,0 @@ -const { join } = require("path") -require("dotenv").config({ - path: join(__dirname, "..", "..", "hosting", ".env"), -}) - -const jestTestcontainersConfigGenerator = require("../../jestTestcontainersConfigGenerator") - -module.exports = jestTestcontainersConfigGenerator() diff --git a/packages/worker/jest.config.ts b/packages/worker/jest.config.ts index 1eb17f100f..b227ee1309 100644 --- a/packages/worker/jest.config.ts +++ b/packages/worker/jest.config.ts @@ -2,7 +2,8 @@ import { Config } from "@jest/types" import * as fs from "fs" const config: Config.InitialOptions = { - preset: "@trendyol/jest-testcontainers", + globalSetup: "./src/tests/globalSetup.ts", + globalTeardown: "./src/tests/globalTeardown.ts", setupFiles: ["./src/tests/jestEnv.ts"], setupFilesAfterEnv: ["./src/tests/jestSetup.ts"], collectCoverageFrom: ["src/**/*.{js,ts}", "../backend-core/src/**/*.{js,ts}"], diff --git a/packages/worker/package.json b/packages/worker/package.json index efdbe6aa12..0c2a9f3b72 100644 --- a/packages/worker/package.json +++ b/packages/worker/package.json @@ -75,7 +75,6 @@ "devDependencies": { "@swc/core": "1.3.71", "@swc/jest": "0.2.27", - "@trendyol/jest-testcontainers": "2.1.1", "@types/jest": "29.5.5", "@types/jsonwebtoken": "9.0.3", "@types/koa": "2.13.4", diff --git a/packages/worker/src/tests/globalSetup.ts b/packages/worker/src/tests/globalSetup.ts new file mode 100644 index 0000000000..1bb61a79d9 --- /dev/null +++ b/packages/worker/src/tests/globalSetup.ts @@ -0,0 +1,27 @@ +import { GenericContainer, Wait } from "testcontainers" + +export default async function setup() { + const container = await new GenericContainer("budibase/couchdb") + .withName("couchdb-service") + .withExposedPorts(5984) + .withEnvironment({ + COUCHDB_PASSWORD: "budibase", + COUCHDB_USER: "budibase", + }) + .withCopyFilesToContainer([ + { + source: "./src/tests/test-couchdb.ini", + target: "/opt/couchdb/etc/local.d/test-couchdb.ini", + }, + ]) + .withWaitStrategy( + Wait.forSuccessfulCommand( + "curl http://budibase:budibase@localhost:5984/_up" + ).withStartupTimeout(20000) + ) + .start() + + // @ts-expect-error + // eslint-disable-next-line no-undef + globalThis.__COUCHDB_CONTAINER_ID__ = container.getId() +} diff --git a/packages/worker/src/tests/globalTeardown.ts b/packages/worker/src/tests/globalTeardown.ts new file mode 100644 index 0000000000..4be959c1f9 --- /dev/null +++ b/packages/worker/src/tests/globalTeardown.ts @@ -0,0 +1,12 @@ +import { getContainerRuntimeClient } from "testcontainers" + +export default async function teardown() { + const client = await getContainerRuntimeClient() + + // @ts-expect-error + // eslint-disable-next-line no-undef + const containerId = globalThis.__COUCHDB_CONTAINER_ID__ + const container = client.container.getById(containerId) + await client.container.stop(container) + await client.container.remove(container) +} diff --git a/packages/worker/src/tests/jestEnv.ts b/packages/worker/src/tests/jestEnv.ts index 9bd258c43c..c044e0817f 100644 --- a/packages/worker/src/tests/jestEnv.ts +++ b/packages/worker/src/tests/jestEnv.ts @@ -11,3 +11,5 @@ process.env.INTERNAL_API_KEY = "tet" process.env.DISABLE_ACCOUNT_PORTAL = "0" process.env.MOCK_REDIS = "1" process.env.BUDIBASE_VERSION = "0.0.0+jest" +process.env.COUCH_DB_PASSWORD = "budibase" +process.env.COUCH_DB_USER = "budibase" diff --git a/yarn.lock b/yarn.lock index 601bbf4641..585e043593 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5098,7 +5098,7 @@ resolved "https://registry.yarnpkg.com/@tootallnate/once/-/once-2.0.0.tgz#f544a148d3ab35801c1f633a7441fd87c2e484bf" integrity sha512-XCuKFP5PS55gnMVu3dty8KPatLqUoy/ZYzDzAGCQ8JNFCkLXzmI7vNHCR+XpbZaMWQK/vQubr7PkYq8g470J/A== -"@trendyol/jest-testcontainers@2.1.1", "@trendyol/jest-testcontainers@^2.1.1": +"@trendyol/jest-testcontainers@2.1.1": version "2.1.1" resolved "https://registry.yarnpkg.com/@trendyol/jest-testcontainers/-/jest-testcontainers-2.1.1.tgz#dced95cf9c37b75efe0a65db9b75ae8912f2f14a" integrity sha512-4iAc2pMsev4BTUzoA7jO1VvbTOU2N3juQUYa8TwiSPXPuQtxKwV9WB9ZEP+JQ+Pj15YqfGOXp5H0WNMPtapjiA== @@ -7265,37 +7265,7 @@ axios-retry@^3.1.9: "@babel/runtime" "^7.15.4" is-retry-allowed "^2.2.0" -axios@0.24.0: - version "0.24.0" - resolved "https://registry.yarnpkg.com/axios/-/axios-0.24.0.tgz#804e6fa1e4b9c5288501dd9dff56a7a0940d20d6" - integrity sha512-Q6cWsys88HoPgAaFAVUb0WpPk0O8iTeisR9IMqy9G8AbO4NlpVknrnQS03zzF9PGAWgO3cgletO3VjV/P7VztA== - dependencies: - follow-redirects "^1.14.4" - -axios@1.1.3: - version "1.1.3" - resolved "https://registry.yarnpkg.com/axios/-/axios-1.1.3.tgz#8274250dada2edf53814ed7db644b9c2866c1e35" - integrity sha512-00tXVRwKx/FZr/IDVFt4C+f9FYairX517WoGCL6dpOntqLkZofjhu43F/Xl44UOpqa+9sLFDrG/XAnFsUYgkDA== - dependencies: - follow-redirects "^1.15.0" - form-data "^4.0.0" - proxy-from-env "^1.1.0" - -axios@^0.21.1, axios@^0.21.4: - version "0.21.4" - resolved "https://registry.yarnpkg.com/axios/-/axios-0.21.4.tgz#c67b90dc0568e5c1cf2b0b858c43ba28e2eda575" - integrity sha512-ut5vewkiu8jjGBdqpM44XxjuCjq9LAKeHVmoVfHVzy8eHgxxq8SbAVQNovDA8mVi05kP0Ea/n/UzcSHcTJQfNg== - dependencies: - follow-redirects "^1.14.0" - -axios@^0.26.0: - version "0.26.1" - resolved "https://registry.yarnpkg.com/axios/-/axios-0.26.1.tgz#1ede41c51fcf51bbbd6fd43669caaa4f0495aaa9" - integrity sha512-fPwcX4EvnSHuInCMItEhAGnaSEXRBjtzh9fOtsE6E1G6p7vl7edEeZe11QHf18+6+9gR5PbKV/sGKNaD8YaMeA== - dependencies: - follow-redirects "^1.14.8" - -axios@^1.0.0, axios@^1.1.3, axios@^1.5.0: +axios@0.24.0, axios@1.1.3, axios@1.6.3, axios@^0.21.1, axios@^0.21.4, axios@^0.26.0, axios@^1.0.0, axios@^1.1.3, axios@^1.5.0: version "1.6.3" resolved "https://registry.yarnpkg.com/axios/-/axios-1.6.3.tgz#7f50f23b3aa246eff43c54834272346c396613f4" integrity sha512-fWyNdeawGam70jXSVlKl+SUNVcL6j6W79CuSIPfi6HnDUmSCH6gyUys/HrqHeA/wU0Az41rRgean494d0Jb+ww== @@ -11285,11 +11255,6 @@ fn.name@1.x.x: resolved "https://registry.yarnpkg.com/fn.name/-/fn.name-1.1.0.tgz#26cad8017967aea8731bc42961d04a3d5988accc" integrity sha512-GRnmB5gPyJpAhTQdSZTSp9uaPSvl09KoYcMQtsB9rQoOmzs9dH6ffeccH+Z+cv6P68Hu5bC6JjRh4Ah/mHSNRw== -follow-redirects@^1.14.0, follow-redirects@^1.14.4, follow-redirects@^1.14.8: - version "1.15.6" - resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.15.6.tgz#7f815c0cda4249c74ff09e95ef97c23b5fd0399b" - integrity sha512-wWN62YITEaOpSK584EZXJafH1AGpO8RVgElfkuXbTOrPX4fIfOyEpW/CsiNd8JdYrAoOvafRTOEnvsO++qCqFA== - follow-redirects@^1.15.0: version "1.15.2" resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.15.2.tgz#b460864144ba63f2681096f274c4e57026da2c13" @@ -12431,12 +12396,7 @@ http-assert@^1.3.0: deep-equal "~1.0.1" http-errors "~1.8.0" -http-cache-semantics@3.8.1: - version "3.8.1" - resolved "https://registry.yarnpkg.com/http-cache-semantics/-/http-cache-semantics-3.8.1.tgz#39b0e16add9b605bf0a9ef3d9daaf4843b4cacd2" - integrity sha512-5ai2iksyV8ZXmnZhHH4rWPoxxistEexSi5936zIQ1bnNTW5VnA85B6P/VpXiRM017IgRvb2kKo1a//y+0wSp3w== - -http-cache-semantics@^4.0.0, http-cache-semantics@^4.1.0, http-cache-semantics@^4.1.1: +http-cache-semantics@3.8.1, http-cache-semantics@4.1.1, http-cache-semantics@^4.0.0, http-cache-semantics@^4.1.0, http-cache-semantics@^4.1.1: version "4.1.1" resolved "https://registry.yarnpkg.com/http-cache-semantics/-/http-cache-semantics-4.1.1.tgz#abe02fcb2985460bf0323be664436ec3476a6d5a" integrity sha512-er295DKPVsV82j5kw1Gjt+ADA/XYHsajl82cGNQG2eyoPkvgUhX+nDIyelzhIWbbsXP39EHcI6l5tYs2FYqYXQ== @@ -13386,6 +13346,11 @@ isobject@^3.0.1: resolved "https://registry.yarnpkg.com/isobject/-/isobject-3.0.1.tgz#4e431e92b11a9731636aa1f9c8d1ccbcfdab78df" integrity sha512-WhB9zCku7EGTj/HQQRz5aUQEUeoQZH2bWcltRErOpymJ4boYE6wL9Tbr23krRPSZ+C5zqNSrSw+Cc7sZZ4b7vg== +isobject@^4.0.0: + version "4.0.0" + resolved "https://registry.yarnpkg.com/isobject/-/isobject-4.0.0.tgz#3f1c9155e73b192022a80819bacd0343711697b0" + integrity sha512-S/2fF5wH8SJA/kmwr6HYhK/RI/OkhD84k8ntalo0iJjZikgq1XFvR5M8NPT1x5F7fBwCG3qHfnzeP/Vh/ZxCUA== + isolated-vm@^4.7.2: version "4.7.2" resolved "https://registry.yarnpkg.com/isolated-vm/-/isolated-vm-4.7.2.tgz#5670d5cce1d92004f9b825bec5b0b11fc7501b65" @@ -15980,7 +15945,7 @@ msgpackr-extract@^3.0.2: "@msgpackr-extract/msgpackr-extract-linux-x64" "3.0.2" "@msgpackr-extract/msgpackr-extract-win32-x64" "3.0.2" -msgpackr@^1.5.2: +msgpackr@1.10.1, msgpackr@^1.5.2: version "1.10.1" resolved "https://registry.yarnpkg.com/msgpackr/-/msgpackr-1.10.1.tgz#51953bb4ce4f3494f0c4af3f484f01cfbb306555" integrity sha512-r5VRLv9qouXuLiIBrLpl2d5ZvPt8svdQTl5/vMvE4nzDMyEX4sgW5yWhuBBj5UmgwOTWj8CIdSXn5sAfsHAWIQ== @@ -16189,25 +16154,13 @@ node-duration@^1.0.4: resolved "https://registry.yarnpkg.com/node-duration/-/node-duration-1.0.4.tgz#3e94ecc0e473691c89c4560074503362071cecac" integrity sha512-eUXYNSY7DL53vqfTosggWkvyIW3bhAcqBDIlolgNYlZhianXTrCL50rlUJWD1eRqkIxMppXTfiFbp+9SjpPrgA== -node-fetch@2.6.0: - version "2.6.0" - resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.0.tgz#e633456386d4aa55863f676a7ab0daa8fdecb0fd" - integrity sha512-8dG4H5ujfvFiqDmVu9fQ5bOHUC15JMjMY/Zumv26oOvvVJjM67KF8koCWIabKQ1GJIa9r2mMZscBq/TbdOcmNA== - -node-fetch@2.6.7, node-fetch@^2.6.0, node-fetch@^2.6.1, node-fetch@^2.6.7: +node-fetch@2.6.0, node-fetch@2.6.7, node-fetch@^2.6.0, node-fetch@^2.6.1, node-fetch@^2.6.7, node-fetch@^2.6.9, node-fetch@^2.7.0: version "2.6.7" resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.7.tgz#24de9fba827e3b4ae44dc8b20256a379160052ad" integrity sha512-ZjMPFEfVx5j+y2yF35Kzx5sF7kDzxuDj6ziH4FFbOp87zKDZNx8yExJIb05OGF4Nlt9IHFIMBkRl41VdvcNdbQ== dependencies: whatwg-url "^5.0.0" -node-fetch@^2.6.9, node-fetch@^2.7.0: - version "2.7.0" - resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.7.0.tgz#d0f0fa6e3e2dc1d27efcd8ad99d550bda94d187d" - integrity sha512-c4FRfUm/dbcWZ7U+1Wq0AwCyFL+3nt2bEw05wfxSz+DWpWsitgmSgYmy2dQdWyKC1694ELPqMs/YzUSNozLt8A== - dependencies: - whatwg-url "^5.0.0" - node-forge@^1.3.1: version "1.3.1" resolved "https://registry.yarnpkg.com/node-forge/-/node-forge-1.3.1.tgz#be8da2af243b2417d5f646a770663a92b7e9ded3" @@ -17357,15 +17310,7 @@ passport-strategy@1.x.x, passport-strategy@^1.0.0: resolved "https://registry.yarnpkg.com/passport-strategy/-/passport-strategy-1.0.0.tgz#b5539aa8fc225a3d1ad179476ddf236b440f52e4" integrity sha512-CB97UUvDKJde2V0KDWWB3lyf6PC3FaZP7YxZ2G8OAtn9p4HI9j9JLP9qjOGZFvyl8uwNT8qM+hGnz/n16NI7oA== -passport@^0.4.0: - version "0.4.1" - resolved "https://registry.yarnpkg.com/passport/-/passport-0.4.1.tgz#941446a21cb92fc688d97a0861c38ce9f738f270" - integrity sha512-IxXgZZs8d7uFSt3eqNjM9NQ3g3uQCW5avD8mRNoXV99Yig50vjuaez6dQK2qC0kVWPRTujxY0dWgGfT09adjYg== - dependencies: - passport-strategy "1.x.x" - pause "0.0.1" - -passport@^0.6.0: +passport@0.6.0, passport@^0.4.0, passport@^0.6.0: version "0.6.0" resolved "https://registry.yarnpkg.com/passport/-/passport-0.6.0.tgz#e869579fab465b5c0b291e841e6cc95c005fac9d" integrity sha512-0fe+p3ZnrWRW74fe8+SvCyf4a3Pb2/h7gFkQ8yTJpAO50gDzlfjZUZTO1k5Eg9kUct22OxHLqDZoKUWRHOh9ug== @@ -18665,7 +18610,7 @@ pseudomap@^1.0.2: resolved "https://registry.yarnpkg.com/pseudomap/-/pseudomap-1.0.2.tgz#f052a28da70e618917ef0a8ac34c1ae5a68286b3" integrity sha512-b/YwNhb8lk1Zz2+bXXpS/LK9OisiZZ1SNsSLxN1x2OXVEhW2Ckr/7mWE5vrC1ZTiJlD9g19jWszTmJsB+oEpFQ== -psl@^1.1.28, psl@^1.1.33: +psl@^1.1.33: version "1.9.0" resolved "https://registry.yarnpkg.com/psl/-/psl-1.9.0.tgz#d0df2a137f00794565fcaf3b2c00cd09f8d5a5a7" integrity sha512-E/ZsdU4HLs/68gYzgGTkMicWTLPdAftJLfJFlLUAAKZGkStNU72sZjT66SnMDVOfOWY/YAoiD7Jxa9iHvngcag== @@ -19690,11 +19635,6 @@ sax@1.2.1: resolved "https://registry.yarnpkg.com/sax/-/sax-1.2.1.tgz#7b8e656190b228e81a66aea748480d828cd2d37a" integrity sha512-8I2a3LovHTOpm7NV5yOyO8IHqgVsfK4+UuySrXU8YXkSRX7k6hCV9b3HrkKCr3nMpgj+0bmocaJJWpvp1oc7ZA== -sax@>=0.1.1: - version "1.3.0" - resolved "https://registry.yarnpkg.com/sax/-/sax-1.3.0.tgz#a5dbe77db3be05c9d1ee7785dbd3ea9de51593d0" - integrity sha512-0s+oAmw9zLl1V1cS9BtZN7JAd0cW5e0QH4W3LWEK6a4LaLEA2OTpGYWDY+6XasBLtz6wkm3u1xRw95mRuJ59WA== - sax@>=0.6.0: version "1.2.4" resolved "https://registry.yarnpkg.com/sax/-/sax-1.2.4.tgz#2816234e2378bddc4e5354fab5caa895df7100d9" @@ -19776,40 +19716,13 @@ semver-diff@^3.1.1: dependencies: semver "^6.3.0" -"semver@2 || 3 || 4 || 5", semver@^5.5.0, semver@^5.6.0, semver@^5.7.1: - version "5.7.2" - resolved "https://registry.yarnpkg.com/semver/-/semver-5.7.2.tgz#48d55db737c3287cd4835e17fa13feace1c41ef8" - integrity sha512-cBznnQ9KjJqU67B52RMC65CMarK2600WFnbkcaiwWq3xy/5haFJlshgnpjovMVJ+Hff49d8GEn0b87C5pDQ10g== - -semver@7.5.3, semver@^7.0.0, semver@^7.1.1, semver@^7.1.2, semver@^7.3.2, semver@^7.3.4, semver@^7.3.5, semver@^7.3.7, semver@^7.3.8, semver@^7.5.3: +"semver@2 || 3 || 4 || 5", semver@7.5.3, semver@^5.5.0, semver@^5.6.0, semver@^5.7.1, semver@^6.0.0, semver@^6.1.1, semver@^6.1.2, semver@^6.2.0, semver@^6.3.0, semver@^6.3.1, semver@^7.0.0, semver@^7.1.1, semver@^7.1.2, semver@^7.3.2, semver@^7.3.4, semver@^7.3.5, semver@^7.3.7, semver@^7.3.8, semver@^7.5.3, semver@^7.5.4, semver@~2.3.1, semver@~7.0.0: version "7.5.3" resolved "https://registry.yarnpkg.com/semver/-/semver-7.5.3.tgz#161ce8c2c6b4b3bdca6caadc9fa3317a4c4fe88e" integrity sha512-QBlUtyVk/5EeHbi7X0fw6liDZc7BBmEaSYn01fMU1OUYbf6GPsbTtd8WmnqbI20SeycoHSeiybkE/q1Q+qlThQ== dependencies: lru-cache "^6.0.0" -semver@^6.0.0, semver@^6.1.1, semver@^6.1.2, semver@^6.2.0, semver@^6.3.0, semver@^6.3.1: - version "6.3.1" - resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.1.tgz#556d2ef8689146e46dcea4bfdd095f3434dffcb4" - integrity sha512-BR7VvDCVHO+q2xBEWskxS6DJE1qRnb7DxzUrogb71CWoSficBxYsiAGd+Kl0mmq/MprG9yArRkyrQxTO6XjMzA== - -semver@^7.5.4: - version "7.6.0" - resolved "https://registry.yarnpkg.com/semver/-/semver-7.6.0.tgz#1a46a4db4bffcccd97b743b5005c8325f23d4e2d" - integrity sha512-EnwXhrlwXMk9gKu5/flx5sv/an57AkRplG3hTK68W7FRDN+k+OWBj65M7719OkA82XLBxrcX0KSHj+X5COhOVg== - dependencies: - lru-cache "^6.0.0" - -semver@~2.3.1: - version "2.3.2" - resolved "https://registry.yarnpkg.com/semver/-/semver-2.3.2.tgz#b9848f25d6cf36333073ec9ef8856d42f1233e52" - integrity sha512-abLdIKCosKfpnmhS52NCTjO4RiLspDfsn37prjzGrp9im5DPJOgh82Os92vtwGh6XdQryKI/7SREZnV+aqiXrA== - -semver@~7.0.0: - version "7.0.0" - resolved "https://registry.yarnpkg.com/semver/-/semver-7.0.0.tgz#5f3ca35761e47e05b206c6daff2cf814f0316b8e" - integrity sha512-+GB6zVA9LWh6zovYQLALHwv5rb2PHGlJi3lfiqIHxR0uuwCgefcOJc59v9fv1w8GbStwxuuqqAjI9NMAOOgq1A== - seq-queue@^0.0.5: version "0.0.5" resolved "https://registry.yarnpkg.com/seq-queue/-/seq-queue-0.0.5.tgz#d56812e1c017a6e4e7c3e3a37a1da6d78dd3c93e" @@ -21412,7 +21325,7 @@ touch@^3.1.0: dependencies: nopt "~1.0.10" -"tough-cookie@^2.3.3 || ^3.0.1 || ^4.0.0", tough-cookie@^4.0.0, tough-cookie@^4.1.2: +tough-cookie@4.1.3, "tough-cookie@^2.3.3 || ^3.0.1 || ^4.0.0", tough-cookie@^4.0.0, tough-cookie@^4.1.2, tough-cookie@~2.5.0: version "4.1.3" resolved "https://registry.yarnpkg.com/tough-cookie/-/tough-cookie-4.1.3.tgz#97b9adb0728b42280aa3d814b6b999b2ff0318bf" integrity sha512-aX/y5pVRkfRnfmuX+OdbSdXvPe6ieKX/G2s7e98f4poJHnqH3281gDPm/metm6E/WRamfx7WC4HUqkWHfQHprw== @@ -21422,14 +21335,6 @@ touch@^3.1.0: universalify "^0.2.0" url-parse "^1.5.3" -tough-cookie@~2.5.0: - version "2.5.0" - resolved "https://registry.yarnpkg.com/tough-cookie/-/tough-cookie-2.5.0.tgz#cd9fb2a0aa1d5a12b473bd9fb96fa3dcff65ade2" - integrity sha512-nlLsUzgm1kfLXSXfRZMc1KLAugd4hqJHDTvc2hDIwS3mZAfMEuMbc03SujMF+GEcpaX/qboeycw6iO8JwVv2+g== - dependencies: - psl "^1.1.28" - punycode "^2.1.1" - tr46@^2.1.0: version "2.1.0" resolved "https://registry.yarnpkg.com/tr46/-/tr46-2.1.0.tgz#fa87aa81ca5d5941da8cbf1f9b749dc969a4e240" @@ -21906,6 +21811,14 @@ unpipe@1.0.0: resolved "https://registry.yarnpkg.com/unpipe/-/unpipe-1.0.0.tgz#b2bf4ee8514aae6165b4817829d21b2ef49904ec" integrity sha512-pjy2bYhSsufwWlKwPc+l3cN7+wuJlK6uz0YdJEOlQDbl6jo/YlPi4mb8agUkVC8BF7V8NuzeyPNqRksA3hztKQ== +unset-value@2.0.1: + version "2.0.1" + resolved "https://registry.yarnpkg.com/unset-value/-/unset-value-2.0.1.tgz#57bed0c22d26f28d69acde5df9a11b77c74d2df3" + integrity sha512-2hvrBfjUE00PkqN+q0XP6yRAOGrR06uSiUoIQGZkc7GxvQ9H7v8quUPNtZjMg4uux69i8HWpIjLPUKwCuRGyNg== + dependencies: + has-value "^2.0.2" + isobject "^4.0.0" + untildify@^4.0.0: version "4.0.0" resolved "https://registry.yarnpkg.com/untildify/-/untildify-4.0.0.tgz#2bc947b953652487e4600949fb091e3ae8cd919b" @@ -22676,33 +22589,10 @@ xml-parse-from-string@^1.0.0: resolved "https://registry.yarnpkg.com/xml-parse-from-string/-/xml-parse-from-string-1.0.1.tgz#a9029e929d3dbcded169f3c6e28238d95a5d5a28" integrity sha512-ErcKwJTF54uRzzNMXq2X5sMIy88zJvfN2DmdoQvy7PAFJ+tPRU6ydWuOKNMyfmOjdyBQTFREi60s0Y0SyI0G0g== -xml2js@0.1.x: - version "0.1.14" - resolved "https://registry.yarnpkg.com/xml2js/-/xml2js-0.1.14.tgz#5274e67f5a64c5f92974cd85139e0332adc6b90c" - integrity sha512-pbdws4PPPNc1HPluSUKamY4GWMk592K7qwcj6BExbVOhhubub8+pMda/ql68b6L3luZs/OGjGSB5goV7SnmgnA== - dependencies: - sax ">=0.1.1" - -xml2js@0.4.19: - version "0.4.19" - resolved "https://registry.yarnpkg.com/xml2js/-/xml2js-0.4.19.tgz#686c20f213209e94abf0d1bcf1efaa291c7827a7" - integrity sha512-esZnJZJOiJR9wWKMyuvSE1y6Dq5LCuJanqhxslH2bxM6duahNZ+HMpCLhBQGZkbX6xRf8x1Y2eJlgt2q3qo49Q== - dependencies: - sax ">=0.6.0" - xmlbuilder "~9.0.1" - -xml2js@0.5.0: - version "0.5.0" - resolved "https://registry.yarnpkg.com/xml2js/-/xml2js-0.5.0.tgz#d9440631fbb2ed800203fad106f2724f62c493b7" - integrity sha512-drPFnkQJik/O+uPKpqSgr22mpuFHqKdbS835iAQrUC73L2F5WkboIRd63ai/2Yg6I1jzifPFKH2NTK+cfglkIA== - dependencies: - sax ">=0.6.0" - xmlbuilder "~11.0.0" - -xml2js@^0.4.19, xml2js@^0.4.5: - version "0.4.23" - resolved "https://registry.yarnpkg.com/xml2js/-/xml2js-0.4.23.tgz#a0c69516752421eb2ac758ee4d4ccf58843eac66" - integrity sha512-ySPiMjM0+pLDftHgXY4By0uswI3SPKLDw/i3UXbnO8M/p28zqexCUoPmQFrYD+/1BzhGJSs2i1ERWKJAtiLrug== +xml2js@0.1.x, xml2js@0.4.19, xml2js@0.5.0, xml2js@0.6.2, xml2js@^0.4.19, xml2js@^0.4.5: + version "0.6.2" + resolved "https://registry.yarnpkg.com/xml2js/-/xml2js-0.6.2.tgz#dd0b630083aa09c161e25a4d0901e2b2a929b499" + integrity sha512-T4rieHaC1EXcES0Kxxj4JWgaUQHDk+qwHcYOCFHfiwKz7tOVPLq7Hjq9dM1WCMhylqMEfP7hMcOIChvotiZegA== dependencies: sax ">=0.6.0" xmlbuilder "~11.0.0" @@ -22712,11 +22602,6 @@ xmlbuilder@~11.0.0: resolved "https://registry.yarnpkg.com/xmlbuilder/-/xmlbuilder-11.0.1.tgz#be9bae1c8a046e76b31127726347d0ad7002beb3" integrity sha512-fDlsI/kFEx7gLvbecc0/ohLG50fugQp8ryHzMTuW9vSa1GJ0XYWKnhsUx7oie3G98+r56aTQIUB4kht42R3JvA== -xmlbuilder@~9.0.1: - version "9.0.7" - resolved "https://registry.yarnpkg.com/xmlbuilder/-/xmlbuilder-9.0.7.tgz#132ee63d2ec5565c557e20f4c22df9aca686b10d" - integrity sha512-7YXTQc3P2l9+0rjaUbLwMKRhtmwg1M1eDf6nag7urC7pIPYLD9W/jmzQ4ptRSUbodw5S0jfoGTflLemQibSpeQ== - xmlchars@^2.2.0: version "2.2.0" resolved "https://registry.yarnpkg.com/xmlchars/-/xmlchars-2.2.0.tgz#060fe1bcb7f9c76fe2a17db86a9bc3ab894210cb" From b303592f4c05dce3f8dc19e00a423b6b52d984bd Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Mon, 25 Mar 2024 15:30:14 +0000 Subject: [PATCH 03/54] Remove content length checks. --- packages/server/src/tests/utilities/api/base.ts | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/packages/server/src/tests/utilities/api/base.ts b/packages/server/src/tests/utilities/api/base.ts index 486514cfbe..4df58ff425 100644 --- a/packages/server/src/tests/utilities/api/base.ts +++ b/packages/server/src/tests/utilities/api/base.ts @@ -187,22 +187,6 @@ export abstract class TestAPI { expect(response.body).toMatchObject(expectations.body) } - if (response.text && response.text.length > 0) { - // @ts-expect-error - we know this exists, it's just not in the types - const request = response.request as Test - const contentLength = response.headers["content-length"] - if (!contentLength) { - throw new Error( - `Failed request "${request.method} ${request.url}": Content-Length header not present, but response has a body (body length ${response.text.length})` - ) - } - if (parseInt(contentLength) !== response.text.length) { - throw new Error( - `Failed request "${request.method} ${request.url}": Content-Length header does not match response body length (header: ${contentLength}, body: ${response.text.length})` - ) - } - } - return response } From d77b6f82e08a8c8e505791da8240e6e56706cbee Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Mon, 25 Mar 2024 15:42:45 +0000 Subject: [PATCH 04/54] remove jestTestcontainersConfigGenerator.js --- jestTestcontainersConfigGenerator.js | 16 ---- packages/pro | 2 +- yarn.lock | 126 +-------------------------- 3 files changed, 5 insertions(+), 139 deletions(-) delete mode 100644 jestTestcontainersConfigGenerator.js diff --git a/jestTestcontainersConfigGenerator.js b/jestTestcontainersConfigGenerator.js deleted file mode 100644 index 82d50145e6..0000000000 --- a/jestTestcontainersConfigGenerator.js +++ /dev/null @@ -1,16 +0,0 @@ -module.exports = () => { - return { - couchdb: { - image: "budibase/couchdb", - ports: [5984], - env: { - COUCHDB_PASSWORD: "budibase", - COUCHDB_USER: "budibase", - }, - wait: { - type: "ports", - timeout: 20000, - }, - }, - } -} diff --git a/packages/pro b/packages/pro index dd748e045f..dad97ea682 160000 --- a/packages/pro +++ b/packages/pro @@ -1 +1 @@ -Subproject commit dd748e045ffdbc6662c5d2b76075f01d65a96a2f +Subproject commit dad97ea682195704eb65fefdc604f62606360ea7 diff --git a/yarn.lock b/yarn.lock index 585e043593..6acdcce3b6 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5098,15 +5098,6 @@ resolved "https://registry.yarnpkg.com/@tootallnate/once/-/once-2.0.0.tgz#f544a148d3ab35801c1f633a7441fd87c2e484bf" integrity sha512-XCuKFP5PS55gnMVu3dty8KPatLqUoy/ZYzDzAGCQ8JNFCkLXzmI7vNHCR+XpbZaMWQK/vQubr7PkYq8g470J/A== -"@trendyol/jest-testcontainers@2.1.1": - version "2.1.1" - resolved "https://registry.yarnpkg.com/@trendyol/jest-testcontainers/-/jest-testcontainers-2.1.1.tgz#dced95cf9c37b75efe0a65db9b75ae8912f2f14a" - integrity sha512-4iAc2pMsev4BTUzoA7jO1VvbTOU2N3juQUYa8TwiSPXPuQtxKwV9WB9ZEP+JQ+Pj15YqfGOXp5H0WNMPtapjiA== - dependencies: - cwd "^0.10.0" - node-duration "^1.0.4" - testcontainers "4.7.0" - "@trysound/sax@0.2.0": version "0.2.0" resolved "https://registry.yarnpkg.com/@trysound/sax/-/sax-0.2.0.tgz#cccaab758af56761eb7bf37af6f03f326dd798ad" @@ -5296,13 +5287,6 @@ "@types/node" "*" "@types/ssh2" "*" -"@types/dockerode@^2.5.34": - version "2.5.34" - resolved "https://registry.yarnpkg.com/@types/dockerode/-/dockerode-2.5.34.tgz#9adb884f7cc6c012a6eb4b2ad794cc5d01439959" - integrity sha512-LcbLGcvcBwBAvjH9UrUI+4qotY+A5WCer5r43DR5XHv2ZIEByNXFdPLo1XxR+v/BjkGjlggW8qUiXuVEhqfkpA== - dependencies: - "@types/node" "*" - "@types/dockerode@^3.3.24": version "3.3.24" resolved "https://registry.yarnpkg.com/@types/dockerode/-/dockerode-3.3.24.tgz#bea354a4fcd0824a80fd5ea5ede3e8cda71137a7" @@ -9140,14 +9124,6 @@ curlconverter@3.21.0: string.prototype.startswith "^1.0.0" yamljs "^0.3.0" -cwd@^0.10.0: - version "0.10.0" - resolved "https://registry.yarnpkg.com/cwd/-/cwd-0.10.0.tgz#172400694057c22a13b0cf16162c7e4b7a7fe567" - integrity sha512-YGZxdTTL9lmLkCUTpg4j0zQ7IhRB5ZmqNBbGCl3Tg6MP/d5/6sY7L5mmTjzbc6JKgVZYiqTQTNhPFsbXNGlRaA== - dependencies: - find-pkg "^0.1.2" - fs-exists-sync "^0.1.0" - dargs@^7.0.0: version "7.0.0" resolved "https://registry.yarnpkg.com/dargs/-/dargs-7.0.0.tgz#04015c41de0bcb69ec84050f3d9be0caf8d6d5cc" @@ -9769,7 +9745,7 @@ docker-compose@0.24.0: dependencies: yaml "^1.10.2" -docker-compose@^0.23.5, docker-compose@^0.23.6: +docker-compose@^0.23.6: version "0.23.19" resolved "https://registry.yarnpkg.com/docker-compose/-/docker-compose-0.23.19.tgz#9947726e2fe67bdfa9e8efe1ff15aa0de2e10eb8" integrity sha512-v5vNLIdUqwj4my80wxFDkNH+4S85zsRuH29SO7dCWVWPCMt/ohZBsGN6g6KXWifT0pzQ7uOxqEKCYCDPJ8Vz4g== @@ -9793,15 +9769,6 @@ docker-modem@^3.0.0: split-ca "^1.0.1" ssh2 "^1.11.0" -dockerode@^3.2.1: - version "3.3.4" - resolved "https://registry.yarnpkg.com/dockerode/-/dockerode-3.3.4.tgz#875de614a1be797279caa9fe27e5637cf0e40548" - integrity sha512-3EUwuXnCU+RUlQEheDjmBE0B7q66PV9Rw5NiH1sXwINq0M9c5ERP9fxgkw36ZHOtzf4AGEEYySnkx/sACC9EgQ== - dependencies: - "@balena/dockerignore" "^1.0.2" - docker-modem "^3.0.0" - tar-fs "~2.0.1" - dockerode@^3.3.5: version "3.3.5" resolved "https://registry.yarnpkg.com/dockerode/-/dockerode-3.3.5.tgz#7ae3f40f2bec53ae5e9a741ce655fff459745629" @@ -10827,13 +10794,6 @@ expand-template@^2.0.3: resolved "https://registry.yarnpkg.com/expand-template/-/expand-template-2.0.3.tgz#6e14b3fcee0f3a6340ecb57d2e8918692052a47c" integrity sha512-XYfuKMvj4O35f/pOXLObndIRvyQ+/+6AhODh+OKWj9S9498pHHn/IMszH+gt0fBCRWMNfk1ZSp5x3AifmnI2vg== -expand-tilde@^1.2.2: - version "1.2.2" - resolved "https://registry.yarnpkg.com/expand-tilde/-/expand-tilde-1.2.2.tgz#0b81eba897e5a3d31d1c3d102f8f01441e559449" - integrity sha512-rtmc+cjLZqnu9dSYosX9EWmSJhTwpACgJQTfj4hgg2JjOD/6SIQalZrt4a3aQeh++oNxkazcaxrhPUj6+g5G/Q== - dependencies: - os-homedir "^1.0.1" - expand-tilde@^2.0.2: version "2.0.2" resolved "https://registry.yarnpkg.com/expand-tilde/-/expand-tilde-2.0.2.tgz#97e801aa052df02454de46b02bf621642cdc8502" @@ -11172,26 +11132,11 @@ filter-obj@^1.1.0: resolved "https://registry.yarnpkg.com/filter-obj/-/filter-obj-1.1.0.tgz#9b311112bc6c6127a16e016c6c5d7f19e0805c5b" integrity sha512-8rXg1ZnX7xzy2NGDVkBVaAy+lSlPNwad13BtgSlLuxfIslyt5Vg64U7tFcCt4WS1R0hvtnQybT/IyCkGZ3DpXQ== -find-file-up@^0.1.2: - version "0.1.3" - resolved "https://registry.yarnpkg.com/find-file-up/-/find-file-up-0.1.3.tgz#cf68091bcf9f300a40da411b37da5cce5a2fbea0" - integrity sha512-mBxmNbVyjg1LQIIpgO8hN+ybWBgDQK8qjht+EbrTCGmmPV/sc7RF1i9stPTD6bpvXZywBdrwRYxhSdJv867L6A== - dependencies: - fs-exists-sync "^0.1.0" - resolve-dir "^0.1.0" - find-free-port@^2.0.0: version "2.0.0" resolved "https://registry.yarnpkg.com/find-free-port/-/find-free-port-2.0.0.tgz#4b22e5f6579eb1a38c41ac6bcb3efed1b6da9b1b" integrity sha512-J1j8gfEVf5FN4PR5w5wrZZ7NYs2IvqsHcd03cAeQx3Ec/mo+lKceaVNhpsRKoZpZKbId88o8qh+dwUwzBV6WCg== -find-pkg@^0.1.2: - version "0.1.2" - resolved "https://registry.yarnpkg.com/find-pkg/-/find-pkg-0.1.2.tgz#1bdc22c06e36365532e2a248046854b9788da557" - integrity sha512-0rnQWcFwZr7eO0513HahrWafsc3CTFioEB7DRiEYCUM/70QXSY8f3mCST17HXLcPvEhzH/Ty/Bxd72ZZsr/yvw== - dependencies: - find-file-up "^0.1.2" - find-up@^2.0.0: version "2.1.0" resolved "https://registry.yarnpkg.com/find-up/-/find-up-2.1.0.tgz#45d1b7e506c717ddd482775a2b77920a3c0c57a7" @@ -11359,11 +11304,6 @@ fs-constants@^1.0.0: resolved "https://registry.yarnpkg.com/fs-constants/-/fs-constants-1.0.0.tgz#6be0de9be998ce16af8afc24497b9ee9b7ccd9ad" integrity sha512-y6OAwoSIf7FyjMIv94u+b5rdheZEjzR63GTyZJm5qh4Bi+2YgwLCcI/fPFZkL5PSixOt6ZNKm+w+Hfp/Bciwow== -fs-exists-sync@^0.1.0: - version "0.1.0" - resolved "https://registry.yarnpkg.com/fs-exists-sync/-/fs-exists-sync-0.1.0.tgz#982d6893af918e72d08dec9e8673ff2b5a8d6add" - integrity sha512-cR/vflFyPZtrN6b38ZyWxpWdhlXrzZEBawlpBQMq7033xVY7/kg0GDMBK5jg8lDYQckdJ5x/YC88lM3C7VMsLg== - fs-extra@^10.0.0: version "10.1.0" resolved "https://registry.yarnpkg.com/fs-extra/-/fs-extra-10.1.0.tgz#02873cfbc4084dde127eaa5f9905eef2325d1abf" @@ -11860,24 +11800,6 @@ global-dirs@^3.0.0: dependencies: ini "2.0.0" -global-modules@^0.2.3: - version "0.2.3" - resolved "https://registry.yarnpkg.com/global-modules/-/global-modules-0.2.3.tgz#ea5a3bed42c6d6ce995a4f8a1269b5dae223828d" - integrity sha512-JeXuCbvYzYXcwE6acL9V2bAOeSIGl4dD+iwLY9iUx2VBJJ80R18HCn+JCwHM9Oegdfya3lEkGCdaRkSyc10hDA== - dependencies: - global-prefix "^0.1.4" - is-windows "^0.2.0" - -global-prefix@^0.1.4: - version "0.1.5" - resolved "https://registry.yarnpkg.com/global-prefix/-/global-prefix-0.1.5.tgz#8d3bc6b8da3ca8112a160d8d496ff0462bfef78f" - integrity sha512-gOPiyxcD9dJGCEArAhF4Hd0BAqvAe/JzERP7tYumE4yIkmIedPUVXcJFWbV3/p/ovIIvKjkrTk+f1UVkq7vvbw== - dependencies: - homedir-polyfill "^1.0.0" - ini "^1.3.4" - is-windows "^0.2.0" - which "^1.2.12" - global@~4.4.0: version "4.4.0" resolved "https://registry.yarnpkg.com/global/-/global-4.4.0.tgz#3e7b105179006a323ed71aafca3e9c57a5cc6406" @@ -12308,7 +12230,7 @@ hmac-drbg@^1.0.1: minimalistic-assert "^1.0.0" minimalistic-crypto-utils "^1.0.1" -homedir-polyfill@^1.0.0, homedir-polyfill@^1.0.1: +homedir-polyfill@^1.0.1: version "1.0.3" resolved "https://registry.yarnpkg.com/homedir-polyfill/-/homedir-polyfill-1.0.3.tgz#743298cef4e5af3e194161fbadcc2151d3a058e8" integrity sha512-eSmmWE5bZTK2Nou4g0AI3zZ9rswp7GRKoKXS1BLUkvPviOqs4YTN1djQIqrXy9k5gEtdLPy86JjRwsNM9tnDcA== @@ -13282,11 +13204,6 @@ is-whitespace@^0.3.0: resolved "https://registry.yarnpkg.com/is-whitespace/-/is-whitespace-0.3.0.tgz#1639ecb1be036aec69a54cbb401cfbed7114ab7f" integrity sha512-RydPhl4S6JwAyj0JJjshWJEFG6hNye3pZFBRZaTUfZFwGHxzppNaNOVgQuS/E/SlhrApuMXrpnK1EEIXfdo3Dg== -is-windows@^0.2.0: - version "0.2.0" - resolved "https://registry.yarnpkg.com/is-windows/-/is-windows-0.2.0.tgz#de1aa6d63ea29dd248737b69f1ff8b8002d2108c" - integrity sha512-n67eJYmXbniZB7RF4I/FTjK1s6RPOCTxhYrVYLRaCt3lF0mpWZPKr3T2LSZAqyjQsxR2qMmGYXXzK0YWwcPM1Q== - is-wsl@^2.1.1, is-wsl@^2.2.0: version "2.2.0" resolved "https://registry.yarnpkg.com/is-wsl/-/is-wsl-2.2.0.tgz#74a4c76e77ca9fd3f932f290c17ea326cd157271" @@ -16149,11 +16066,6 @@ node-addon-api@^6.1.0: resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-6.1.0.tgz#ac8470034e58e67d0c6f1204a18ae6995d9c0d76" integrity sha512-+eawOlIgy680F0kBzPUNFhMZGtJ1YmqM6l4+Crf4IkImjYrO/mqPwRMh352g23uIaQKFItcQ64I7KMaJxHgAVA== -node-duration@^1.0.4: - version "1.0.4" - resolved "https://registry.yarnpkg.com/node-duration/-/node-duration-1.0.4.tgz#3e94ecc0e473691c89c4560074503362071cecac" - integrity sha512-eUXYNSY7DL53vqfTosggWkvyIW3bhAcqBDIlolgNYlZhianXTrCL50rlUJWD1eRqkIxMppXTfiFbp+9SjpPrgA== - node-fetch@2.6.0, node-fetch@2.6.7, node-fetch@^2.6.0, node-fetch@^2.6.1, node-fetch@^2.6.7, node-fetch@^2.6.9, node-fetch@^2.7.0: version "2.6.7" resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.7.tgz#24de9fba827e3b4ae44dc8b20256a379160052ad" @@ -16900,11 +16812,6 @@ oracledb@5.3.0: resolved "https://registry.yarnpkg.com/oracledb/-/oracledb-5.3.0.tgz#a15e6cd16757d8711a2c006a28bd7ecd3b8466f7" integrity sha512-HMJzQ6lCf287ztvvehTEmjCWA21FQ3RMvM+mgoqd4i8pkREuqFWO+y3ovsGR9moJUg4T0xjcwS8rl4mggWPxmg== -os-homedir@^1.0.1: - version "1.0.2" - resolved "https://registry.yarnpkg.com/os-homedir/-/os-homedir-1.0.2.tgz#ffbc4988336e0e833de0c168c7ef152121aa7fb3" - integrity sha512-B5JU3cabzk8c67mRRd3ECmROafjYMXbuzlwtqdM8IbS8ktlTix8aFGb2bAGKrSRIlnfKwovGUUr72JUPyOb6kQ== - os-locale@^3.1.0: version "3.1.0" resolved "https://registry.yarnpkg.com/os-locale/-/os-locale-3.1.0.tgz#a802a6ee17f24c10483ab9935719cef4ed16bf1a" @@ -19223,14 +19130,6 @@ resolve-dependency-path@^2.0.0: resolved "https://registry.yarnpkg.com/resolve-dependency-path/-/resolve-dependency-path-2.0.0.tgz#11700e340717b865d216c66cabeb4a2a3c696736" integrity sha512-DIgu+0Dv+6v2XwRaNWnumKu7GPufBBOr5I1gRPJHkvghrfCGOooJODFvgFimX/KRxk9j0whD2MnKHzM1jYvk9w== -resolve-dir@^0.1.0: - version "0.1.1" - resolved "https://registry.yarnpkg.com/resolve-dir/-/resolve-dir-0.1.1.tgz#b219259a5602fac5c5c496ad894a6e8cc430261e" - integrity sha512-QxMPqI6le2u0dCLyiGzgy92kjkkL6zO0XyvHzjdTNH3zM6e5Hz3BwG6+aEyNgiQ5Xz6PwTwgQEj3U50dByPKIA== - dependencies: - expand-tilde "^1.2.2" - global-modules "^0.2.3" - resolve-from@5.0.0, resolve-from@^5.0.0: version "5.0.0" resolved "https://registry.yarnpkg.com/resolve-from/-/resolve-from-5.0.0.tgz#c35225843df8f776df21c57557bc087e9dfdfc69" @@ -20920,7 +20819,7 @@ tapable@^2.1.1, tapable@^2.2.0: resolved "https://registry.yarnpkg.com/tapable/-/tapable-2.2.1.tgz#1967a73ef4060a82f12ab96af86d52fdb76eeca0" integrity sha512-GNzQvQTOIP6RyTfE2Qxb8ZVlNmw0n88vp1szwWRimP02mnTsx3Wtn5qRdqY9w2XduFNUgvOwhNnQsjwCp+kqaQ== -tar-fs@2.1.1, tar-fs@^2.0.0, tar-fs@^2.1.0: +tar-fs@2.1.1, tar-fs@^2.0.0: version "2.1.1" resolved "https://registry.yarnpkg.com/tar-fs/-/tar-fs-2.1.1.tgz#489a15ab85f1f0befabb370b7de4f9eb5cbe8784" integrity sha512-V0r2Y9scmbDRLCNex/+hYzvp/zyYjvFbHPNgVTKfQvVrb6guiE/fxP+XblDNR011utopbkex2nM4dHNV6GDsng== @@ -21098,23 +20997,6 @@ testcontainers@10.7.2, testcontainers@^10.7.2: tar-fs "^3.0.5" tmp "^0.2.1" -testcontainers@4.7.0: - version "4.7.0" - resolved "https://registry.yarnpkg.com/testcontainers/-/testcontainers-4.7.0.tgz#5a9a864b1b0cc86984086dcc737c2f5e73490cf3" - integrity sha512-5SrG9RMfDRRZig34fDZeMcGD5i3lHCOJzn0kjouyK4TiEWjZB3h7kCk8524lwNRHROFE1j6DGjceonv/5hl5ag== - dependencies: - "@types/dockerode" "^2.5.34" - byline "^5.0.0" - debug "^4.1.1" - docker-compose "^0.23.5" - dockerode "^3.2.1" - get-port "^5.1.1" - glob "^7.1.6" - node-duration "^1.0.4" - slash "^3.0.0" - stream-to-array "^2.3.0" - tar-fs "^2.1.0" - text-extensions@^1.0.0: version "1.9.0" resolved "https://registry.yarnpkg.com/text-extensions/-/text-extensions-1.9.0.tgz#1853e45fee39c945ce6f6c36b2d659b5aabc2a26" @@ -22353,7 +22235,7 @@ which-typed-array@^1.1.11, which-typed-array@^1.1.13, which-typed-array@^1.1.9: gopd "^1.0.1" has-tostringtag "^1.0.0" -which@^1.2.12, which@^1.2.9: +which@^1.2.9: version "1.3.1" resolved "https://registry.yarnpkg.com/which/-/which-1.3.1.tgz#a45043d54f5805316da8d62f9f50918d3da70b0a" integrity sha512-HxJdYWq1MTIQbJ3nw0cqssHoTNU267KlrDuGZ1WYlxDStUtKUhOaJmh112/TZmHxxUfuJqPXSOm7tDyas0OSIQ== From 44d4e496b6196daab4c1cdecc0506e3ce242c400 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Mon, 25 Mar 2024 17:11:41 +0000 Subject: [PATCH 05/54] Fix code to pull CouchDB URL out of docker ps. --- .../core/utilities/testContainerUtils.ts | 111 ++++++++---------- 1 file changed, 46 insertions(+), 65 deletions(-) diff --git a/packages/backend-core/tests/core/utilities/testContainerUtils.ts b/packages/backend-core/tests/core/utilities/testContainerUtils.ts index 7da6cbc777..5d4f5a3c11 100644 --- a/packages/backend-core/tests/core/utilities/testContainerUtils.ts +++ b/packages/backend-core/tests/core/utilities/testContainerUtils.ts @@ -1,80 +1,58 @@ +import { DatabaseImpl } from "../../../src/db" import { execSync } from "child_process" -let dockerPsResult: string | undefined - -function formatDockerPsResult(serverName: string, port: number) { - const lines = dockerPsResult?.split("\n") - let first = true - if (!lines) { - return null - } - for (let line of lines) { - if (first) { - first = false - continue - } - let toLookFor = serverName.split("-service")[0] - if (!line.includes(toLookFor)) { - continue - } - const regex = new RegExp(`0.0.0.0:([0-9]*)->${port}`, "g") - const found = line.match(regex) - if (found) { - return found[0].split(":")[1].split("->")[0] - } - } - return null +interface ContainerInfo { + Command: string + CreatedAt: string + ID: string + Image: string + Labels: string + LocalVolumes: string + Mounts: string + Names: string + Networks: string + Ports: string + RunningFor: string + Size: string + State: string + Status: string } -function getTestContainerSettings( - serverName: string, - key: string -): string | null { - const entry = Object.entries(global).find( - ([k]) => - k.includes(`${serverName.toUpperCase()}`) && - k.includes(`${key.toUpperCase()}`) - ) - if (!entry) { - return null - } - return entry[1] +function getTestcontainers(): ContainerInfo[] { + return execSync("docker ps --format json") + .toString() + .split("\n") + .filter(x => x.length > 0) + .map(x => JSON.parse(x) as ContainerInfo) + .filter(x => x.Labels.includes("org.testcontainers=true")) } -function getContainerInfo(containerName: string, port: number) { - let assignedPort = getTestContainerSettings( - containerName.toUpperCase(), - `PORT_${port}` - ) - if (!dockerPsResult) { - try { - const outputBuffer = execSync("docker ps") - dockerPsResult = outputBuffer.toString("utf8") - } catch (err) { - //no-op - } - } - const possiblePort = formatDockerPsResult(containerName, port) - if (possiblePort) { - assignedPort = possiblePort - } - const host = getTestContainerSettings(containerName.toUpperCase(), "IP") - return { - port: assignedPort, - host, - url: host && assignedPort && `http://${host}:${assignedPort}`, - } +function getContainerByImage(image: string) { + return getTestcontainers().find(x => x.Image.startsWith(image)) } -function getCouchConfig() { - return getContainerInfo("couchdb", 5984) +function getExposedPort(container: ContainerInfo, port: number) { + const match = container.Ports.match(new RegExp(`0.0.0.0:(\\d+)->${port}/tcp`)) + if (!match) { + return undefined + } + return parseInt(match[1]) } export function setupEnv(...envs: any[]) { - const couch = getCouchConfig() + const couch = getContainerByImage("budibase/couchdb") + if (!couch) { + throw new Error("CouchDB container not found") + } + + const couchPort = getExposedPort(couch, 5984) + if (!couchPort) { + throw new Error("CouchDB port not found") + } + const configs = [ - { key: "COUCH_DB_PORT", value: couch.port }, - { key: "COUCH_DB_URL", value: couch.url }, + { key: "COUCH_DB_PORT", value: `${couchPort}` }, + { key: "COUCH_DB_URL", value: `http://localhost:${couchPort}` }, ] for (const config of configs.filter(x => !!x.value)) { @@ -82,4 +60,7 @@ export function setupEnv(...envs: any[]) { env._set(config.key, config.value) } } + + // @ts-expect-error + DatabaseImpl.nano = undefined } From 4a080e7069aa9ee88248c1e159bf8461f1d2cdde Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Mon, 25 Mar 2024 17:12:40 +0000 Subject: [PATCH 06/54] Pull newer version of ryuk. --- .github/workflows/budibase_ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/budibase_ci.yml b/.github/workflows/budibase_ci.yml index 94a001ba96..36ea2f5448 100644 --- a/.github/workflows/budibase_ci.yml +++ b/.github/workflows/budibase_ci.yml @@ -161,7 +161,7 @@ jobs: docker pull postgres:16.1-bullseye docker pull mongo:7.0-jammy docker pull mariadb:lts - docker pull testcontainers/ryuk:0.3.0 + docker pull testcontainers/ryuk:0.5.1 docker pull budibase/couchdb - run: yarn --frozen-lockfile From f68840a580ab8345091df4143b5180629a1bb522 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Mon, 25 Mar 2024 17:13:04 +0000 Subject: [PATCH 07/54] Remove testcontainers debug logging. --- packages/server/scripts/test.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/server/scripts/test.sh b/packages/server/scripts/test.sh index 58e68c9749..3ecf8bb794 100644 --- a/packages/server/scripts/test.sh +++ b/packages/server/scripts/test.sh @@ -1,8 +1,6 @@ #!/bin/bash set -e -export DEBUG="testcontainers*" - if [[ -n $CI ]] then export NODE_OPTIONS="--max-old-space-size=4096 --no-node-snapshot $NODE_OPTIONS" From 0dba0cebc752ae9208db9c15fb3f47dc372ed44e Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Mon, 25 Mar 2024 17:26:15 +0000 Subject: [PATCH 08/54] Remove CouchDB container name. --- packages/backend-core/src/tests/globalSetup.ts | 1 - packages/pro | 2 +- packages/server/src/tests/globalSetup.ts | 1 - packages/worker/src/tests/globalSetup.ts | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/backend-core/src/tests/globalSetup.ts b/packages/backend-core/src/tests/globalSetup.ts index 1bb61a79d9..fd9cd8e020 100644 --- a/packages/backend-core/src/tests/globalSetup.ts +++ b/packages/backend-core/src/tests/globalSetup.ts @@ -2,7 +2,6 @@ import { GenericContainer, Wait } from "testcontainers" export default async function setup() { const container = await new GenericContainer("budibase/couchdb") - .withName("couchdb-service") .withExposedPorts(5984) .withEnvironment({ COUCHDB_PASSWORD: "budibase", diff --git a/packages/pro b/packages/pro index dad97ea682..7c42874509 160000 --- a/packages/pro +++ b/packages/pro @@ -1 +1 @@ -Subproject commit dad97ea682195704eb65fefdc604f62606360ea7 +Subproject commit 7c42874509cfdc98580994addaaaa8296f3e92de diff --git a/packages/server/src/tests/globalSetup.ts b/packages/server/src/tests/globalSetup.ts index 1bb61a79d9..fd9cd8e020 100644 --- a/packages/server/src/tests/globalSetup.ts +++ b/packages/server/src/tests/globalSetup.ts @@ -2,7 +2,6 @@ import { GenericContainer, Wait } from "testcontainers" export default async function setup() { const container = await new GenericContainer("budibase/couchdb") - .withName("couchdb-service") .withExposedPorts(5984) .withEnvironment({ COUCHDB_PASSWORD: "budibase", diff --git a/packages/worker/src/tests/globalSetup.ts b/packages/worker/src/tests/globalSetup.ts index 1bb61a79d9..fd9cd8e020 100644 --- a/packages/worker/src/tests/globalSetup.ts +++ b/packages/worker/src/tests/globalSetup.ts @@ -2,7 +2,6 @@ import { GenericContainer, Wait } from "testcontainers" export default async function setup() { const container = await new GenericContainer("budibase/couchdb") - .withName("couchdb-service") .withExposedPorts(5984) .withEnvironment({ COUCHDB_PASSWORD: "budibase", From afacee978d082db56dc6ba836acb02875bec5d29 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Mon, 25 Mar 2024 17:40:46 +0000 Subject: [PATCH 09/54] Add missing environment vars for backend-core tests. --- packages/backend-core/tests/jestEnv.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/backend-core/tests/jestEnv.ts b/packages/backend-core/tests/jestEnv.ts index bfeb3eca72..2c797c9fff 100644 --- a/packages/backend-core/tests/jestEnv.ts +++ b/packages/backend-core/tests/jestEnv.ts @@ -6,3 +6,5 @@ process.env.LOG_LEVEL = process.env.LOG_LEVEL || "error" process.env.REDIS_PASSWORD = "budibase" process.env.COUCH_DB_PASSWORD = "budibase" process.env.COUCH_DB_USER = "budibase" +process.env.API_ENCRYPTION_KEY = "testsecret" +process.env.JWT_SECRET = "testsecret" From f3e9e3d35ee49d0a98e847cee35a47e39b7966d2 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Tue, 26 Mar 2024 09:49:33 +0000 Subject: [PATCH 10/54] Share a single globalSetup/globalTeardown. --- .../tests/globalSetup.ts => globalSetup.ts | 3 +-- .../globalTeardown.ts => globalTeardown.ts | 0 packages/server/jest.config.ts | 4 +-- packages/server/scripts/test.sh | 2 ++ packages/server/src/tests/globalSetup.ts | 26 ------------------- packages/server/src/tests/globalTeardown.ts | 12 --------- packages/worker/src/tests/globalSetup.ts | 26 ------------------- packages/worker/src/tests/globalTeardown.ts | 12 --------- .../test-couchdb.ini => test-couchdb.ini | 0 9 files changed, 5 insertions(+), 80 deletions(-) rename packages/backend-core/src/tests/globalSetup.ts => globalSetup.ts (90%) rename packages/backend-core/src/tests/globalTeardown.ts => globalTeardown.ts (100%) delete mode 100644 packages/server/src/tests/globalSetup.ts delete mode 100644 packages/server/src/tests/globalTeardown.ts delete mode 100644 packages/worker/src/tests/globalSetup.ts delete mode 100644 packages/worker/src/tests/globalTeardown.ts rename packages/server/src/tests/test-couchdb.ini => test-couchdb.ini (100%) diff --git a/packages/backend-core/src/tests/globalSetup.ts b/globalSetup.ts similarity index 90% rename from packages/backend-core/src/tests/globalSetup.ts rename to globalSetup.ts index fd9cd8e020..f110bd5cd4 100644 --- a/packages/backend-core/src/tests/globalSetup.ts +++ b/globalSetup.ts @@ -9,7 +9,7 @@ export default async function setup() { }) .withCopyFilesToContainer([ { - source: "./src/tests/test-couchdb.ini", + source: "./test-couchdb.ini", target: "/opt/couchdb/etc/local.d/test-couchdb.ini", }, ]) @@ -20,7 +20,6 @@ export default async function setup() { ) .start() - // @ts-expect-error // eslint-disable-next-line no-undef globalThis.__COUCHDB_CONTAINER_ID__ = container.getId() } diff --git a/packages/backend-core/src/tests/globalTeardown.ts b/globalTeardown.ts similarity index 100% rename from packages/backend-core/src/tests/globalTeardown.ts rename to globalTeardown.ts diff --git a/packages/server/jest.config.ts b/packages/server/jest.config.ts index 5795bedca5..bad03f045c 100644 --- a/packages/server/jest.config.ts +++ b/packages/server/jest.config.ts @@ -17,8 +17,8 @@ const baseConfig: Config.InitialProjectOptions = { "svelte", ], setupFilesAfterEnv: ["./src/tests/jestSetup.ts"], - globalSetup: "./src/tests/globalSetup.ts", - globalTeardown: "./src/tests/globalTeardown.ts", + globalSetup: "./../../globalSetup.ts", + globalTeardown: "./../../globalTeardown.ts", transform: { "^.+\\.ts?$": "@swc/jest", "^.+\\.js?$": "@swc/jest", diff --git a/packages/server/scripts/test.sh b/packages/server/scripts/test.sh index 3ecf8bb794..c9f063c409 100644 --- a/packages/server/scripts/test.sh +++ b/packages/server/scripts/test.sh @@ -1,6 +1,8 @@ #!/bin/bash set -e +export DEBUG=testcontainers* + if [[ -n $CI ]] then export NODE_OPTIONS="--max-old-space-size=4096 --no-node-snapshot $NODE_OPTIONS" diff --git a/packages/server/src/tests/globalSetup.ts b/packages/server/src/tests/globalSetup.ts deleted file mode 100644 index fd9cd8e020..0000000000 --- a/packages/server/src/tests/globalSetup.ts +++ /dev/null @@ -1,26 +0,0 @@ -import { GenericContainer, Wait } from "testcontainers" - -export default async function setup() { - const container = await new GenericContainer("budibase/couchdb") - .withExposedPorts(5984) - .withEnvironment({ - COUCHDB_PASSWORD: "budibase", - COUCHDB_USER: "budibase", - }) - .withCopyFilesToContainer([ - { - source: "./src/tests/test-couchdb.ini", - target: "/opt/couchdb/etc/local.d/test-couchdb.ini", - }, - ]) - .withWaitStrategy( - Wait.forSuccessfulCommand( - "curl http://budibase:budibase@localhost:5984/_up" - ).withStartupTimeout(20000) - ) - .start() - - // @ts-expect-error - // eslint-disable-next-line no-undef - globalThis.__COUCHDB_CONTAINER_ID__ = container.getId() -} diff --git a/packages/server/src/tests/globalTeardown.ts b/packages/server/src/tests/globalTeardown.ts deleted file mode 100644 index 4be959c1f9..0000000000 --- a/packages/server/src/tests/globalTeardown.ts +++ /dev/null @@ -1,12 +0,0 @@ -import { getContainerRuntimeClient } from "testcontainers" - -export default async function teardown() { - const client = await getContainerRuntimeClient() - - // @ts-expect-error - // eslint-disable-next-line no-undef - const containerId = globalThis.__COUCHDB_CONTAINER_ID__ - const container = client.container.getById(containerId) - await client.container.stop(container) - await client.container.remove(container) -} diff --git a/packages/worker/src/tests/globalSetup.ts b/packages/worker/src/tests/globalSetup.ts deleted file mode 100644 index fd9cd8e020..0000000000 --- a/packages/worker/src/tests/globalSetup.ts +++ /dev/null @@ -1,26 +0,0 @@ -import { GenericContainer, Wait } from "testcontainers" - -export default async function setup() { - const container = await new GenericContainer("budibase/couchdb") - .withExposedPorts(5984) - .withEnvironment({ - COUCHDB_PASSWORD: "budibase", - COUCHDB_USER: "budibase", - }) - .withCopyFilesToContainer([ - { - source: "./src/tests/test-couchdb.ini", - target: "/opt/couchdb/etc/local.d/test-couchdb.ini", - }, - ]) - .withWaitStrategy( - Wait.forSuccessfulCommand( - "curl http://budibase:budibase@localhost:5984/_up" - ).withStartupTimeout(20000) - ) - .start() - - // @ts-expect-error - // eslint-disable-next-line no-undef - globalThis.__COUCHDB_CONTAINER_ID__ = container.getId() -} diff --git a/packages/worker/src/tests/globalTeardown.ts b/packages/worker/src/tests/globalTeardown.ts deleted file mode 100644 index 4be959c1f9..0000000000 --- a/packages/worker/src/tests/globalTeardown.ts +++ /dev/null @@ -1,12 +0,0 @@ -import { getContainerRuntimeClient } from "testcontainers" - -export default async function teardown() { - const client = await getContainerRuntimeClient() - - // @ts-expect-error - // eslint-disable-next-line no-undef - const containerId = globalThis.__COUCHDB_CONTAINER_ID__ - const container = client.container.getById(containerId) - await client.container.stop(container) - await client.container.remove(container) -} diff --git a/packages/server/src/tests/test-couchdb.ini b/test-couchdb.ini similarity index 100% rename from packages/server/src/tests/test-couchdb.ini rename to test-couchdb.ini From 5d7cd511b5b084f728660815ddd01777516ab2cf Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Tue, 26 Mar 2024 09:51:10 +0000 Subject: [PATCH 11/54] Correct path to global functions in jest.config.ts. --- packages/backend-core/jest.config.ts | 4 ++-- packages/worker/jest.config.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/backend-core/jest.config.ts b/packages/backend-core/jest.config.ts index 83e87a6f7a..fd60caf551 100644 --- a/packages/backend-core/jest.config.ts +++ b/packages/backend-core/jest.config.ts @@ -2,8 +2,8 @@ import { Config } from "@jest/types" const baseConfig: Config.InitialProjectOptions = { setupFiles: ["./tests/jestEnv.ts"], - globalSetup: "./src/tests/globalSetup.ts", - globalTeardown: "./src/tests/globalTeardown.ts", + globalSetup: "./../../globalSetup.ts", + globalTeardown: "./../../globalTeardown.ts", setupFilesAfterEnv: ["./tests/jestSetup.ts"], transform: { "^.+\\.ts?$": "@swc/jest", diff --git a/packages/worker/jest.config.ts b/packages/worker/jest.config.ts index b227ee1309..9113df0664 100644 --- a/packages/worker/jest.config.ts +++ b/packages/worker/jest.config.ts @@ -2,8 +2,8 @@ import { Config } from "@jest/types" import * as fs from "fs" const config: Config.InitialOptions = { - globalSetup: "./src/tests/globalSetup.ts", - globalTeardown: "./src/tests/globalTeardown.ts", + globalSetup: "./../../globalSetup.ts", + globalTeardown: "./../../globalTeardown.ts", setupFiles: ["./src/tests/jestEnv.ts"], setupFilesAfterEnv: ["./src/tests/jestSetup.ts"], collectCoverageFrom: ["src/**/*.{js,ts}", "../backend-core/src/**/*.{js,ts}"], From d85db6b8feed9ab331308f13bd55da1a84e1434c Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Tue, 26 Mar 2024 09:51:42 +0000 Subject: [PATCH 12/54] Update pro reference. --- packages/pro | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pro b/packages/pro index 7c42874509..69090a6771 160000 --- a/packages/pro +++ b/packages/pro @@ -1 +1 @@ -Subproject commit 7c42874509cfdc98580994addaaaa8296f3e92de +Subproject commit 69090a67715e76f3f22fcb4f605ca0fd328269bc From e5c7e653e4d6195b2f49c8685e67131826256fc1 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Tue, 26 Mar 2024 09:58:40 +0000 Subject: [PATCH 13/54] Better CouchDB config passing. --- globalSetup.ts | 8 ++++++-- test-couchdb.ini | 2 -- 2 files changed, 6 insertions(+), 4 deletions(-) delete mode 100644 test-couchdb.ini diff --git a/globalSetup.ts b/globalSetup.ts index f110bd5cd4..94dec3ca77 100644 --- a/globalSetup.ts +++ b/globalSetup.ts @@ -7,9 +7,12 @@ export default async function setup() { COUCHDB_PASSWORD: "budibase", COUCHDB_USER: "budibase", }) - .withCopyFilesToContainer([ + .withCopyContentToContainer([ { - source: "./test-couchdb.ini", + content: ` + [log] + level = warn + `, target: "/opt/couchdb/etc/local.d/test-couchdb.ini", }, ]) @@ -20,6 +23,7 @@ export default async function setup() { ) .start() + // @ts-ignore // eslint-disable-next-line no-undef globalThis.__COUCHDB_CONTAINER_ID__ = container.getId() } diff --git a/test-couchdb.ini b/test-couchdb.ini deleted file mode 100644 index 8924e6ec3f..0000000000 --- a/test-couchdb.ini +++ /dev/null @@ -1,2 +0,0 @@ -[log] -level = warn \ No newline at end of file From 415b27a0086370dfb51846ede27be3b8d6dc2e4a Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Tue, 26 Mar 2024 10:00:34 +0000 Subject: [PATCH 14/54] Don't need a globalTeardown, testcontainers handles the removal of containers. --- globalSetup.ts | 6 +----- globalTeardown.ts | 12 ------------ packages/backend-core/jest.config.ts | 1 - packages/server/jest.config.ts | 1 - packages/worker/jest.config.ts | 1 - 5 files changed, 1 insertion(+), 20 deletions(-) delete mode 100644 globalTeardown.ts diff --git a/globalSetup.ts b/globalSetup.ts index 94dec3ca77..4cb542a3c3 100644 --- a/globalSetup.ts +++ b/globalSetup.ts @@ -1,7 +1,7 @@ import { GenericContainer, Wait } from "testcontainers" export default async function setup() { - const container = await new GenericContainer("budibase/couchdb") + await new GenericContainer("budibase/couchdb") .withExposedPorts(5984) .withEnvironment({ COUCHDB_PASSWORD: "budibase", @@ -22,8 +22,4 @@ export default async function setup() { ).withStartupTimeout(20000) ) .start() - - // @ts-ignore - // eslint-disable-next-line no-undef - globalThis.__COUCHDB_CONTAINER_ID__ = container.getId() } diff --git a/globalTeardown.ts b/globalTeardown.ts deleted file mode 100644 index 4be959c1f9..0000000000 --- a/globalTeardown.ts +++ /dev/null @@ -1,12 +0,0 @@ -import { getContainerRuntimeClient } from "testcontainers" - -export default async function teardown() { - const client = await getContainerRuntimeClient() - - // @ts-expect-error - // eslint-disable-next-line no-undef - const containerId = globalThis.__COUCHDB_CONTAINER_ID__ - const container = client.container.getById(containerId) - await client.container.stop(container) - await client.container.remove(container) -} diff --git a/packages/backend-core/jest.config.ts b/packages/backend-core/jest.config.ts index fd60caf551..c944b0d7e1 100644 --- a/packages/backend-core/jest.config.ts +++ b/packages/backend-core/jest.config.ts @@ -3,7 +3,6 @@ import { Config } from "@jest/types" const baseConfig: Config.InitialProjectOptions = { setupFiles: ["./tests/jestEnv.ts"], globalSetup: "./../../globalSetup.ts", - globalTeardown: "./../../globalTeardown.ts", setupFilesAfterEnv: ["./tests/jestSetup.ts"], transform: { "^.+\\.ts?$": "@swc/jest", diff --git a/packages/server/jest.config.ts b/packages/server/jest.config.ts index bad03f045c..85c75f9039 100644 --- a/packages/server/jest.config.ts +++ b/packages/server/jest.config.ts @@ -18,7 +18,6 @@ const baseConfig: Config.InitialProjectOptions = { ], setupFilesAfterEnv: ["./src/tests/jestSetup.ts"], globalSetup: "./../../globalSetup.ts", - globalTeardown: "./../../globalTeardown.ts", transform: { "^.+\\.ts?$": "@swc/jest", "^.+\\.js?$": "@swc/jest", diff --git a/packages/worker/jest.config.ts b/packages/worker/jest.config.ts index 9113df0664..f6ff7e7c95 100644 --- a/packages/worker/jest.config.ts +++ b/packages/worker/jest.config.ts @@ -3,7 +3,6 @@ import * as fs from "fs" const config: Config.InitialOptions = { globalSetup: "./../../globalSetup.ts", - globalTeardown: "./../../globalTeardown.ts", setupFiles: ["./src/tests/jestEnv.ts"], setupFilesAfterEnv: ["./src/tests/jestSetup.ts"], collectCoverageFrom: ["src/**/*.{js,ts}", "../backend-core/src/**/*.{js,ts}"], From a4b940e31dd8a1f2b8b0656a468e1a6e49745c0c Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Tue, 26 Mar 2024 10:00:47 +0000 Subject: [PATCH 15/54] Update pro reference. --- packages/pro | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pro b/packages/pro index 69090a6771..6b62505be0 160000 --- a/packages/pro +++ b/packages/pro @@ -1 +1 @@ -Subproject commit 69090a67715e76f3f22fcb4f605ca0fd328269bc +Subproject commit 6b62505be0c0b50a57b4f4980d86541ebdc86428 From 037becfedc7a9a06c257274aa7e3ae3cb11fe085 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Tue, 26 Mar 2024 10:05:13 +0000 Subject: [PATCH 16/54] Remove testcontainers debug logging. --- packages/server/scripts/test.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/server/scripts/test.sh b/packages/server/scripts/test.sh index c9f063c409..3ecf8bb794 100644 --- a/packages/server/scripts/test.sh +++ b/packages/server/scripts/test.sh @@ -1,8 +1,6 @@ #!/bin/bash set -e -export DEBUG=testcontainers* - if [[ -n $CI ]] then export NODE_OPTIONS="--max-old-space-size=4096 --no-node-snapshot $NODE_OPTIONS" From 06c3cc7e593e7b74631f30358d4f0103798f13e3 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Tue, 26 Mar 2024 10:16:50 +0000 Subject: [PATCH 17/54] Update pro reference. --- packages/pro | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pro b/packages/pro index 6b62505be0..f8e8f87bd5 160000 --- a/packages/pro +++ b/packages/pro @@ -1 +1 @@ -Subproject commit 6b62505be0c0b50a57b4f4980d86541ebdc86428 +Subproject commit f8e8f87bd52081e1303a5ae92c432ea5b38f3bb4 From 6c9127427c6c915044352bef10f158727c412fcd Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Tue, 26 Mar 2024 10:43:56 +0000 Subject: [PATCH 18/54] Fix issues with colours in app skeletons --- .../[screenId]/_components/AppPreview.svelte | 4 ++-- packages/builder/src/stores/builder/theme.js | 15 ++++++++++----- packages/client/src/stores/theme.js | 11 ++--------- packages/frontend-core/src/utils/index.js | 1 + packages/frontend-core/src/utils/theme.js | 12 ++++++++++++ 5 files changed, 27 insertions(+), 16 deletions(-) create mode 100644 packages/frontend-core/src/utils/theme.js diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte index 12d572ecc4..44394fa7ee 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte +++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte @@ -247,9 +247,9 @@
- {#if loading} + {#if loading || true}
diff --git a/packages/builder/src/stores/builder/theme.js b/packages/builder/src/stores/builder/theme.js index afdf3e9805..efa2609b97 100644 --- a/packages/builder/src/stores/builder/theme.js +++ b/packages/builder/src/stores/builder/theme.js @@ -1,5 +1,6 @@ import { writable, get } from "svelte/store" import { API } from "api" +import { getBaseTheme } from "@budibase/frontend-core" const INITIAL_THEMES_STATE = { theme: "", @@ -12,11 +13,15 @@ export const themes = () => { }) const syncAppTheme = app => { - store.update(state => ({ - ...state, - theme: app.theme || "spectrum--light", - customTheme: app.customTheme, - })) + store.update(state => { + const theme = app.theme || "spectrum--light" + return { + ...state, + theme, + baseTheme: getBaseTheme(theme), + customTheme: app.customTheme, + } + }) } const save = async (theme, appId) => { diff --git a/packages/client/src/stores/theme.js b/packages/client/src/stores/theme.js index 8877556f0c..50dad12fa4 100644 --- a/packages/client/src/stores/theme.js +++ b/packages/client/src/stores/theme.js @@ -1,7 +1,7 @@ import { derived } from "svelte/store" import { appStore } from "./app" import { builderStore } from "./builder" -import { Constants } from "@budibase/frontend-core" +import { getBaseTheme } from "@budibase/frontend-core" // This is the good old acorn bug where having the word "g l o b a l" makes it // think that this is not ES6 compatible and starts throwing errors when using @@ -29,13 +29,6 @@ const createThemeStore = () => { // Ensure theme is set theme = theme || defaultTheme - // Get base theme - let base = - Constants.Themes.find(x => `spectrum--${x.class}` === theme)?.base || "" - if (base) { - base = `spectrum--${base}` - } - // Delete and nullish keys from the custom theme if (customTheme) { Object.entries(customTheme).forEach(([key, value]) => { @@ -59,7 +52,7 @@ const createThemeStore = () => { return { theme, - baseTheme: base, + baseTheme: getBaseTheme(theme), customTheme, customThemeCss, } diff --git a/packages/frontend-core/src/utils/index.js b/packages/frontend-core/src/utils/index.js index 98998b7f0e..6b79e1d040 100644 --- a/packages/frontend-core/src/utils/index.js +++ b/packages/frontend-core/src/utils/index.js @@ -7,3 +7,4 @@ export * as RowUtils from "./rows" export { memo, derivedMemo } from "./memo" export { createWebsocket } from "./websocket" export * from "./download" +export * from "./theme" diff --git a/packages/frontend-core/src/utils/theme.js b/packages/frontend-core/src/utils/theme.js new file mode 100644 index 0000000000..165f7c9782 --- /dev/null +++ b/packages/frontend-core/src/utils/theme.js @@ -0,0 +1,12 @@ +import { Themes } from "../constants.js" + +export const getBaseTheme = theme => { + if (!theme) { + return "" + } + let base = Themes.find(x => `spectrum--${x.class}` === theme)?.base || "" + if (base) { + base = `spectrum--${base}` + } + return base +} From 884d9ecf6c9e6e6c98380140a55fbaa7a4e83245 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Tue, 26 Mar 2024 10:45:23 +0000 Subject: [PATCH 19/54] Remove testing code --- .../design/[screenId]/_components/AppPreview.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte index 44394fa7ee..298f044086 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte +++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte @@ -247,7 +247,7 @@
- {#if loading || true} + {#if loading}
Date: Tue, 26 Mar 2024 10:46:58 +0000 Subject: [PATCH 20/54] Remove redundant classes --- .../design/[screenId]/_components/AppPreview.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte index 298f044086..0ce9e096f2 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte +++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte @@ -249,7 +249,7 @@
{#if loading}
From 66009305598b142833a78cee77699cffba18f446 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Tue, 26 Mar 2024 10:51:53 +0000 Subject: [PATCH 21/54] Fix annoying account-portal submodule check --- packages/account-portal | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/account-portal b/packages/account-portal index f5b467b6b1..13b3bc93e1 160000 --- a/packages/account-portal +++ b/packages/account-portal @@ -1 +1 @@ -Subproject commit f5b467b6b1c55c48847545db41be7b1c035e167a +Subproject commit 13b3bc93e115a2ec6c2cde5cfa199773e31a308d From 00d57c7f0fc6e28ed0000321c954112fa0711f0d Mon Sep 17 00:00:00 2001 From: Gerard Burns Date: Tue, 26 Mar 2024 11:06:09 +0000 Subject: [PATCH 22/54] add base theme to portal app preview --- .../src/pages/builder/portal/apps/[appId]/index.svelte | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/builder/src/pages/builder/portal/apps/[appId]/index.svelte b/packages/builder/src/pages/builder/portal/apps/[appId]/index.svelte index a08189a400..d7e0e35289 100644 --- a/packages/builder/src/pages/builder/portal/apps/[appId]/index.svelte +++ b/packages/builder/src/pages/builder/portal/apps/[appId]/index.svelte @@ -20,7 +20,7 @@ import { sdk } from "@budibase/shared-core" import { API } from "api" import ErrorSVG from "./ErrorSVG.svelte" - import { ClientAppSkeleton } from "@budibase/frontend-core" + import { getBaseTheme, ClientAppSkeleton } from "@budibase/frontend-core" $: app = $enrichedApps.find(app => app.appId === $params.appId) $: iframeUrl = getIframeURL(app) @@ -137,7 +137,9 @@ class:hide={!loading || !app?.features?.skeletonLoader} class="loading" > -
+
Date: Tue, 26 Mar 2024 14:47:14 +0000 Subject: [PATCH 23/54] Fix additional scrollbar appearing when hiding binding panels --- .../builder/src/components/common/bindings/BindingPanel.svelte | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/builder/src/components/common/bindings/BindingPanel.svelte b/packages/builder/src/components/common/bindings/BindingPanel.svelte index 21d389357f..10d95a3e7e 100644 --- a/packages/builder/src/components/common/bindings/BindingPanel.svelte +++ b/packages/builder/src/components/common/bindings/BindingPanel.svelte @@ -371,6 +371,7 @@