MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update all form components to update bound values before firing onchange events

This commit is contained in:
Andrew Kingston 2021-04-20 12:49:02 +01:00
parent e3bb206b2d
commit b70afda93c
11 changed files with 19 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/bbui/src/Form/Checkbox.svelte
View File

@ -12,8 +12,8 @@
const dispatch = createEventDispatcher()
const onChange = e => {
dispatch("change", e.detail)
value = e.detail
dispatch("change", e.detail)
}
</script>

2
packages/bbui/src/Form/Combobox.svelte
View File

@ -15,8 +15,8 @@
const dispatch = createEventDispatcher()
const onChange = e => {
dispatch("change", e.detail)
value = e.detail
dispatch("change", e.detail)
}
const extractProperty = (value, property) => {
if (value && typeof value === "object") {

6
packages/bbui/src/Form/Core/Multiselect.svelte
View File

@ -46,10 +46,10 @@
let map = null
if (options?.length) {
map = {}
options.forEach(option => {
const optionValue = getOptionValue(option)
options.forEach((option, idx) => {
const optionValue = getOptionValue(option, idx)
if (optionValue != null) {
map[optionValue] = getOptionLabel(option) || ""
map[optionValue] = getOptionLabel(option, idx) || ""
}
})
}

8
packages/bbui/src/Form/Core/Picker.svelte
View File

@ -81,16 +81,16 @@
</li>
{/if}
{#if options && Array.isArray(options)}
{#each options as option}
{#each options as option, idx}
<li
class="spectrum-Menu-item"
class:is-selected={isOptionSelected(getOptionValue(option))}
class:is-selected={isOptionSelected(getOptionValue(option, idx))}
role="option"
aria-selected="true"
tabindex="0"
on:click={() => onSelectOption(getOptionValue(option))}>
on:click={() => onSelectOption(getOptionValue(option, idx))}>
<span
class="spectrum-Menu-itemLabel">{getOptionLabel(option)}</span>
class="spectrum-Menu-itemLabel">{getOptionLabel(option, idx)}</span>
<svg
class="spectrum-Icon spectrum-UIIcon-Checkmark100 spectrum-Menu-checkmark spectrum-Menu-itemIcon"
focusable="false"

6
packages/bbui/src/Form/Core/Select.svelte
View File

@ -28,8 +28,10 @@
}
// Render the label if the selected option is found, otherwide raw value
const selected = options.find(option => getOptionValue(option) === value)
return selected ? getOptionLabel(selected) : value
const index = options.findIndex(
(option, idx) => getOptionValue(option, idx) === value
)
return index !== -1 ? getOptionLabel(options[index], index) : value
}
const selectOption = value => {

2
packages/bbui/src/Form/Input.svelte
View File

@ -14,8 +14,8 @@
const dispatch = createEventDispatcher()
const onChange = e => {
dispatch("change", e.detail)
value = e.detail
dispatch("change", e.detail)
}
</script>

2
packages/bbui/src/Form/Multiselect.svelte
View File

@ -16,8 +16,8 @@
const dispatch = createEventDispatcher()
const onChange = e => {
dispatch("change", e.detail)
value = e.detail
dispatch("change", e.detail)
}
</script>

2
packages/bbui/src/Form/RadioGroup.svelte
View File

@ -14,8 +14,8 @@
const dispatch = createEventDispatcher()
const onChange = e => {
dispatch("change", e.detail)
value = e.detail
dispatch("change", e.detail)
}
const extractProperty = (value, property) => {
if (value && typeof value === "object") {

2
packages/bbui/src/Form/Select.svelte
View File

@ -16,8 +16,8 @@
const dispatch = createEventDispatcher()
const onChange = e => {
dispatch("change", e.detail)
value = e.detail
dispatch("change", e.detail)
}
const extractProperty = (value, property) => {
if (value && typeof value === "object") {

2
packages/bbui/src/Form/TextArea.svelte
View File

@ -13,8 +13,8 @@
const dispatch = createEventDispatcher()
const onChange = e => {
dispatch("change", e.detail)
value = e.detail
dispatch("change", e.detail)
}
</script>

2
packages/bbui/src/Form/Toggle.svelte
View File

@ -12,8 +12,8 @@
const dispatch = createEventDispatcher()
const onChange = e => {
dispatch("change", e.detail)
value = e.detail
dispatch("change", e.detail)
}
</script>