Review comments.
This commit is contained in:
parent
35aef89661
commit
b84b34d5ae
|
@ -38,31 +38,32 @@ exports.updateRelatedFormula = async (appId, table, enrichedRows) => {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
for (let tableId of table.relatedFormula) {
|
for (let tableId of table.relatedFormula) {
|
||||||
|
let relatedTable
|
||||||
try {
|
try {
|
||||||
// no rows to update, skip
|
// no rows to update, skip
|
||||||
if (!relatedRows[tableId] || relatedRows[tableId].length === 0) {
|
if (!relatedRows[tableId] || relatedRows[tableId].length === 0) {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
const relatedTable = await db.get(tableId)
|
relatedTable = await db.get(tableId)
|
||||||
for (let column of Object.values(relatedTable.schema)) {
|
|
||||||
// needs updated in related rows
|
|
||||||
if (
|
|
||||||
column.type === FieldTypes.FORMULA &&
|
|
||||||
column.formulaType === FormulaTypes.STATIC
|
|
||||||
) {
|
|
||||||
// re-enrich rows for all the related, don't update the related formula for them
|
|
||||||
promises = promises.concat(
|
|
||||||
relatedRows[tableId].map(related =>
|
|
||||||
exports.finaliseRow(appId, relatedTable, related, {
|
|
||||||
updateFormula: false,
|
|
||||||
})
|
|
||||||
)
|
|
||||||
)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
// no error scenario, table doesn't seem to exist anymore, ignore
|
// no error scenario, table doesn't seem to exist anymore, ignore
|
||||||
}
|
}
|
||||||
|
for (let column of Object.values(relatedTable.schema)) {
|
||||||
|
// needs updated in related rows
|
||||||
|
if (
|
||||||
|
column.type === FieldTypes.FORMULA &&
|
||||||
|
column.formulaType === FormulaTypes.STATIC
|
||||||
|
) {
|
||||||
|
// re-enrich rows for all the related, don't update the related formula for them
|
||||||
|
promises = promises.concat(
|
||||||
|
relatedRows[tableId].map(related =>
|
||||||
|
exports.finaliseRow(appId, relatedTable, related, {
|
||||||
|
updateFormula: false,
|
||||||
|
})
|
||||||
|
)
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
await Promise.all(promises)
|
await Promise.all(promises)
|
||||||
|
|
|
@ -37,7 +37,6 @@ function getFormulaThatUseColumn(table, columnNames) {
|
||||||
* This functions checks for when a related table, column or related column is deleted, if any
|
* This functions checks for when a related table, column or related column is deleted, if any
|
||||||
* tables need to have the formula column removed.
|
* tables need to have the formula column removed.
|
||||||
*/
|
*/
|
||||||
|
|
||||||
async function checkIfFormulaNeedsCleared(
|
async function checkIfFormulaNeedsCleared(
|
||||||
appId,
|
appId,
|
||||||
table,
|
table,
|
||||||
|
|
Loading…
Reference in New Issue