From bfc63bd4e26a0498c382ffd4eb3f3a4f0b7fc1cf Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Thu, 9 May 2024 16:26:08 +0100 Subject: [PATCH] Remove the last internal.spec.ts file. --- .../src/api/routes/tests/search.spec.ts | 2 + .../app/rows/search/tests/internal.spec.ts | 117 ------------------ 2 files changed, 2 insertions(+), 117 deletions(-) delete mode 100644 packages/server/src/sdk/app/rows/search/tests/internal.spec.ts diff --git a/packages/server/src/api/routes/tests/search.spec.ts b/packages/server/src/api/routes/tests/search.spec.ts index 7ea3f063de..d036da646e 100644 --- a/packages/server/src/api/routes/tests/search.spec.ts +++ b/packages/server/src/api/routes/tests/search.spec.ts @@ -402,6 +402,7 @@ describe.each([ }, ]) }) + // TODO(samwho): fix for SQS !isSqs && it("should match the session user id in a multi user field", async () => { @@ -419,6 +420,7 @@ describe.each([ ]) }) + // TODO(samwho): fix for SQS !isSqs && it("should not match the session user id in a multi user field", async () => { await expectQuery({ diff --git a/packages/server/src/sdk/app/rows/search/tests/internal.spec.ts b/packages/server/src/sdk/app/rows/search/tests/internal.spec.ts deleted file mode 100644 index 1c5f396737..0000000000 --- a/packages/server/src/sdk/app/rows/search/tests/internal.spec.ts +++ /dev/null @@ -1,117 +0,0 @@ -import { - FieldType, - Row, - Table, - RowSearchParams, - INTERNAL_TABLE_SOURCE_ID, - TableSourceType, -} from "@budibase/types" -import TestConfiguration from "../../../../../tests/utilities/TestConfiguration" -import { search } from "../internal" -import { - expectAnyInternalColsAttributes, - generator, -} from "@budibase/backend-core/tests" - -describe("internal", () => { - const config = new TestConfiguration() - - const tableData: Table = { - name: generator.word(), - type: "table", - sourceId: INTERNAL_TABLE_SOURCE_ID, - sourceType: TableSourceType.INTERNAL, - schema: { - name: { - name: "name", - type: FieldType.STRING, - constraints: { - type: FieldType.STRING, - }, - }, - surname: { - name: "surname", - type: FieldType.STRING, - constraints: { - type: FieldType.STRING, - }, - }, - age: { - name: "age", - type: FieldType.NUMBER, - constraints: { - type: FieldType.NUMBER, - }, - }, - address: { - name: "address", - type: FieldType.STRING, - constraints: { - type: FieldType.STRING, - }, - }, - }, - } - - beforeAll(async () => { - await config.init() - }) - - describe("search", () => { - const rows: Row[] = [] - beforeAll(async () => { - await config.createTable(tableData) - for (let i = 0; i < 10; i++) { - rows.push( - await config.createRow({ - name: generator.first(), - surname: generator.last(), - age: generator.age(), - address: generator.address(), - }) - ) - } - }) - - it("default search returns all the data", async () => { - await config.doInContext(config.appId, async () => { - const tableId = config.table!._id! - - const searchParams: RowSearchParams = { - tableId, - query: {}, - } - const result = await search(searchParams, config.table!) - - expect(result.rows).toHaveLength(10) - expect(result.rows).toEqual( - expect.arrayContaining(rows.map(r => expect.objectContaining(r))) - ) - }) - }) - - it("querying by fields will always return data attribute columns", async () => { - await config.doInContext(config.appId, async () => { - const tableId = config.table!._id! - - const searchParams: RowSearchParams = { - tableId, - query: {}, - fields: ["name", "age"], - } - const result = await search(searchParams, config.table!) - - expect(result.rows).toHaveLength(10) - expect(result.rows).toEqual( - expect.arrayContaining( - rows.map(r => ({ - ...expectAnyInternalColsAttributes, - name: r.name, - age: r.age, - })) - ) - ) - }) - }) - }) -})