From c565e35b5309350e41ce6bc9f6735c49ece38efc Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Thu, 11 Jul 2024 10:59:11 +0200 Subject: [PATCH] Implement find --- .../src/api/controllers/rowAction/crud.ts | 4 ++-- .../src/api/routes/tests/rowAction.spec.ts | 20 ++++++++++++------- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/packages/server/src/api/controllers/rowAction/crud.ts b/packages/server/src/api/controllers/rowAction/crud.ts index 53a417b223..e58a3030fc 100644 --- a/packages/server/src/api/controllers/rowAction/crud.ts +++ b/packages/server/src/api/controllers/rowAction/crud.ts @@ -17,11 +17,11 @@ async function getTable(ctx: Ctx) { export async function find(ctx: Ctx) { const table = await getTable(ctx) - // TODO + const actions = await sdk.rowActions.get(table._id!) ctx.body = { tableId: table._id!, - actions: [], + ...actions, } } diff --git a/packages/server/src/api/routes/tests/rowAction.spec.ts b/packages/server/src/api/routes/tests/rowAction.spec.ts index ebf0e76c09..cec0410282 100644 --- a/packages/server/src/api/routes/tests/rowAction.spec.ts +++ b/packages/server/src/api/routes/tests/rowAction.spec.ts @@ -162,13 +162,7 @@ describe("/rowsActions", () => { describe("find", () => { unauthorisedTests() - it("returns empty for tables without row actions", async () => { - const res = await config.api.rowAction.find(tableId) - - expect(res).toEqual({ tableId, actions: [] }) - }) - - it("returns only the", async () => { + it("returns only the actions for the requested table", async () => { const rowActions = generator.unique(() => createRowActionRequest(), 5) for (const rowAction of rowActions) { await createRowAction(tableId, rowAction) @@ -179,6 +173,18 @@ describe("/rowsActions", () => { ) const otherTableId = otherTable._id! await createRowAction(otherTableId, createRowActionRequest()) + + const response = await config.api.rowAction.find(tableId) + expect(response).toEqual( + expect.objectContaining({ + tableId, + actions: rowActions, + }) + ) + }) + + it("returns 404 for tables without row actions", async () => { + await config.api.rowAction.find(tableId, { status: 404 }) }) }) })