From c57e69d0827fd9d9ee301a56b6aa6685cec96c4f Mon Sep 17 00:00:00 2001
From: Rory Powell <rory.codes@gmail.com>
Date: Tue, 28 Mar 2023 16:07:03 +0100
Subject: [PATCH] Chore: Update livenessprobe timeout, add readinessprobe
 (#10139)

* Chore: Update livenessprobe timeout, add readinessprobe

* Remove liveness and readiness probes from values

* Add clarifying comment to existing liveness and readiness probes

* U[date failureThreshold on readiness probe to be 3
---
 .../budibase/templates/app-service-deployment.yaml  | 13 +++++++++++++
 .../templates/worker-service-deployment.yaml        | 12 ++++++++++++
 charts/budibase/values.yaml                         |  1 +
 3 files changed, 26 insertions(+)

diff --git a/charts/budibase/templates/app-service-deployment.yaml b/charts/budibase/templates/app-service-deployment.yaml
index 9ff7dc1ddc..df4070806f 100644
--- a/charts/budibase/templates/app-service-deployment.yaml
+++ b/charts/budibase/templates/app-service-deployment.yaml
@@ -212,11 +212,24 @@ spec:
         image: budibase/apps:{{ .Values.globals.appVersion }}
         imagePullPolicy: Always
         livenessProbe:
+          httpGet:
+            path: /health
+            port: {{ .Values.services.apps.port }}
+          initialDelaySeconds: 10
+          periodSeconds: 5
+          successThreshold: 1
+          failureThreshold: 3
+          timeoutSeconds: 3
+        readinessProbe:
           httpGet:
             path: /health
             port: {{ .Values.services.apps.port }}
           initialDelaySeconds: 5
           periodSeconds: 5
+          successThreshold: 1
+          failureThreshold: 3
+          timeoutSeconds: 3
+
         name: bbapps
         ports:
         - containerPort: {{ .Values.services.apps.port }}
diff --git a/charts/budibase/templates/worker-service-deployment.yaml b/charts/budibase/templates/worker-service-deployment.yaml
index f998e5dfb9..f48d19689b 100644
--- a/charts/budibase/templates/worker-service-deployment.yaml
+++ b/charts/budibase/templates/worker-service-deployment.yaml
@@ -202,11 +202,23 @@ spec:
         image: budibase/worker:{{ .Values.globals.appVersion }}
         imagePullPolicy: Always
         livenessProbe:
+          httpGet:
+            path: /health
+            port: {{ .Values.services.worker.port }}
+          initialDelaySeconds: 10
+          periodSeconds: 5
+          successThreshold: 1
+          failureThreshold: 3
+          timeoutSeconds: 3
+        readinessProbe:
           httpGet:
             path: /health
             port: {{ .Values.services.worker.port }}
           initialDelaySeconds: 5
           periodSeconds: 5
+          successThreshold: 1
+          failureThreshold: 3
+          timeoutSeconds: 3
         name: bbworker
         ports:
         - containerPort: {{ .Values.services.worker.port }}
diff --git a/charts/budibase/values.yaml b/charts/budibase/values.yaml
index ed4ff014a9..ccbbf9878e 100644
--- a/charts/budibase/values.yaml
+++ b/charts/budibase/values.yaml
@@ -343,6 +343,7 @@ couchdb:
 
   ## Configure liveness and readiness probe values
   ## Ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#configure-probes
+  # FOR COUCHDB
   livenessProbe:
     enabled: true
     failureThreshold: 3