From c614c0739fb02858d73d9922c34edfcc924af0fa Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Mon, 17 Apr 2023 16:22:59 +0100 Subject: [PATCH] Lint --- .../modals/sheet/SheetEditColumnModal.svelte | 1 - .../components/commandPalette/CommandPalette.svelte | 5 ----- packages/builder/src/components/start/AppRow.svelte | 12 ++++++------ .../pages/builder/app/[application]/_layout.svelte | 1 - .../src/components/sheet/cells/HeaderCell.svelte | 10 ---------- .../src/components/sheet/cells/TextCell.svelte | 3 --- .../src/components/sheet/layout/NewRowTop.svelte | 3 --- .../src/components/sheet/layout/SheetRow.svelte | 4 ++-- .../components/sheet/overlays/ScrollOverlay.svelte | 1 - 9 files changed, 8 insertions(+), 32 deletions(-) diff --git a/packages/builder/src/components/backend/DataTable/modals/sheet/SheetEditColumnModal.svelte b/packages/builder/src/components/backend/DataTable/modals/sheet/SheetEditColumnModal.svelte index d3e3d6386f..2e8a785abb 100644 --- a/packages/builder/src/components/backend/DataTable/modals/sheet/SheetEditColumnModal.svelte +++ b/packages/builder/src/components/backend/DataTable/modals/sheet/SheetEditColumnModal.svelte @@ -2,7 +2,6 @@ import { getContext, onMount } from "svelte" import { Modal } from "@budibase/bbui" import CreateEditColumn from "../CreateEditColumn.svelte" - import { tables } from "stores/backend" const { rows, subscribe } = getContext("sheet") diff --git a/packages/builder/src/components/commandPalette/CommandPalette.svelte b/packages/builder/src/components/commandPalette/CommandPalette.svelte index cf976a799e..ae946dc10c 100644 --- a/packages/builder/src/components/commandPalette/CommandPalette.svelte +++ b/packages/builder/src/components/commandPalette/CommandPalette.svelte @@ -325,9 +325,4 @@ text-overflow: ellipsis; white-space: nowrap; } - - footer { - display: flex; - justify-content: center; - } diff --git a/packages/builder/src/components/start/AppRow.svelte b/packages/builder/src/components/start/AppRow.svelte index c6fb0b9531..34d083a096 100644 --- a/packages/builder/src/components/start/AppRow.svelte +++ b/packages/builder/src/components/start/AppRow.svelte @@ -15,12 +15,12 @@ } const goToBuilder = () => { - // if (app.lockedOther) { - // notifications.error( - // `App locked by ${app.lockedBy.email}. Please allow lock to expire or have them unlock this app.` - // ) - // return - // } + if (app.lockedOther) { + notifications.error( + `App locked by ${app.lockedBy.email}. Please allow lock to expire or have them unlock this app.` + ) + return + } $goto(`../../app/${app.devId}`) } diff --git a/packages/builder/src/pages/builder/app/[application]/_layout.svelte b/packages/builder/src/pages/builder/app/[application]/_layout.svelte index d82e8a1094..ff728312c1 100644 --- a/packages/builder/src/pages/builder/app/[application]/_layout.svelte +++ b/packages/builder/src/pages/builder/app/[application]/_layout.svelte @@ -104,7 +104,6 @@ } onMount(async () => { - return if (!hasSynced && application) { try { await API.syncApp(application) diff --git a/packages/frontend-core/src/components/sheet/cells/HeaderCell.svelte b/packages/frontend-core/src/components/sheet/cells/HeaderCell.svelte index 64ef8c3be8..963e76bd95 100644 --- a/packages/frontend-core/src/components/sheet/cells/HeaderCell.svelte +++ b/packages/frontend-core/src/components/sheet/cells/HeaderCell.svelte @@ -80,16 +80,6 @@ open = false } - const moveStart = () => { - reorder.actions.moveColumnToStart(column.name) - open = false - } - - const moveEnd = () => { - reorder.actions.moveColumnToEnd(column.name) - open = false - } - const makeDisplayColumn = () => { columns.actions.changePrimaryDisplay(column.name) open = false diff --git a/packages/frontend-core/src/components/sheet/cells/TextCell.svelte b/packages/frontend-core/src/components/sheet/cells/TextCell.svelte index 4e554f1409..5c7697879d 100644 --- a/packages/frontend-core/src/components/sheet/cells/TextCell.svelte +++ b/packages/frontend-core/src/components/sheet/cells/TextCell.svelte @@ -64,9 +64,6 @@ align-items: flex-start; overflow: hidden; } - .text-cell.editable:hover { - cursor: text; - } .text-cell.number { justify-content: flex-end; } diff --git a/packages/frontend-core/src/components/sheet/layout/NewRowTop.svelte b/packages/frontend-core/src/components/sheet/layout/NewRowTop.svelte index 9c2bd19750..d8d3679e64 100644 --- a/packages/frontend-core/src/components/sheet/layout/NewRowTop.svelte +++ b/packages/frontend-core/src/components/sheet/layout/NewRowTop.svelte @@ -183,9 +183,6 @@ width: 100%; transition: margin-bottom 130ms ease-out; } - .new-row.visible { - margin-bottom: 0; - } .new-row :global(.cell) { --cell-background: var(--background) !important; border-bottom: none; diff --git a/packages/frontend-core/src/components/sheet/layout/SheetRow.svelte b/packages/frontend-core/src/components/sheet/layout/SheetRow.svelte index c5837f126c..729c31e228 100644 --- a/packages/frontend-core/src/components/sheet/layout/SheetRow.svelte +++ b/packages/frontend-core/src/components/sheet/layout/SheetRow.svelte @@ -29,7 +29,7 @@ on:mouseenter={() => ($hoveredRowId = row._id)} on:mouseleave={() => ($hoveredRowId = null)} > - {#each $renderedColumns as column, idx (column.name)} + {#each $renderedColumns as column, columnIdx (column.name)} {@const cellId = `${row._id}-${column.name}`} = $columnHorizontalInversionIndex} + invertX={columnIdx >= $columnHorizontalInversionIndex} highlighted={rowHovered || rowFocused || reorderSource === column.name} selected={rowSelected} rowIdx={idx} diff --git a/packages/frontend-core/src/components/sheet/overlays/ScrollOverlay.svelte b/packages/frontend-core/src/components/sheet/overlays/ScrollOverlay.svelte index 23465101d9..216321b22f 100644 --- a/packages/frontend-core/src/components/sheet/overlays/ScrollOverlay.svelte +++ b/packages/frontend-core/src/components/sheet/overlays/ScrollOverlay.svelte @@ -5,7 +5,6 @@ const { scroll, - rowHeight, contentHeight, maxScrollTop, contentWidth,