PR Feedback

This commit is contained in:
Gerard Burns 2023-06-27 15:49:17 +01:00
parent 363db1d4d9
commit c749209172
7 changed files with 10 additions and 29 deletions

View File

@ -23,7 +23,7 @@
} }
const afterSave = ({ action }) => { const afterSave = ({ action }) => {
notifications.success(`Relationship ${action} successfully.`) notifications.success(`Relationship ${action} successfully`)
dispatch("updatecolumns") dispatch("updatecolumns")
} }

View File

@ -69,7 +69,7 @@
$goto(`./datasource/${datasourceId}`) $goto(`./datasource/${datasourceId}`)
} }
notifications.success(`Imported successfully.`) notifications.success("Imported successfully")
return true return true
} catch (error) { } catch (error) {
notifications.error("Error importing queries") notifications.error("Error importing queries")

View File

@ -64,7 +64,7 @@
const afterSave = async ({ action }) => { const afterSave = async ({ action }) => {
await tablesStore.fetch() await tablesStore.fetch()
await datasourcesStore.fetch() await datasourcesStore.fetch()
notifications.success(`Relationship ${action} successfully.`) notifications.success(`Relationship ${action} successfully`)
} }
const onError = async ({ action, err }) => { const onError = async ({ action, err }) => {

View File

@ -18,7 +18,7 @@
) )
await datasources.update({ datasource: updatedDatasource, integration }) await datasources.update({ datasource: updatedDatasource, integration })
notifications.success( notifications.success(
`Datasource ${updatedDatasource.name} updated successfully.` `Datasource ${updatedDatasource.name} updated successfully`
) )
} catch (error) { } catch (error) {
notifications.error(`Error saving datasource: ${error.message}`) notifications.error(`Error saving datasource: ${error.message}`)

View File

@ -15,7 +15,7 @@
async function updateDatasourceSchema() { async function updateDatasourceSchema() {
try { try {
await datasources.updateSchema(datasource, specificTables) await datasources.updateSchema(datasource, specificTables)
notifications.success(`Datasource ${name} tables updated successfully.`) notifications.success(`Datasource ${name} tables updated successfully`)
await tables.fetch() await tables.fetch()
} catch (error) { } catch (error) {
notifications.error( notifications.error(

View File

@ -1,30 +1,11 @@
<script> <script>
import FontAwesomeIcon from "components/common/FontAwesomeIcon.svelte" import FontAwesomeIcon from "components/common/FontAwesomeIcon.svelte"
import { Body } from "@budibase/bbui" import { ActionButton } from "@budibase/bbui"
export let title = "" export let title = ""
export let href = null export let href = null
</script> </script>
<a {href} class="tooltip" target="_blank" rel="noopener noreferrer"> <ActionButton quiet icon="Help" on:click={() => window.open(href, "_blank")}>
<FontAwesomeIcon name="fa-solid fa-question-circle" /> {title}
<Body weight="bold">{title}</Body> </ActionButton>
</a>
<style>
.tooltip {
display: flex;
align-items: center;
cursor: pointer;
}
.tooltip :global(p) {
color: var(--grey-9);
}
.tooltip :global(svg) {
margin-top: 1px;
margin-right: 5px;
color: var(--grey-7);
}
</style>

View File

@ -100,7 +100,7 @@ export function createDatasourcesStore() {
const create = async ({ integration, config }) => { const create = async ({ integration, config }) => {
const count = sourceCount(integration.name) const count = sourceCount(integration.name)
const nameModifier = count === 0 ? "" : `-${count + 1}` const nameModifier = count === 0 ? "" : ` ${count + 1}`
const datasource = { const datasource = {
type: "datasource", type: "datasource",