Merge pull request #8116 from Budibase/fix/linting

Fix linting for qa-core

qa-core/src/config/internal-api/TestConfiguration/InternalAPIClient.ts

@@ -16,9 +16,7 @@ class InternalAPIClient {
 
   constructor(appId?: string) {
     if (!env.BUDIBASE_SERVER_URL) {
-      throw new Error(
+      throw new Error("Must set BUDIBASE_SERVER_URL env var")
-        "Must set BUDIBASE_SERVER_URL env var"
-      )
     }
     this.host = `${env.BUDIBASE_SERVER_URL}/api`
     this.appId = appId

qa-core/src/config/internal-api/TestConfiguration/applications.ts

@@ -1,6 +1,4 @@
-import {
+import { Application } from "@budibase/server/api/controllers/public/mapping/types"
-  Application,
-} from "@budibase/server/api/controllers/public/mapping/types"
 import { App } from "@budibase/types"
 import { Response } from "node-fetch"
 import InternalAPIClient from "./InternalAPIClient"
@@ -37,9 +35,7 @@ export default class AppApi {
     return [response, json]
   }
 
-  async create(
+  async create(body: any): Promise<[Response, Partial<App>]> {
-    body: any
-  ): Promise<[Response, Partial<App>]> {
     const response = await this.api.post(`/applications`, { body })
     const json = await response.json()
     return [response, json]

qa-core/src/config/internal-api/TestConfiguration/auth.ts

@@ -12,8 +12,8 @@ export default class AuthApi {
     const response = await this.api.post(`/global/auth/default/login`, {
       body: {
         username: process.env.BB_ADMIN_USER_EMAIL,
-        password: process.env.BB_ADMIN_USER_PASSWORD
+        password: process.env.BB_ADMIN_USER_PASSWORD,
-      }
+      },
     })
     const cookie = response.headers.get("set-cookie")
     this.api.cookie = cookie as any

qa-core/src/config/internal-api/fixtures/applications.ts

@@ -1,10 +1,9 @@
 import generator from "../../generator"
-import {
+import { Application } from "@budibase/server/api/controllers/public/mapping/types"
-  Application,
-} from "@budibase/server/api/controllers/public/mapping/types"
 
-
+const generate = (
-const generate = (overrides: Partial<Application> = {}): Partial<Application> => ({
+  overrides: Partial<Application> = {}
+): Partial<Application> => ({
   name: generator.word(),
   url: `/${generator.word()}`,
   ...overrides,

qa-core/src/tests/internal-api/applications/create.spec.ts

@@ -24,14 +24,14 @@ describe("Internal API - /applications endpoints", () => {
       useTemplate: "true",
       templateName: "Near Miss Register",
       templateKey: "app/near-miss-register",
-      templateFile: undefined
+      templateFile: undefined,
     })
   }
 
   it("GET - fetch applications", async () => {
     await config.applications.create({
       ...generateApp(),
-      useTemplate: false
+      useTemplate: false,
     })
     const [response, apps] = await config.applications.fetch()
     expect(response).toHaveStatusCode(200)
@@ -57,7 +57,7 @@ describe("Internal API - /applications endpoints", () => {
     expect(publish).toEqual({
       _id: expect.any(String),
       appUrl: app.url,
-      status: "SUCCESS"
+      status: "SUCCESS",
     })
   })
 
@@ -70,7 +70,8 @@ describe("Internal API - /applications endpoints", () => {
     config.applications.api.appId = app.appId
 
     // check preview renders
-    const [previewResponse, previewRenders] = await config.applications.canRender()
+    const [previewResponse, previewRenders] =
+      await config.applications.canRender()
     expect(previewResponse).toHaveStatusCode(200)
     expect(previewRenders).toBe(true)
 
@@ -79,8 +80,8 @@ describe("Internal API - /applications endpoints", () => {
 
     // check published app renders
     config.applications.api.appId = db.getProdAppID(app.appId)
-    const [publishedAppResponse, publishedAppRenders] = await config.applications.canRender()
+    const [publishedAppResponse, publishedAppRenders] =
+      await config.applications.canRender()
     expect(publishedAppRenders).toBe(true)
   })
-
 })