From ca452d7dcee2ce4ef58c679faf6ccd7d2ff5526d Mon Sep 17 00:00:00 2001
From: Gerard Burns <gjburns9@hotmail.com>
Date: Mon, 13 May 2024 22:42:09 +0100
Subject: [PATCH] feedback

---
 packages/client/package.json                               | 1 -
 packages/client/src/components/app/charts/ApexChart.svelte | 2 +-
 packages/server/src/api/controllers/component.ts           | 1 +
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/client/package.json b/packages/client/package.json
index 1bbf7319cb..d8b2fa9447 100644
--- a/packages/client/package.json
+++ b/packages/client/package.json
@@ -37,7 +37,6 @@
     "downloadjs": "1.4.7",
     "html5-qrcode": "^2.2.1",
     "leaflet": "^1.7.1",
-    "lodash": "^4.17.21",
     "sanitize-html": "^2.7.0",
     "screenfull": "^6.0.1",
     "shortid": "^2.2.15",
diff --git a/packages/client/src/components/app/charts/ApexChart.svelte b/packages/client/src/components/app/charts/ApexChart.svelte
index 6010c326ac..8cbdbd0cca 100644
--- a/packages/client/src/components/app/charts/ApexChart.svelte
+++ b/packages/client/src/components/app/charts/ApexChart.svelte
@@ -10,7 +10,7 @@
   export let options
 
   // Apex charts directly modifies the options object with default properties and internal variables. These being present could unintentionally cause issues to the provider of this prop as the changes are reflected in that component as well. To prevent any issues we clone options here to provide a buffer.
-  $: optionsCopy = cloneDeep(options)
+  $: optionsCopy = structuredClone(options)
 
   let chartElement
   let chart
diff --git a/packages/server/src/api/controllers/component.ts b/packages/server/src/api/controllers/component.ts
index 44d7255ecb..6d4d3e2d21 100644
--- a/packages/server/src/api/controllers/component.ts
+++ b/packages/server/src/api/controllers/component.ts
@@ -20,6 +20,7 @@ export async function fetchAppComponentDefinitions(ctx: UserCtx) {
     const definitions: { [key: string]: any } = {}
     for (let { manifest, library } of componentManifests) {
       for (let key of Object.keys(manifest)) {
+        // These keys are not components, and should not be preprended with the `@budibase/` prefix
         if (key === "features" || key === "typeSupportPresets") {
           definitions[key] = manifest[key]
         } else {