From ccb32af0786299ee483735f86b524dbc42e766ce Mon Sep 17 00:00:00 2001
From: Andrew Kingston <andrew@kingston.dev>
Date: Thu, 7 Mar 2024 08:25:11 +0000
Subject: [PATCH] Add deletion confirmation to snippets

---
 .../common/bindings/SnippetDrawer.svelte      | 23 ++++++++++++++-----
 .../[screenId]/_components/AppPreview.svelte  |  2 ++
 2 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/packages/builder/src/components/common/bindings/SnippetDrawer.svelte b/packages/builder/src/components/common/bindings/SnippetDrawer.svelte
index 9b91b1a47c..e7dd5c7a22 100644
--- a/packages/builder/src/components/common/bindings/SnippetDrawer.svelte
+++ b/packages/builder/src/components/common/bindings/SnippetDrawer.svelte
@@ -12,6 +12,7 @@
   import { decodeJSBinding, encodeJSBinding } from "@budibase/string-templates"
   import { snippets } from "stores/builder"
   import { getSequentialName } from "helpers/duplicate"
+  import ConfirmDialog from "components/common/ConfirmDialog.svelte"
 
   export let snippet
 
@@ -25,6 +26,7 @@
   let name = ""
   let code = ""
   let loading = false
+  let deleteConfirmationDialog
 
   $: defaultName = getSequentialName($snippets, "MySnippet", x => x.name)
   $: key = snippet?.name
@@ -36,12 +38,10 @@
   const saveSnippet = async () => {
     loading = true
     try {
-      await snippets.saveSnippet({
-        name,
-        code: rawJS,
-      })
+      const newSnippet = { name, code: rawJS }
+      await snippets.saveSnippet(newSnippet)
       drawer.hide()
-      notifications.success(`Snippet ${name} saved`)
+      notifications.success(`Snippet ${newSnippet.name} saved`)
     } catch (error) {
       notifications.error("Error saving snippet")
     }
@@ -109,7 +109,11 @@
   </svelte:fragment>
   <svelte:fragment slot="buttons">
     {#if snippet}
-      <Button warning on:click={deleteSnippet} disabled={loading}>
+      <Button
+        warning
+        on:click={deleteConfirmationDialog.show}
+        disabled={loading}
+      >
         Delete
       </Button>
     {/if}
@@ -136,6 +140,13 @@
   </svelte:fragment>
 </Drawer>
 
+<ConfirmDialog
+  bind:this={deleteConfirmationDialog}
+  title="Delete snippet"
+  body={`Are you sure you want to delete ${snippet?.name}?`}
+  onOk={deleteSnippet}
+/>
+
 <style>
   .name {
     display: flex;
diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte
index 530b3eee2c..cadc83d16a 100644
--- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte
+++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/AppPreview.svelte
@@ -10,6 +10,7 @@
     navigationStore,
     selectedScreen,
     hoverStore,
+    snippets,
   } from "stores/builder"
   import ConfirmDialog from "components/common/ConfirmDialog.svelte"
   import {
@@ -68,6 +69,7 @@
       hostname: window.location.hostname,
       port: window.location.port,
     },
+    snippets: $snippets,
   }
 
   // Refresh the preview when required