MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Respond to Mike's feedback.

This commit is contained in:
Sam Rose 2024-04-04 15:27:50 +01:00
parent b6431e57ff
commit d0a5ae6ae3
No known key found for this signature in database
3 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/server/jest.config.ts
View File

@ -54,12 +54,9 @@ const config: Config.InitialOptions = {
"!src/db/views/staticViews.*", "!src/db/views/staticViews.*",
"!src/**/*.spec.{js,ts}", "!src/**/*.spec.{js,ts}",
"!src/tests/**/*.{js,ts}", "!src/tests/**/*.{js,ts}",
// The use of coverage in the JS runner bundles breaks tests // The use of coverage in the JS runner breaks tests by inserting
"!src/jsRunner/bundles/**/*.{js,ts}", // coverage functions into code that will run inside of the isolate.
// We have a polyfill for the TextDecoder class in here that gets "!src/jsRunner/**/*.{js,ts}",
// injected into the vm for deserializing BSON. If it gets coveraged
// it breaks the tests.
"!src/jsRunner/vm/isolated-vm.ts",
], ],
coverageReporters: ["lcov", "json", "clover"], coverageReporters: ["lcov", "json", "clover"],
} }

2
packages/server/package.json
View File

@ -143,7 +143,7 @@
"jest": "29.7.0", "jest": "29.7.0",
"jest-openapi": "0.14.2", "jest-openapi": "0.14.2",
"jest-runner": "29.7.0", "jest-runner": "29.7.0",
"nock": "^13.5.4", "nock": "13.5.4",
"nodemon": "2.0.15", "nodemon": "2.0.15",
"openapi-typescript": "5.2.0", "openapi-typescript": "5.2.0",
"path-to-regexp": "6.2.0", "path-to-regexp": "6.2.0",

9
packages/server/src/api/controllers/query/index.ts
View File

@ -299,7 +299,14 @@ export async function preview(
}, },
} }
const { rows, keys, info, extra } = await Runner.run<QueryResponse>(inputs) let queryResponse: QueryResponse
try {
queryResponse = await Runner.run<QueryResponse>(inputs)
} catch (err: any) {
ctx.throw(400, err)
}
const { rows, keys, info, extra } = queryResponse
const { previewSchema, nestedSchemaFields } = getSchemaFields(rows, keys) const { previewSchema, nestedSchemaFields } = getSchemaFields(rows, keys)
// if existing schema, update to include any previous schema keys // if existing schema, update to include any previous schema keys