MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Handle errors as a part of the instance to avoid extra refreshes

This commit is contained in:
Adria Navarro 2025-01-22 16:18:29 +01:00
parent 2213cd56c4
commit d3b22e461e
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/client/src/components/Component.svelte
View File

@ -138,7 +138,7 @@
// Derive definition properties which can all be optional, so need to be // Derive definition properties which can all be optional, so need to be
// coerced to booleans // coerced to booleans
$: invalidSettings = $builderStore.componentErrors[instance._id] $: invalidSettings = instance?._meta?.errors
$: hasChildren = !!definition?.hasChildren $: hasChildren = !!definition?.hasChildren
$: showEmptyState = definition?.showEmptyState !== false $: showEmptyState = definition?.showEmptyState !== false
$: hasMissingRequiredSettings = missingRequiredSettings?.length > 0 $: hasMissingRequiredSettings = missingRequiredSettings?.length > 0

8
packages/client/src/stores/screens.js
View File

@ -42,6 +42,14 @@ const createScreenStore = () => {
if ($builderStore.layout) { if ($builderStore.layout) {
activeLayout = $builderStore.layout activeLayout = $builderStore.layout
} }
// Attach meta
const errors = $builderStore.componentErrors || {}
const attachComponentMeta = component => {
component._meta = { errors: errors[component._id] || [] }
component._children?.forEach(attachComponentMeta)
}
attachComponentMeta(activeScreen.props)
} else { } else {
// Find the correct screen by matching the current route // Find the correct screen by matching the current route
screens = $appStore.screens || [] screens = $appStore.screens || []